Re: [Django] #14964: create_attachment support for unicode symbols in filename

[Django]

#14964: create_attachment support for unicode symbols in filename
-+-
 Reporter:  Anton Chaporgin  |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Core (Mail)  |  Version:  SVN
 Severity:  Normal   |   Resolution:  fixed
 Keywords:  email attachment,| Triage Stage:  Ready for
  filenames, i18n|  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by ramiro):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [17375]:
 {{{
 #!CommitTicketReference repository="" revision="17375"
 Made email attachment handling code accept non-ASCII filenames.

 Thanks to Anton Chaporgin for the report and to Claude Paroz for the
 patch.

 Fixes #14964.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14964: create_attachment support for unicode symbols in filename

[Django]

#14964: create_attachment support for unicode symbols in filename
-+-
 Reporter:  Anton Chaporgin  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Mail)  |  Version:  SVN
 Severity:  Normal   |   Resolution:
 Keywords:  email attachment,| Triage Stage:  Ready for
  filenames, i18n|  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by ramiro):

 * stage:  Accepted => Ready for checkin


Comment:

 #17536 was a duplicate.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14964: create_attachment support for unicode symbols in filename

[Django]

#14964: create_attachment support for unicode symbols in filename
-+-
 Reporter:  Anton Chaporgin  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Mail)  |  Version:  SVN
 Severity:  Normal   |   Resolution:
 Keywords:  email attachment,| Triage Stage:  Accepted
  filenames, i18n|  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by claudep):

 * needs_better_patch:  1 => 0
 * type:  New feature => Bug
 * needs_tests:  1 => 0


Comment:

 My patch was inspired by
 
http://docs.python.org/library/email.message.html#email.message.Message.add_header

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14964: create_attachment support for unicode symbols in filename

[Django]

#14964: create_attachment support for unicode symbols in filename
-+-
 Reporter:  Anton Chaporgin  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Core (Mail)  |  Version:  SVN
 Severity:  Normal   |   Resolution:
 Keywords:  email attachment,| Triage Stage:  Accepted
  filenames, i18n|  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  1|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by anonymous):

 * ui_ux:   => 0
 * easy:   => 0


Comment:

 The [http://docs.python.org/library/email.header.html standard library
 Header class] might be a better way to do this. It handles various RFCs.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14964: create_attachment support for unicode symbols in filename

[Django]

#14964: create_attachment support for unicode symbols in filename
-+-
   Reporter:  Anton  |Owner:  nobody
  Chaporgin  |   Status:  new
   Type:  New|Component:  Core (Mail)
  feature| Severity:  Normal
  Milestone: | Keywords:  email attachment,
Version:  SVN|  filenames, i18n
 Resolution: |Has patch:  1
   Triage Stage:  Accepted   |  Needs tests:  1
Needs documentation:  0  |
Patch needs improvement:  1  |
-+-
Changes (by anonymous):

 * type:   => New feature
 * severity:   => Normal


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14964: create_attachment support for unicode symbols in filename

[Django]

#14964: create_attachment support for unicode symbols in filename
---+
  Reporter:  Anton Chaporgin   | Owner:  nobody 
  
Status:  new   | Milestone: 
  
 Component:  django.core.mail  |   Version:  SVN
  
Resolution:|  Keywords:  email attachment, 
filenames, i18n
 Stage:  Accepted  | Has_patch:  1  
  
Needs_docs:  0 |   Needs_tests:  1  
  
Needs_better_patch:  1 |  
---+
Changes (by russellm):

  * needs_better_patch:  => 1
  * component:  Core framework => django.core.mail
  * needs_tests:  => 1
  * needs_docs:  => 0
  * has_patch:  0 => 1
  * stage:  Unreviewed => Accepted

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #14964: create_attachment support for unicode symbols in filename

[Django]

#14964: create_attachment support for unicode symbols in filename
---+
 Reporter:  Anton Chaporgin|   Owner:  nobody
   Status:  new|   Milestone:
Component:  Core framework | Version:  SVN   
 Keywords:  email attachment, filenames, i18n  |   Stage:  Unreviewed
Has_patch:  0  |  
---+
 When attaching a file containing non ASCII symbols, the standarts required
 adding special prefix to the filename. For example, when file name is in
 unicode, like u"Имя Файла.txt" ("filename.txt" in english), the headers in
 the letter should be

 filename:
 
"UTF-8''%C3%90%C2%98%C3%90%C2%BC%C3%91%C2%8F%20%C3%90%C2%A4%C3%90%C2%B0%C3%90%C2%B9%C3%90%C2%BB%C3%90%C2%B0.txt"

 So, I suggest adding special check for this case in "_create_attachment"
 method of EmailMessage class, see attached diff.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.