Re: [Django] #14972: AdminEmailHandler breaks when logger is missing stack trace information

[Django]

#14972: AdminEmailHandler breaks when logger is missing stack trace information
-+--
  Reporter:  jamstooks   | Owner:  nobody   
Status:  new | Milestone:  1.3  
 Component:  Core framework  |   Version:  1.3-alpha
Resolution:  |  Keywords:  blocker  
 Stage:  Accepted| Has_patch:  0
Needs_docs:  0   |   Needs_tests:  0
Needs_better_patch:  0   |  
-+--
Changes (by russellm):

  * keywords:  => blocker

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #14972: AdminEmailHandler breaks when logger is missing stack trace information

[Django]

#14972: AdminEmailHandler breaks when logger is missing stack trace information
-+--
  Reporter:  jamstooks   | Owner:  nobody   
Status:  new | Milestone:  1.3  
 Component:  Core framework  |   Version:  1.3-alpha
Resolution:  |  Keywords:   
 Stage:  Accepted| Has_patch:  0
Needs_docs:  0   |   Needs_tests:  0
Needs_better_patch:  0   |  
-+--
Changes (by russellm):

  * needs_better_patch:  => 0
  * needs_docs:  => 0
  * stage:  Unreviewed => Accepted
  * needs_tests:  => 0
  * milestone:  => 1.3

Comment:

 AdmineEmailHandler already has checks for whether the report has exc_info,
 so the fix should be in ExceptionReporter.

 Since this is a new 1.3 feature, this is a 1.3 blocker.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #14972: AdminEmailHandler breaks when logger is missing stack trace information

[Django]

#14972: AdminEmailHandler breaks when logger is missing stack trace information
+---
 Reporter:  jamstooks   |   Owner:  nobody
   Status:  new |   Milestone:
Component:  Core framework  | Version:  1.3-alpha 
 Keywords:  |   Stage:  Unreviewed
Has_patch:  0   |  
+---
 If a log message doesn't have stack trace info then record.exc_info is ()
 and ExceptionReporter !__init!__() breaks. I assume this is because
 *exc_info should contain the keyword arguments, but is assigned to ():

 {{{
 # django/utils/log.py line # 89
 exc_info = ()
 ...
 reporter = ExceptionReporter(request, is_email=True, *exc_info)
 # ERROR: __init__() takes at least 5 non-keyword arguments (2 given)
 }}}

 I'd be happy to build a patch for this in some way (if this is indeed a
 bug), but I'm not sure if the fix belongs in AdminEmailHandler or
 ExceptionReporter.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.