[Django] #15015: Mixing read-only with ability to add new instances using a FormSet

[Django]

#15015: Mixing read-only with ability to add new instances using a FormSet
--+-
 Reporter:  coleifer  |   Owner:  nobody
   Status:  new   |   Milestone:
Component:  Forms | Version:  1.2   
 Keywords:  formset   |   Stage:  Unreviewed
Has_patch:  0 |  
--+-
 A little background, I've been attempting to add permission-awareness to
 admin inlines using a technique like the one mentioned here:
 http://code.djangoproject.com/ticket/8060#comment:9

 The problem occurs when I want to allow a user to be able to add new
 inline instances, but display the pre-existing ones as read-only.  By
 overriding the get_readonly_fields() method in the event the user doesn't
 have change permissions, I'm able to make everything read-only...but this
 includes the formset's "extra_forms", or when the user clicks to add a new
 row.

 Since read-only is an admin thing and is implemented in the formset-level
 as "exclude", it's going to be kind of tricky to tell, using just the
 FormSet API, which fields are actually excluded and which are just read-
 only.  I would propose making readonly_fields an attribute of the form,
 just like exclude.  Additionally, it makes sense to me for any
 'extra_forms' on the FormSet to display all non-excluded fields as
 editable.  Having a read-only field on a form that does not contain any
 data is odd.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15015: Mixing read-only with ability to add new instances using a FormSet

[Django]

#15015: Mixing read-only with ability to add new instances using a FormSet
-+-
 Reporter:  coleifer |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  1.2
 Severity:  Normal   |   Resolution:
 Keywords:  formset  | Triage Stage:  Design
Has patch:  0|  decision needed
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by wiml):

 * cc: wiml@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #15015: Mixing read-only with ability to add new instances using a FormSet

[Django]

#15015: Mixing read-only with ability to add new instances using a FormSet
-+
 Reporter:  coleifer |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  1.2
 Severity:  Normal   |   Resolution:
 Keywords:  formset  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by jacob):

 * stage:  Design decision needed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #15015: Mixing read-only with ability to add new instances using a FormSet

[Django]

#15015: Mixing read-only with ability to add new instances using a FormSet
-+
 Reporter:  coleifer |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Forms|  Version:  1.2
 Severity:  Normal   |   Resolution:
 Keywords:  formset  | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by Sergey Fedoseev):

 * cc: Sergey Fedoseev (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.9bba8a080dd02c947a9f760ec9e2b604%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #15015: Mixing read-only with ability to add new instances using a FormSet

[Django]

#15015: Mixing read-only with ability to add new instances using a FormSet
-+--
  Reporter:  coleifer| Owner:  nobody 
Status:  new | Milestone: 
 Component:  Forms   |   Version:  1.2
Resolution:  |  Keywords:  formset
 Stage:  Design decision needed  | Has_patch:  0  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Changes (by russellm):

  * needs_better_patch:  => 0
  * stage:  Unreviewed => Design decision needed
  * needs_tests:  => 0
  * needs_docs:  => 0

Comment:

 The complication here is that *forms* have no concept of readonly fields
 -- that's an admin-specific feature. By extension, formsets don't have any
 knowledge of readonly fields either. This is by design; we added readonly
 fields as a specific admin feature, not as a general feature of the forms
 library.

 However, I can accept the use case; marking DDN because we need to work
 out the details of how to expose this as an admin feature.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15015: Mixing read-only with ability to add new instances using a FormSet

[Django]

#15015: Mixing read-only with ability to add new instances using a FormSet
-+--
  Reporter:  coleifer| Owner:  nobody 
Status:  new | Milestone: 
 Component:  Forms   |   Version:  1.2
Resolution:  |  Keywords:  formset
 Stage:  Design decision needed  | Has_patch:  0  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Comment (by coleifer):

 Replying to [comment:1 russellm]:
 > The complication here is that *forms* have no concept of readonly fields
 -- that's an admin-specific feature. By extension, formsets don't have any
 knowledge of readonly fields either. This is by design; we added readonly
 fields as a specific admin feature, not as a general feature of the forms
 library.


 Totally, I'd propose moving the readonly behavior into the forms API and
 converting the admin from a special-case to a general one.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15015: Mixing read-only with ability to add new instances using a FormSet

[Django]

#15015: Mixing read-only with ability to add new instances using a FormSet
-+--
  Reporter:  coleifer| Owner:  nobody 
Status:  new | Milestone: 
 Component:  Forms   |   Version:  1.2
Resolution:  |  Keywords:  formset
 Stage:  Design decision needed  | Has_patch:  0  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Comment (by russellm):

 And I'm saying that ain't gonna happen. Leaving out readonly widgets from
 the forms library was a very *specific* design decision. Check the
 archives for the discussions on the topic.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15015: Mixing read-only with ability to add new instances using a FormSet

[Django]

#15015: Mixing read-only with ability to add new instances using a FormSet
-+--
  Reporter:  coleifer| Owner:  nobody 
Status:  new | Milestone: 
 Component:  Forms   |   Version:  1.2
Resolution:  |  Keywords:  formset
 Stage:  Design decision needed  | Has_patch:  0  
Needs_docs:  0   |   Needs_tests:  0  
Needs_better_patch:  0   |  
-+--
Comment (by coleifer):

 Replying to [comment:3 russellm]:
 > And I'm saying that ain't gonna happen. Leaving out readonly widgets
 from the forms library was a very *specific* design decision. Check the
 archives for the discussions on the topic.

 Fair enough.  I think my initial use case is still valid, basically
 allowing read_only fields to be specified for admin inlines, but having
 those read_only fields not affect adding new rows (i.e. you can't edit
 existing inline items but can add new ones).  This jives a lot with the
 "can_add" vs "can_edit" permission workflow.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-upda...@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15015: Mixing read-only with ability to add new instances using a FormSet

[Django]

#15015: Mixing read-only with ability to add new instances using a FormSet
--+---
   Reporter:  coleifer|Owner:  nobody
   Type:  New feature |   Status:  new
  Milestone:  |Component:  Forms
Version:  1.2 | Severity:  Normal
 Resolution:  | Keywords:  formset
   Triage Stage:  Design decision needed  |Has patch:  0
Needs documentation:  0   |  Needs tests:  0
Patch needs improvement:  0   |
--+---
Changes (by anonymous):

 * type:   => New feature
 * severity:   => Normal


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15015: Mixing read-only with ability to add new instances using a FormSet

[Django]

#15015: Mixing read-only with ability to add new instances using a FormSet
--+---
   Reporter:  coleifer|Owner:  nobody
   Type:  New feature |   Status:  new
  Milestone:  |Component:  Forms
Version:  1.2 | Severity:  Normal
 Resolution:  | Keywords:  formset
   Triage Stage:  Design decision needed  |Has patch:  0
Needs documentation:  0   |  Needs tests:  0
Patch needs improvement:  0   |
--+---
Changes (by jdunck):

 * cc: jdunck@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.