Re: [Django] #15076: inspectdb to quote ForeignKey class names to avoid need to reorder classes/solve circular dependencies

[Django]

#15076: inspectdb to quote ForeignKey class names to avoid need to reorder
classes/solve circular dependencies
-+-
 Reporter:  saschwarz|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Core (Management |  Version:  1.2
  commands)  |   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:  inspectdb|  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by claudep):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [17942]:
 {{{
 #!CommitTicketReference repository="" revision="17942"
 Fixed #15076 -- Quoted ForeignKey target class names in inspectdb when
 class is defined below.

 Thanks saschwarz for the report, j...@deserettechnology.com for the
 initial patch and Ramiro Morales for the review.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15076: inspectdb to quote ForeignKey class names to avoid need to reorder classes/solve circular dependencies

[Django]

#15076: inspectdb to quote ForeignKey class names to avoid need to reorder
classes/solve circular dependencies
-+-
 Reporter:  saschwarz|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Management |  Version:  1.2
  commands)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:  inspectdb|  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by ramiro):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15076: inspectdb to quote ForeignKey class names to avoid need to reorder classes/solve circular dependencies

[Django]

#15076: inspectdb to quote ForeignKey class names to avoid need to reorder
classes/solve circular dependencies
-+-
 Reporter:  saschwarz|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Management |  Version:  1.2
  commands)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  inspectdb|  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by claudep):

 * has_patch:  0 => 1
 * needs_tests:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15076: inspectdb to quote ForeignKey class names to avoid need to reorder classes/solve circular dependencies

[Django]

#15076: inspectdb to quote ForeignKey class names to avoid need to reorder
classes/solve circular dependencies
-+-
 Reporter:  saschwarz|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Management |  Version:  1.2
  commands)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  inspectdb|  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  1|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by ramiro):

 * stage:  Design decision needed => Accepted


Comment:

 #9164 was a duplicate.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15076: inspectdb to quote ForeignKey class names to avoid need to reorder classes/solve circular dependencies

[Django]

#15076: inspectdb to quote ForeignKey class names to avoid need to reorder
classes/solve circular dependencies
-+-
 Reporter:  saschwarz|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Core (Management |  Version:  1.2
  commands)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Design
 Keywords:  inspectdb|  decision needed
Has patch:  0|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by ramiro):

 * needs_tests:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15076: inspectdb to quote ForeignKey class names to avoid need to reorder classes/solve circular dependencies

[Django]

#15076: inspectdb to quote ForeignKey class names to avoid need to reorder
classes/solve circular dependencies
-+-
   Reporter:  saschwarz  |  Owner:  nobody
   Type:  Bug| Status:  new
  Milestone: |  Component:  Core (Management
Version:  1.2|  commands)
 Resolution: |   Severity:  Normal
   Triage Stage:  Design |   Keywords:  inspectdb
  decision needed|  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
Changes (by ramiro):

 * keywords:   => inspectdb


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15076: inspectdb to quote ForeignKey class names to avoid need to reorder classes/solve circular dependencies

[Django]

#15076: inspectdb to quote ForeignKey class names to avoid need to reorder
classes/solve circular dependencies
-+-
   Reporter:  saschwarz  |  Owner:  nobody
   Type:  Bug| Status:  new
  Milestone: |  Component:  Core (Management
Version:  1.2|  commands)
 Resolution: |   Severity:  Normal
   Triage Stage:  Design |   Keywords:
  decision needed|  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
Changes (by aaugustin):

 * ui_ux:   => 0
 * easy:   => 0


Comment:

 #16476 was a duplicate. And yes, it sounds like a good idea.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15076: inspectdb to quote ForeignKey class names to avoid need to reorder classes/solve circular dependencies

[Django]

#15076: inspectdb to quote ForeignKey class names to avoid need to reorder
classes/solve circular dependencies
-+-
   Reporter:  saschwarz  |Owner:  nobody
   Type:  Bug|   Status:  new
  Milestone: |Component:  Core (Management
Version:  1.2|  commands)
 Resolution: | Severity:  Normal
   Triage Stage:  Design | Keywords:
  decision needed|Has patch:  0
Needs documentation:  0  |  Needs tests:  0
Patch needs improvement:  0  |
-+-
Changes (by jaddison):

 * type:   => Bug
 * severity:   => Normal


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15076: inspectdb to quote ForeignKey class names to avoid need to reorder classes/solve circular dependencies

[Django]

#15076: inspectdb to quote ForeignKey class names to avoid need to reorder
classes/solve circular dependencies
+---
  Reporter:  saschwarz  | Owner:  nobody
Status:  new| Milestone:
 Component:  django-admin.py inspectdb  |   Version:  1.2   
Resolution: |  Keywords:
 Stage:  Design decision needed | Has_patch:  0 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Comment (by j...@deserettechnology.com):

 Please see attached patch; it only quotes model names if the model has not
 yet been written out. Is that an acceptable deal? It should prevent
 quoting known model names but still quote model names that have not been
 initialized yet.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15076: inspectdb to quote ForeignKey class names to avoid need to reorder classes/solve circular dependencies

[Django]

#15076: inspectdb to quote ForeignKey class names to avoid need to reorder
classes/solve circular dependencies
+---
  Reporter:  saschwarz  | Owner:  nobody
Status:  new| Milestone:
 Component:  django-admin.py inspectdb  |   Version:  1.2   
Resolution: |  Keywords:
 Stage:  Design decision needed | Has_patch:  0 
Needs_docs:  0  |   Needs_tests:  0 
Needs_better_patch:  0  |  
+---
Changes (by ramiro):

  * owner:  => nobody
  * component:  ORM aggregation => django-admin.py inspectdb

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #15076: inspectdb to quote ForeignKey class names to avoid need to reorder classes/solve circular dependencies

[Django]

#15076: inspectdb to quote ForeignKey class names to avoid need to reorder
classes/solve circular dependencies
---+
 Reporter:  saschwarz  |   Owner:  nobody
   Status:  new|   Milestone:
Component:  Uncategorized  | Version:  1.2   
 Keywords: |   Stage:  Unreviewed
Has_patch:  0  |  
---+
 The inspectdb management command supplies either "self" or the unquoted
 name of foreign key's class as the first argument to the ForeignKey
 constructor. This requires that classes be defined prior to their first
 use. If the class name were supplied as a quoted string the ordering of
 classes isn't required. That would also solve the case where circular
 dependencies keep classes from being defined in an appropriate order.

 I've attached the trivial changes as a diff from trunk 15194.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.