Re: [Django] #15130: Model.validate_unique method is not considered with multi-db

[Django]

#15130: Model.validate_unique method is not considered with multi-db
--+-
  Reporter:  t2y  | Owner:  
Status:  new  | Milestone:  1.3 
 Component:  ORM aggregation  |   Version:  1.2 
Resolution:   |  Keywords:  multi-db
 Stage:  Accepted | Has_patch:  1   
Needs_docs:  0|   Needs_tests:  1   
Needs_better_patch:  0|  
--+-
Changes (by ramiro):

  * stage:  Unreviewed => Accepted

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15130: Model.validate_unique method is not considered with multi-db

[Django]

#15130: Model.validate_unique method is not considered with multi-db
--+-
  Reporter:  t2y  | Owner:  
Status:  new  | Milestone:  1.3 
 Component:  ORM aggregation  |   Version:  1.2 
Resolution:   |  Keywords:  multi-db
 Stage:  Unreviewed   | Has_patch:  1   
Needs_docs:  0|   Needs_tests:  1   
Needs_better_patch:  0|  
--+-
Comment (by adamnelson):

 @kmtracey ok, can you mark it as approved at least?  It seems a bit late
 to be committing a patch with no tests and no approval for an issue that
 currently affects milestone:1.2 but I'm happy to defer if somebody wants
 to move it forward.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15130: Model.validate_unique method is not considered with multi-db

[Django]

#15130: Model.validate_unique method is not considered with multi-db
--+-
  Reporter:  t2y  | Owner:  
Status:  new  | Milestone:  1.3 
 Component:  ORM aggregation  |   Version:  1.2 
Resolution:   |  Keywords:  multi-db
 Stage:  Unreviewed   | Has_patch:  1   
Needs_docs:  0|   Needs_tests:  1   
Needs_better_patch:  0|  
--+-
Changes (by kmtracey):

  * needs_tests:  0 => 1
  * milestone:  => 1.3

Comment:

 Replying to [comment:1 adamnelson]:
 > This looks like a problem on the current milestone:1.2 and therefore is
 too late for milestone:1.3

 ? We're not to the point of pushing bug-fixes out of 1.3 yet, I don't
 think. Features, yes, are no longer appropriate for the 1.3 milestone. But
 the description and the word "problem" there make this sound like a bug,
 not a feature. If it's been around since 1.2 it wouldn't be classified as
 a blocking bug, but it can still be in the milestone for 1.3. (Which does
 not guarantee it will get fixed for 1.3, but still it's not correct at
 this point to say a fix for this could not be put it for 1.3)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15130: Model.validate_unique method is not considered with multi-db

[Django]

#15130: Model.validate_unique method is not considered with multi-db
--+-
  Reporter:  t2y  | Owner:  
Status:  new  | Milestone:  
 Component:  ORM aggregation  |   Version:  1.2 
Resolution:   |  Keywords:  multi-db
 Stage:  Unreviewed   | Has_patch:  1   
Needs_docs:  0|   Needs_tests:  0   
Needs_better_patch:  0|  
--+-
Changes (by adamnelson):

  * needs_better_patch:  => 0
  * needs_docs:  => 0
  * needs_tests:  => 0
  * milestone:  1.3 =>

Comment:

 This looks like a problem on the current milestone:1.2 and therefore is
 too late for milestone:1.3

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #15130: Model.validate_unique method is not considered with multi-db

[Django]

#15130: Model.validate_unique method is not considered with multi-db
+---
 Reporter:  t2y |  Status:  new
Milestone:  1.3 |   Component:  ORM aggregation
  Version:  1.2 |Keywords:  multi-db   
Stage:  Unreviewed  |   Has_patch:  1  
+---
 Model.validate_unique() method has 2 methods, _perform_unique_checks() and
 _perform_date_checks(), which use _default_manager for queryset. But, they
 are not considered with multi-db, that queryset is as follows.

 {{{
 qs = model_class._default_manager.filter(**lookup_kwargs)
 }}}

 I encountered a problem when ModelForm.is_valid() method is called since
 BaseModelForm calls full_clean() -> post_clean() -> validate_unique(). I
 could add/change/delete data with multi-db in AdminSite by setting
 arbitrary database with "using" keyword. However, the validation
 uniqueness check is invalid if default database has the same data.

 # see also[[BR]]
 http://docs.djangoproject.com/en/dev/topics/forms/modelforms/#the-is-
 valid-method-and-errors [[BR]]
 http://docs.djangoproject.com/en/dev/ref/models/instances/#validating-
 objects

 I only tested default table operation in AdminSite applying attached
 patch.[[BR]]
 It works for me.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.