Re: [Django] #15653: minor errors in admin pagination custom tag

[Django]

#15653: minor errors in admin pagination custom tag
-+-
 Reporter:  jcumbo@… |Owner:  Tim
 Type:  Bug  |  Graham 
Component:  contrib.admin|   Status:  closed
 Severity:  Normal   |  Version:  1.1
 Keywords:  pagination   |   Resolution:  fixed
Has patch:  1| Triage Stage:  Accepted
  Needs tests:  1|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  1
-+-

Comment (by Simon Charette ):

 In [changeset:"dcd915fcab3841aa3b59122476c128ae3cb9e53c"]:
 {{{
 #!CommitTicketReference repository=""
 revision="dcd915fcab3841aa3b59122476c128ae3cb9e53c"
 Fixed a failure on Python 3 introduced by
 5939864616d56cf949f0bca348a8e05230b62fe0.

 Refs #15653.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/082.d6cd05de580c0e7bb608082e35839cf4%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #15653: minor errors in admin pagination custom tag

[Django]

#15653: minor errors in admin pagination custom tag
-+-
 Reporter:  jcumbo@… |Owner:  Tim
 Type:  Bug  |  Graham 
Component:  contrib.admin|   Status:  closed
 Severity:  Normal   |  Version:  1.1
 Keywords:  pagination   |   Resolution:  fixed
Has patch:  1| Triage Stage:  Accepted
  Needs tests:  1|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  1
-+-
Changes (by Tim Graham ):

 * owner:   => Tim Graham 
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"5939864616d56cf949f0bca348a8e05230b62fe0"]:
 {{{
 #!CommitTicketReference repository=""
 revision="5939864616d56cf949f0bca348a8e05230b62fe0"
 Fixed #15653 - Error in admin pagination tag.

 Thanks jcumbo@ for the report and adamzap
 and nott for the patch.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/082.a2f227dc24a53e2c8e041be8ef59f925%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #15653: minor errors in admin pagination custom tag

[Django]

#15653: minor errors in admin pagination custom tag
---+
 Reporter:  jcumbo@…   |Owner:
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  1.1
 Severity:  Normal |   Resolution:
 Keywords:  pagination | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+
Changes (by nott):

 * owner:  nott =>
 * status:  assigned => new


Comment:

 Pull request: https://github.com/django/django/pull/1168

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #15653: minor errors in admin pagination custom tag

[Django]

#15653: minor errors in admin pagination custom tag
---+
 Reporter:  jcumbo@…   |Owner:  nott
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  1.1
 Severity:  Normal |   Resolution:
 Keywords:  pagination | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  1
---+
Changes (by nott):

 * status:  new => assigned
 * owner:  nobody => nott


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #15653: minor errors in admin pagination custom tag

[Django]

#15653: minor errors in admin pagination custom tag
+--
   Reporter:  jcumbo@…  |Owner:  nobody
 Status:  new   |Milestone:
  Component:  django.contrib.admin  |  Version:  1.1
 Resolution:| Keywords:  pagination
   Triage Stage:  Accepted  |Has patch:  1
Needs documentation:  0 |  Needs tests:  1
Patch needs improvement:  0 |
+--
Changes (by julien):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15653: minor errors in admin pagination custom tag

[Django]

#15653: minor errors in admin pagination custom tag
+--
   Reporter:  jcumbo@…  |Owner:  nobody
 Status:  new   |Milestone:
  Component:  django.contrib.admin  |  Version:  1.1
 Resolution:| Keywords:  pagination
   Triage Stage:  Accepted  |Has patch:  0
Needs documentation:  0 |  Needs tests:  1
Patch needs improvement:  0 |
+--
Changes (by julien):

 * needs_better_patch:   => 0
 * needs_docs:   => 0
 * needs_tests:   => 1
 * stage:  Unreviewed => Accepted


Comment:

 Tests need to be written to prove that the end result remains unchanged
 after this fix :-)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #15653: minor errors in admin pagination custom tag

[Django]

#15653: minor errors in admin pagination custom tag
--+---
 Reporter:  jcumbo@…  | Owner:  nobody
   Status:  new   | Milestone:
Component:  django.contrib.admin  |   Version:  1.1
 Keywords:  pagination|  Triage Stage:  Unreviewed
Has patch:  0 |
--+---
 in django.contrib.admin.templates.admin.templatetags.admin_list.py line
 48, which currently reads
 {{{
 "page_range.extend(range(0, ON_EACH_SIDE - 1))"
 }}}
  should read[[BR]]

 {{{
 "page_range.extend(range(0, ON_ENDS))"
 }}}
  instead. [[BR]]
 Problem is noticeable if you change ON_EACH_SIDE to a value to 2.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.