Re: [Django] #15705: Localflavor for Croatia

[Django]

#15705: Localflavor for Croatia
-+-
   Reporter:  zmasek |Owner:  zmasek
   Type:  New|   Status:  new
  feature|Component:  contrib.localflavor
  Milestone: | Severity:  Normal
Version:  SVN| Keywords:  localflavor croatia
 Resolution: |Has patch:  1
   Triage Stage:  Ready for  |  Needs tests:  0
  checkin|
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-

Comment (by zmasek):

 I'm glad I could contribute! Thanks for the tips and all the help, julien.
 :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15705: Localflavor for Croatia

[Django]

#15705: Localflavor for Croatia
-+-
   Reporter:  zmasek |Owner:  zmasek
   Type:  New|   Status:  new
  feature|Component:  contrib.localflavor
  Milestone: | Severity:  Normal
Version:  SVN| Keywords:  localflavor croatia
 Resolution: |Has patch:  1
   Triage Stage:  Ready for  |  Needs tests:  0
  checkin|
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-
Changes (by julien):

 * needs_docs:  1 => 0
 * needs_tests:  1 => 0
 * stage:  Accepted => Ready for checkin


Comment:

 You forgot to add the reference to your test case in
 `tests/regressiontests/forms/tests/__init__.py` so it wasn't run. I've
 fixed this small thing in the attached patch. Other than that everything
 looks great. Thanks for your work.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15705: Localflavor for Croatia

[Django]

#15705: Localflavor for Croatia
---+---
   Reporter:  zmasek   |Owner:  zmasek
   Type:  New feature  |   Status:  new
  Milestone:   |Component:  contrib.localflavor
Version:  SVN  | Severity:  Normal
 Resolution:   | Keywords:  localflavor croatia
   Triage Stage:  Accepted |Has patch:  1
Needs documentation:  1|  Needs tests:  1
Patch needs improvement:  0|
---+---

Comment (by zmasek):

 Added documentation and tests in a replaced attachment. If somebody could
 verify everything's ok? Julien?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15705: Localflavor for Croatia

[Django]

#15705: Localflavor for Croatia
---+---
   Reporter:  zmasek   |Owner:  zmasek
   Type:  New feature  |   Status:  new
  Milestone:   |Component:  contrib.localflavor
Version:  SVN  | Severity:  Normal
 Resolution:   | Keywords:  localflavor croatia
   Triage Stage:  Accepted |Has patch:  1
Needs documentation:  1|  Needs tests:  1
Patch needs improvement:  0|
---+---
Changes (by julien):

 * needs_docs:  0 => 1
 * needs_tests:  0 => 1


Comment:

 Just noting that the patch would need to include documentation too.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15705: Localflavor for Croatia

[Django]

#15705: Localflavor for Croatia
---+---
   Reporter:  zmasek   |Owner:  zmasek
   Type:  New feature  |   Status:  new
  Milestone:   |Component:  contrib.localflavor
Version:  SVN  | Severity:  Normal
 Resolution:   | Keywords:  localflavor croatia
   Triage Stage:  Accepted |Has patch:  1
Needs documentation:  0|  Needs tests:  0
Patch needs improvement:  0|
---+---

Comment (by julien):

 You might also consider putting your tests in
 source:django/trunk/tests/regressiontests/forms/localflavor
 Where ever it seems most logical to you.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15705: Localflavor for Croatia

[Django]

#15705: Localflavor for Croatia
---+---
   Reporter:  zmasek   |Owner:  zmasek
   Type:  New feature  |   Status:  new
  Milestone:   |Component:  contrib.localflavor
Version:  SVN  | Severity:  Normal
 Resolution:   | Keywords:  localflavor croatia
   Triage Stage:  Accepted |Has patch:  1
Needs documentation:  0|  Needs tests:  0
Patch needs improvement:  0|
---+---

Comment (by zmasek):

 I'll probably decide against the custom license plate field for now since
 the law is very messy and vague regarding them, but I'll try to add tests
 before the end of the week.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15705: Localflavor for Croatia

[Django]

#15705: Localflavor for Croatia
---+---
   Reporter:  zmasek   |Owner:  zmasek
   Type:  New feature  |   Status:  new
  Milestone:   |Component:  contrib.localflavor
Version:  SVN  | Severity:  Normal
 Resolution:   | Keywords:  localflavor croatia
   Triage Stage:  Accepted |Has patch:  1
Needs documentation:  0|  Needs tests:  0
Patch needs improvement:  0|
---+---

Comment (by julien):

 It would be great if you could also add tests for your patch in
 source:django/trunk/tests/regressiontests/localflavor

 There currently aren't many tests for localflavors and it'd be good to set
 a good example. Plus that will be good training for your testing skills ;)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15705: Localflavor for Croatia

[Django]

#15705: Localflavor for Croatia
---+---
   Reporter:  zmasek   |Owner:  zmasek
   Type:  New feature  |   Status:  new
  Milestone:   |Component:  contrib.localflavor
Version:  SVN  | Severity:  Normal
 Resolution:   | Keywords:  localflavor croatia
   Triage Stage:  Accepted |Has patch:  1
Needs documentation:  0|  Needs tests:  0
Patch needs improvement:  0|
---+---
Changes (by julien):

 * stage:  Ready for checkin => Accepted


Comment:

 Replying to [comment:4 zmasek]:
 > I'm considering adding another field for custom license plates. If I
 find it useful to have (as opposed to having an ordinary non-validated
 text input), should I make another ticket or add to this one?

 You can add it to this one. I'm just moving back to accepted so someone
 gets a change to review your new patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15705: Localflavor for Croatia

[Django]

#15705: Localflavor for Croatia
-+-
   Reporter:  zmasek |Owner:  zmasek
   Type:  New|   Status:  new
  feature|Component:  contrib.localflavor
  Milestone: | Severity:  Normal
Version:  SVN| Keywords:  localflavor croatia
 Resolution: |Has patch:  1
   Triage Stage:  Ready for  |  Needs tests:  0
  checkin|
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-

Comment (by zmasek):

 Replying to [comment:3 julien]:
 > Thank you for your contribution!
 I'm considering adding another field for custom license plates. If I find
 it useful to have (as opposed to having an ordinary non-validated text
 input), should I make another ticket or add to this one?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15705: Localflavor for Croatia

[Django]

#15705: Localflavor for Croatia
-+-
   Reporter:  zmasek |Owner:  zmasek
   Type:  New|   Status:  new
  feature|Component:  contrib.localflavor
  Milestone: | Severity:  Normal
Version:  SVN| Keywords:  localflavor croatia
 Resolution: |Has patch:  1
   Triage Stage:  Ready for  |  Needs tests:  0
  checkin|
Needs documentation:  0  |
Patch needs improvement:  0  |
-+-
Changes (by julien):

 * needs_docs:   => 0
 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * stage:  Unreviewed => Ready for checkin


Comment:

 Thank you for your contribution!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #15705: Localflavor for Croatia

[Django]

#15705: Localflavor for Croatia
+---
 Reporter:  zmasek  | Owner:  zmasek
   Status:  new | Milestone:
Component:  django.contrib.localflavor  |   Version:  SVN
 Keywords:  localflavor croatia |  Triage Stage:  Unreviewed
Has patch:  1   |
+---
 This patch adds several form fields specific to Croatia.

 HRPostalNumber
 HRCountySelect
 HROIBField
 HRJMBGField
 HRPhoneNumberField
 HRPhoneNumberPrefixSelect
 HRLicencePlatePrefixSelect
 HRLicencePlateField
 HRJMBAGField

 (My first patch/contribution. Hope I got it right.)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.