Re: [Django] #15764: DeleteView does not have ModelFormMixin in its mixins

[Django]

#15764: DeleteView does not have ModelFormMixin in its mixins
-+-
   Reporter:  linovia|  Owner:  nobody
   Type:  Bug| Status:  closed
  Milestone: |  Component:  Documentation
Version:  1.3|   Severity:  Normal
 Resolution:  fixed  |   Keywords:
   Triage Stage:  Ready for  |  Has patch:  1
  checkin|Needs tests:  1
Needs documentation:  0  |  Easy pickings:  1
Patch needs improvement:  0  |
  UI/UX:  0  |
-+-

Comment (by timo):

 In [16381]:
 {{{
 #!CommitTicketReference repository="" revision="16381"
 Fixed #15764 - Corrected mixin docs for DeleteView?; thanks linovia for
 the report.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15764: DeleteView does not have ModelFormMixin in its mixins

[Django]

#15764: DeleteView does not have ModelFormMixin in its mixins
-+-
   Reporter:  linovia|  Owner:  nobody
   Type:  Bug| Status:  closed
  Milestone: |  Component:  Documentation
Version:  1.3|   Severity:  Normal
 Resolution:  fixed  |   Keywords:
   Triage Stage:  Ready for  |  Has patch:  1
  checkin|Needs tests:  1
Needs documentation:  0  |  Easy pickings:  1
Patch needs improvement:  0  |
  UI/UX:  0  |
-+-
Changes (by timo):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [16380]:
 {{{
 #!CommitTicketReference repository="" revision="16380"
 Fixed #15764 - Corrected mixin docs for DeleteView; thanks linovia for the
 report.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15764: DeleteView does not have ModelFormMixin in its mixins

[Django]

#15764: DeleteView does not have ModelFormMixin in its mixins
-+-
   Reporter:  linovia|  Owner:  nobody
   Type:  Bug| Status:  new
  Milestone: |  Component:  Documentation
Version:  1.3|   Severity:  Normal
 Resolution: |   Keywords:
   Triage Stage:  Ready for  |  Has patch:  1
  checkin|Needs tests:  1
Needs documentation:  0  |  Easy pickings:  1
Patch needs improvement:  0  |
  UI/UX:  0  |
-+-
Changes (by oinopion):

 * ui_ux:   => 0
 * stage:  Accepted => Ready for checkin


Comment:

 Patch looks OK.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15764: DeleteView does not have ModelFormMixin in its mixins

[Django]

#15764: DeleteView does not have ModelFormMixin in its mixins
+---
   Reporter:  linovia   |  Owner:  nobody
   Type:  Bug   | Status:  new
  Milestone:|  Component:  Documentation
Version:  1.3   |   Severity:  Normal
 Resolution:|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  1
Needs documentation:  0 |Needs tests:  1
Patch needs improvement:  0 |  Easy pickings:  1
+---

Comment (by andrewebdev):

 Actually d0ugal rightly pointed out that this a Documentation issue. It
 doesn't make sense to pass the form to a delete view.
 I also noticed that the documentation mentions {{{
 django.views.generic.edit.ProcessFormView }}} as another mixin, which also
 doesn't exist on the view.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15764: DeleteView does not have ModelFormMixin in its mixins

[Django]

#15764: DeleteView does not have ModelFormMixin in its mixins
+---
   Reporter:  linovia   |  Owner:  nobody
   Type:  Bug   | Status:  new
  Milestone:|  Component:  Documentation
Version:  1.3   |   Severity:  Normal
 Resolution:|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  1
Needs documentation:  0 |Needs tests:  1
Patch needs improvement:  0 |  Easy pickings:  1
+---
Changes (by d0ugal):

 * cc: dougal85@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15764: DeleteView does not have ModelFormMixin in its mixins

[Django]

#15764: DeleteView does not have ModelFormMixin in its mixins
+---
   Reporter:  linovia   |  Owner:  nobody
   Type:  Bug   | Status:  new
  Milestone:|  Component:  Documentation
Version:  1.3   |   Severity:  Normal
 Resolution:|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  1
Needs documentation:  0 |Needs tests:  1
Patch needs improvement:  0 |  Easy pickings:  1
+---
Changes (by andrewebdev):

 * has_patch:  0 => 1
 * needs_tests:  0 => 1


Comment:

 Patch uploaded. Not sure if this needs testing or how it would be tested.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15764: DeleteView does not have ModelFormMixin in its mixins

[Django]

#15764: DeleteView does not have ModelFormMixin in its mixins
+---
   Reporter:  linovia   |  Owner:  nobody
   Type:  Bug   | Status:  new
  Milestone:|  Component:  Documentation
Version:  1.3   |   Severity:  Normal
 Resolution:|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  1
+---
Changes (by lukeplant):

 * easy:   => 1
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15764: DeleteView does not have ModelFormMixin in its mixins

[Django]

#15764: DeleteView does not have ModelFormMixin in its mixins
--+-
   Reporter:  linovia |Owner:  nobody
   Type:  Bug |   Status:  new
  Milestone:  |Component:  Documentation
Version:  1.3 | Severity:  Normal
 Resolution:  | Keywords:
   Triage Stage:  Unreviewed  |Has patch:  0
Needs documentation:  0   |  Needs tests:  0
Patch needs improvement:  0   |
--+-
Changes (by linovia):

 * needs_docs:   => 0
 * component:  Generic views => Documentation
 * needs_tests:   => 0
 * needs_better_patch:   => 0


Comment:

 Changing the component after a couple of tests to documentation.
 One doesn't need to get a form for that. We only need a POST to the right
 url. There's no reason to have a form for that. Maybe the term form
 creates a confusion between Django forms and HTML forms.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #15764: DeleteView does not have ModelFormMixin in its mixins

[Django]

#15764: DeleteView does not have ModelFormMixin in its mixins
-+--
 Reporter:  linovia  | Owner:  nobody
 Type:  Bug  |Status:  new
Milestone:   | Component:  Generic views
  Version:  1.3  |  Severity:  Normal
 Keywords:   |  Triage Stage:  Unreviewed
Has patch:  0|
-+--
 Documentation for DeleteView mentions that it inherits from ModelFormMixin

 However, reading the code, we have:
 * DeleteView
   * SingleObjectTemplateResponseMixin
 * TemplateResponseMixin
   * BaseDeleteView
 * DeletionMixin
 * BaseDetailView
   * SingleObjectMixin
   * View

 The point being that DeleteView doesn't pass any form as the documentation
 mentions.
 http://docs.djangoproject.com/en/1.3/ref/class-based-views/#deleteview

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.