Re: [Django] #15782: Runserver/runfcgi/startup with MySQL is unlike any other database

[Django]

#15782: Runserver/runfcgi/startup with MySQL is unlike any other database
-+-
 Reporter:  toofishes|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.3
  (models, ORM)  |   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by claudep):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [17868]:
 {{{
 #!CommitTicketReference repository="" revision="17868"
 Fixed #15782 -- Prevented MySQL backend to crash on runserver when db
 server is down. Thanks toofishes for the report and patch.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15782: Runserver/runfcgi/startup with MySQL is unlike any other database

[Django]

#15782: Runserver/runfcgi/startup with MySQL is unlike any other database
-+-
 Reporter:  toofishes|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.3
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by toofishes):

 Ugh, sorry about that last one- I forget to update the error message
 forming logic. The next version will have that fixed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15782: Runserver/runfcgi/startup with MySQL is unlike any other database

[Django]

#15782: Runserver/runfcgi/startup with MySQL is unlike any other database
-+-
   Reporter:  toofishes  |  Owner:  nobody
   Type:  Bug| Status:  new
  Milestone: |  Component:  Database layer
Version:  1.3|  (models, ORM)
 Resolution: |   Severity:  Normal
   Triage Stage:  Ready for  |   Keywords:
  checkin|  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-

Comment (by toofishes):

 It works with 5.5.15 locally, if that is recent enough.

 I believe I did the odd (None * 3) triplet because of the error message
 formation, which can contain a database version, and I didn't feel like
 reworking that bit or something, as it was already quite messy. I'm fine
 with whatever you decide as long as it works!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15782: Runserver/runfcgi/startup with MySQL is unlike any other database

[Django]

#15782: Runserver/runfcgi/startup with MySQL is unlike any other database
-+-
   Reporter:  toofishes  |  Owner:  nobody
   Type:  Bug| Status:  new
  Milestone: |  Component:  Database layer
Version:  1.3|  (models, ORM)
 Resolution: |   Severity:  Normal
   Triage Stage:  Ready for  |   Keywords:
  checkin|  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
Changes (by mtredinnick):

 * stage:  Accepted => Ready for checkin


Comment:

 This patch looks pretty much correct, although as stylistic point, I'd use
 ``db_version = None`` in the case where we can't determine it.

 I apparently need to un-hose the MySQL install on my laptop, so I can't
 test this right now (I'd like to at least confirm it doesn't break
 existing recent MySQL versions) but it's effectively ready to commit.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15782: Runserver/runfcgi/startup with MySQL is unlike any other database

[Django]

#15782: Runserver/runfcgi/startup with MySQL is unlike any other database
-+-
   Reporter:  toofishes  |  Owner:  nobody
   Type:  Bug| Status:  new
  Milestone: |  Component:  Database layer
Version:  1.3|  (models, ORM)
 Resolution: |   Severity:  Normal
   Triage Stage:  Accepted   |   Keywords:
Needs documentation:  0  |  Has patch:  1
Patch needs improvement:  0  |Needs tests:  0
  UI/UX:  0  |  Easy pickings:  0
-+-
Changes (by GDorn):

 * cc: georgedorn@… (added)
 * ui_ux:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15782: Runserver/runfcgi/startup with MySQL is unlike any other database

[Django]

#15782: Runserver/runfcgi/startup with MySQL is unlike any other database
-+-
   Reporter:  toofishes  |  Owner:  nobody
   Type:  Bug| Status:  new
  Milestone: |  Component:  Database layer
Version:  1.3|  (models, ORM)
 Resolution: |   Severity:  Normal
   Triage Stage:  Accepted   |   Keywords:
Needs documentation:  0  |  Has patch:  1
Patch needs improvement:  0  |Needs tests:  0
 |  Easy pickings:  0
-+-
Changes (by toofishes):

 * has_patch:  0 => 1


Comment:

 Since it wasn't clear whether you thought option 1, 2, 3, or none of the
 above was the best way to resolve this, I'll propose this patch which
 basically implements suggestion #2. If we can get a connection, we will
 continue to check the < 5.0.3 bits; else we will just skip it, do what we
 can without a connection, and make sure we start up. The first page you
 hit will then show a 500 error saying the DB connection could not be
 established, but one will not have to restart Django once the DB comes up.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15782: Runserver/runfcgi/startup with MySQL is unlike any other database

[Django]

#15782: Runserver/runfcgi/startup with MySQL is unlike any other database
-+-
   Reporter:  toofishes  |  Owner:  nobody
   Type:  Bug| Status:  new
  Milestone: |  Component:  Database layer
Version:  1.3|  (models, ORM)
 Resolution: |   Severity:  Normal
   Triage Stage:  Accepted   |   Keywords:
Needs documentation:  0  |  Has patch:  0
Patch needs improvement:  0  |Needs tests:  0
 |  Easy pickings:  0
-+-
Changes (by jacob):

 * stage:  Design decision needed => Accepted


Comment:

 Yeah, this shouldn't blow up. It should either display a nice error, or
 fail consistently (i.e. in the same way that other databases fail).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15782: Runserver/runfcgi/startup with MySQL is unlike any other database

[Django]

#15782: Runserver/runfcgi/startup with MySQL is unlike any other database
-+-
   Reporter:  toofishes  |  Owner:  nobody
   Type:  Bug| Status:  new
  Milestone: |  Component:  Database layer
Version:  1.3|  (models, ORM)
 Resolution: |   Severity:  Normal
   Triage Stage:  Design |   Keywords:
  decision needed|  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
-+-
Changes (by aaugustin):

 * needs_better_patch:   => 0
 * stage:  Unreviewed => Design decision needed
 * needs_tests:   => 0
 * easy:   => 0
 * needs_docs:   => 0


Comment:

 See #9431 which has a lengthy discussion of why and how the checks are
 performed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #15782: Runserver/runfcgi/startup with MySQL is unlike any other database

[Django]

#15782: Runserver/runfcgi/startup with MySQL is unlike any other database
---+-
 Reporter:  toofishes  | Owner:  nobody
 Type:  Bug|Status:  new
Milestone: | Component:  Database layer (models, ORM)
  Version:  1.3|  Severity:  Normal
 Keywords: |  Triage Stage:  Unreviewed
Has patch:  0  |
---+-
 Django provides a BaseDatabaseValidation class. The only database engine
 to subclass this is MySQL.

 To reproduce:

 {{{
 $ django-admin.py foobar
 $ cd foobar
 
 $ python2 manage.py runserver
 Validating models...

 Unhandled exception in thread started by >
 Traceback (most recent call last):
   File "/usr/lib/python2.7/site-
 packages/django/core/management/commands/runserver.py", line 88, in
 inner_run
 self.validate(display_num_errors=True)
   File "/usr/lib/python2.7/site-packages/django/core/management/base.py",
 line 249, in validate
 num_errors = get_validation_errors(s, app)
   File "/usr/lib/python2.7/site-
 packages/django/core/management/validation.py", line 103, in
 get_validation_errors
 connection.validation.validate_field(e, opts, f)
   File "/usr/lib/python2.7/site-
 packages/django/db/backends/mysql/validation.py", line 14, in
 validate_field
 db_version = self.connection.get_server_version()
   File "/usr/lib/python2.7/site-
 packages/django/db/backends/mysql/base.py", line 338, in
 get_server_version
 self.cursor()
   File "/usr/lib/python2.7/site-packages/django/db/backends/__init__.py",
 line 250, in cursor
 cursor = self.make_debug_cursor(self._cursor())
   File "/usr/lib/python2.7/site-
 packages/django/db/backends/mysql/base.py", line 322, in _cursor
 self.connection = Database.connect(**kwargs)
   File "/usr/lib/python2.7/site-packages/MySQLdb/__init__.py", line 81, in
 Connect
 return Connection(*args, **kwargs)
   File "/usr/lib/python2.7/site-packages/MySQLdb/connections.py", line
 187, in __init__
 super(Connection, self).__init__(*args, **kwargs2)
 _mysql_exceptions.OperationalError: (2002, "Can't connect to local MySQL
 server through socket '/var/run/mysqld/mysqld.sock' (2)")
 }}}


 Expected result:

 {{{
 $ django-admin.py foobar
 $ cd foobar
 
 $ python2 manage.py runserver
 Validating models...

 0 errors found
 Django version 1.3, using settings 'foobar.settings'
 Development server is running at http://127.0.0.1:8000/
 Quit the server with CONTROL-C.
 }}}

 Why this is a problem:
 1. The number one reason this is bad- no other database engine completely
 halts the Django project load if it is not up. It simply cannot service
 requests at all. All other database engines at least show a helpful 500
 page on each failed request.
 2. Validation like this doesn't come early enough for someone that
 develops on one database engine and then switches to MySQL.
 3. The validation that needs a valid connection is testing an extreme edge
 case- those using versions before 5.0.3. From http://www.mysql.com/support
 /eol-notice.html, Extended Support for 4.1 and Active Support for 5.0
 ended ended 2009-12-31.
 4. We are likely missing validation cases for other databases; we should
 be consistent in trying to do it right or not do it at all.
 5. The validation here isn't even correct for unique fields. max_length
 can be greater than 255, in reality the unique indexes are constrained to
 1000 bytes. For that matter, this also does nothing to keep one from
 shooting themselves in the foot with a combo unique index produced by
 unique_together.

 Potential fixes:
 1. Drop this database field validation completely, as only one database is
 even providing it and not even fully checking.
 2. Remove the bits referencing the connection; this will solve the most
 severe problem and those using old database versions should be well aware
 of the restrictions.
 3. Make the validation module do the right thing more often, fixing MySQL
 and adding it for other databases.

 I'd be happy to provide a patch for #1 or #2, but wanted some feedback
 first.

 Tangentially related to #7040.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.