Re: [Django] #15805: assertFieldOutput should not use assertRaisesRegexp

[Django]

#15805: assertFieldOutput should not use assertRaisesRegexp
-+-
   Reporter:  julien |  Owner:  nobody
   Type:  Bug| Status:  closed
  Milestone: |  Component:  Testing framework
Version:  SVN|   Severity:  Release blocker
 Resolution:  fixed  |   Keywords:
   Triage Stage:  Ready for  |  Has patch:  1
  checkin|Needs tests:  0
Needs documentation:  0  |  Easy pickings:  0
Patch needs improvement:  0  |
-+-
Changes (by lukeplant):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [16303]:
 {{{
 #!CommitTicketReference repository="" revision="16303"
 Fixed #15805 - assertFieldOutput should not use assertRaisesRegexp

 Thanks to julien for the report and patch.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15805: assertFieldOutput should not use assertRaisesRegexp

[Django]

#15805: assertFieldOutput should not use assertRaisesRegexp
-+-
   Reporter:  julien |  Owner:  nobody
   Type:  Bug| Status:  new
  Milestone: |  Component:  Testing framework
Version:  SVN|   Severity:  Release blocker
 Resolution: |   Keywords:
   Triage Stage:  Ready for  |  Has patch:  1
  checkin|Needs tests:  0
Needs documentation:  0  |  Easy pickings:  0
Patch needs improvement:  0  |
-+-
Changes (by claudep):

 * version:  1.2 => SVN
 * stage:  Accepted => Ready for checkin


Comment:

 In the future, it would also be cool if the failing message would expose
 the exact value which is failing, instead of simply outputting the raw
 ValidationError. But this is already a nice improvement.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15805: assertFieldOutput should not use assertRaisesRegexp

[Django]

#15805: assertFieldOutput should not use assertRaisesRegexp
+---
   Reporter:  julien|  Owner:  nobody
   Type:  Bug   | Status:  new
  Milestone:|  Component:  Testing framework
Version:  1.2   |   Severity:  Release blocker
 Resolution:|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  1
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
+---

Comment (by julien):

 For the record, I've created #15838 to suggest moving `assertFieldOutput`
 to the general `TestCase`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15805: assertFieldOutput should not use assertRaisesRegexp

[Django]

#15805: assertFieldOutput should not use assertRaisesRegexp
+---
   Reporter:  julien|  Owner:  nobody
   Type:  Bug   | Status:  new
  Milestone:|  Component:  Testing framework
Version:  1.2   |   Severity:  Release blocker
 Resolution:|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  1
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
+---
Changes (by lrekucki):

 * easy:   => 0
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15805: assertFieldOutput should not use assertRaisesRegexp

[Django]

#15805: assertFieldOutput should not use assertRaisesRegexp
--+-
   Reporter:  julien  |Owner:  nobody
   Type:  Bug |   Status:  new
  Milestone:  |Component:  Testing framework
Version:  1.2 | Severity:  Release blocker
 Resolution:  | Keywords:
   Triage Stage:  Unreviewed  |Has patch:  1
Needs documentation:  0   |  Needs tests:  0
Patch needs improvement:  0   |
--+-
Changes (by lawgon):

 * cc: lawgon@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15805: assertFieldOutput should not use assertRaisesRegexp

[Django]

#15805: assertFieldOutput should not use assertRaisesRegexp
--+-
   Reporter:  julien  |Owner:  nobody
   Type:  Bug |   Status:  new
  Milestone:  |Component:  Testing framework
Version:  1.2 | Severity:  Release blocker
 Resolution:  | Keywords:
   Triage Stage:  Unreviewed  |Has patch:  1
Needs documentation:  0   |  Needs tests:  0
Patch needs improvement:  0   |
--+-
Changes (by julien):

 * needs_tests:  1 => 0


Comment:

 I've added the regression tests. I think the `assertFieldOutput` is
 actually quite useful. Also it's quite generic and not really local flavor
 specific. So I'd suggest we eventually move it to the
 `django.utils.unittest.TestCase` class and document it so that the world
 knows about it. I'll create a new ticket for that if/when this patch gets
 checked in.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15805: assertFieldOutput should not use assertRaisesRegexp

[Django]

#15805: assertFieldOutput should not use assertRaisesRegexp
--+-
   Reporter:  julien  |Owner:  nobody
   Type:  Bug |   Status:  new
  Milestone:  |Component:  Testing framework
Version:  1.2 | Severity:  Release blocker
 Resolution:  | Keywords:
   Triage Stage:  Unreviewed  |Has patch:  1
Needs documentation:  0   |  Needs tests:  1
Patch needs improvement:  0   |
--+-
Changes (by julien):

 * needs_tests:  0 => 1


Comment:

 This actually needs some regression tests for `assertFieldOutput` itself.
 I'm working on it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #15805: assertFieldOutput should not use assertRaisesRegexp

[Django]

#15805: assertFieldOutput should not use assertRaisesRegexp
--+-
   Reporter:  julien  |Owner:  nobody
   Type:  Bug |   Status:  new
  Milestone:  |Component:  Testing framework
Version:  1.2 | Severity:  Release blocker
   Keywords:  | Triage Stage:  Unreviewed
  Has patch:  1   |  Needs documentation:  0
Needs tests:  0   |  Patch needs improvement:  0
--+-
 The fact that `assertFieldOutput` uses `assertRaisesRegexp` causes some
 weird and inconsistent behaviours, which I describe in more detail in
 #14608 and in http://groups.google.com/group/django-
 developers/browse_thread/thread/96da81267aadade0

 Not only does it make no sense to use regular expressions here, but also
 pretty much all the tests in `regressiontests.forms.localflavor` using
 `assertFieldOutput` are currently passing without being absolutely sure
 that the expected error messages are correct (To verify that, try
 modifying any error message in those tests -- the tests will still pass).

 See attached patch fixing the behaviour and also straightening some tests
 that were incorrectly passing before.

 Marking as Release Blocker since, in effect, the test suite is currently
 broken because of this behaviour.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.