Re: [Django] #15806: Error in filebased cache culling

[Django]

#15806: Error in filebased cache culling
-+-
 Reporter:  witek@…  |Owner:  Anssi
 Type:  Bug  |  Kääriäinen 
Component:  Core (Cache system)  |   Status:  closed
 Severity:  Normal   |  Version:  master
 Keywords:   |   Resolution:  fixed
Has patch:  0| Triage Stage:  Accepted
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by Anssi Kääriäinen ):

 * owner:   => Anssi Kääriäinen 
 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"7be638390e18fcbfaaed638f9908673360c280d3"]:
 {{{
 #!CommitTicketReference repository=""
 revision="7be638390e18fcbfaaed638f9908673360c280d3"
 Fixed #20536 -- rewrite of the file based cache backend

  * Safer for use in multiprocess environments
  * Better random culling
  * Cache files use less disk space
  * Safer delete behavior

 Also fixed #15806, fixed #15825.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/077.bade00f2f3f78922688e2768cf6461cd%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #15806: Error in filebased cache culling

[Django]

#15806: Error in filebased cache culling
-+
 Reporter:  witek@…  |Owner:
 Type:  Bug  |   Status:  new
Component:  Core (Cache system)  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by marfire):

 * has_patch:  1 => 0
 * version:  1.3 => master


Comment:

 This is fixed by the solution to #20536.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/077.eb037f1919a7a9a55777b6e48ead7ccc%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #15806: Error in filebased cache culling

[Django]

#15806: Error in filebased cache culling
-+
 Reporter:  witek@…  |Owner:
 Type:  Bug  |   Status:  new
Component:  Core (Cache system)  |  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by desh):

 * owner:  desh =>
 * status:  assigned => new


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15806: Error in filebased cache culling

[Django]

#15806: Error in filebased cache culling
+-
   Reporter:  witek@…   |  Owner:  desh
   Type:  Bug   | Status:  assigned
  Milestone:|  Component:  Core (Cache system)
Version:  1.3   |   Severity:  Normal
 Resolution:|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  1
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+-
Changes (by desh):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15806: Error in filebased cache culling

[Django]

#15806: Error in filebased cache culling
+-
   Reporter:  witek@…   |  Owner:  desh
   Type:  Bug   | Status:  assigned
  Milestone:|  Component:  Core (Cache system)
Version:  1.3   |   Severity:  Normal
 Resolution:|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  1
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  1 |  Easy pickings:  0
  UI/UX:  0 |
+-

Comment (by desh):

 Replying to [comment:4 aaugustin]:
 > Could you consolidate the tests and the fix in the same patch?

 Yep, sorry for that, just done tests before actually fixing so they came
 up first.

 You can actually pick the merged_patch.diff from #15825, it contains all
 in one, tests and code for #15806 and #15825.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15806: Error in filebased cache culling

[Django]

#15806: Error in filebased cache culling
+-
   Reporter:  witek@…   |  Owner:  desh
   Type:  Bug   | Status:  assigned
  Milestone:|  Component:  Core (Cache system)
Version:  1.3   |   Severity:  Normal
 Resolution:|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  1
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  1 |  Easy pickings:  0
  UI/UX:  0 |
+-
Changes (by aaugustin):

 * needs_better_patch:  0 => 1


Comment:

 Could you consolidate the tests and the fix in the same patch?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15806: Error in filebased cache culling

[Django]

#15806: Error in filebased cache culling
+-
   Reporter:  witek@…   |  Owner:  desh
   Type:  Bug   | Status:  assigned
  Milestone:|  Component:  Core (Cache system)
Version:  1.3   |   Severity:  Normal
 Resolution:|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  1
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+-
Changes (by desh):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15806: Error in filebased cache culling

[Django]

#15806: Error in filebased cache culling
+-
   Reporter:  witek@…   |  Owner:  desh
   Type:  Bug   | Status:  assigned
  Milestone:|  Component:  Core (Cache system)
Version:  1.3   |   Severity:  Normal
 Resolution:|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+-
Changes (by desh):

 * owner:  nobody => desh
 * status:  new => assigned
 * ui_ux:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15806: Error in filebased cache culling

[Django]

#15806: Error in filebased cache culling
+-
   Reporter:  witek@…   |  Owner:  nobody
   Type:  Bug   | Status:  new
  Milestone:|  Component:  Core (Cache system)
Version:  1.3   |   Severity:  Normal
 Resolution:|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
+-
Changes (by jacob):

 * needs_better_patch:   => 0
 * needs_docs:   => 0
 * easy:   => 0
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 See also #15825. Not exactly related, but right around in that same part
 of code and probably worth fixing at the same time.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #15806: Error in filebased cache culling

[Django]

#15806: Error in filebased cache culling
-+
 Reporter:  witek@…  | Owner:  nobody
 Type:  Bug  |Status:  new
Milestone:   | Component:  Core (Cache system)
  Version:  1.3  |  Severity:  Normal
 Keywords:   |  Triage Stage:  Unreviewed
Has patch:  0|
-+
 In line 115 of filebased.py we have:

 {{{
 try:
 filelist = sorted(os.listdir(self._dir))
 except (IOError, OSError):
 return

 if self._cull_frequency == 0:
 doomed = filelist
 else:
 doomed = [os.path.join(self._dir, k) for (i, k) in enumerate(filelist)
 if i % self._cull_frequency == 0]

 }}}

 In case of _cull_frequency == 0 instead of "doomed = filelist" we should
 have sth like:

 {{{
 doomed = [os.path.join(self._dir, d) for d in filelist]
 }}}

 Otherwise doomed tuple will not contains absolute paths but relative.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.