Re: [Django] #15840: [patch] wrap the inner function of the condition decorator

[Django]

#15840: [patch] wrap the inner function of the condition decorator
-+-
 Reporter:  portante |Owner:  zsiciarz
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:
Component:  Core (Other) |   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-
Changes (by jezdez):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [17470]:
 {{{
 #!CommitTicketReference repository="" revision="17470"
 Fixed #15840 -- Wrapped inner function of the condition decorator with
 functools.wraps to follow best practices. Thanks, zsiciarz.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15840: [patch] wrap the inner function of the condition decorator

[Django]

#15840: [patch] wrap the inner function of the condition decorator
-+-
 Reporter:  portante |Owner:  zsiciarz
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:
Component:  Core (Other) |   Resolution:
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:   |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-
Changes (by lrekucki):

 * stage:  Accepted => Ready for checkin


Comment:

 Verified.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15840: [patch] wrap the inner function of the condition decorator

[Django]

#15840: [patch] wrap the inner function of the condition decorator
--+
 Reporter:  portante  |Owner:  zsiciarz
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (Other)  |  Version:
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  1 |UI/UX:  0
--+
Changes (by zsiciarz):

 * owner:  nobody => zsiciarz


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15840: [patch] wrap the inner function of the condition decorator

[Django]

#15840: [patch] wrap the inner function of the condition decorator
--+
 Reporter:  portante  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Core (Other)  |  Version:
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  1 |UI/UX:  0
--+
Changes (by ojii):

 * needs_better_patch:  0 => 1
 * ui_ux:   => 0


Comment:

 Patch doesn't apply clean on trunk.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15840: [patch] wrap the inner function of the condition decorator

[Django]

#15840: [patch] wrap the inner function of the condition decorator
-+-
   Reporter:  portante   |  Owner:  nobody
   Type: | Status:  new
  Cleanup/optimization   |  Component:  Core (Other)
  Milestone: |   Severity:  Normal
Version: |   Keywords:
 Resolution: |  Has patch:  1
   Triage Stage:  Accepted   |Needs tests:  0
Needs documentation:  0  |  Easy pickings:  1
Patch needs improvement:  0  |
-+-
Changes (by dmclain):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15840: [patch] wrap the inner function of the condition decorator

[Django]

#15840: [patch] wrap the inner function of the condition decorator
-+-
   Reporter:  portante   |  Owner:  nobody
   Type: | Status:  new
  Cleanup/optimization   |  Component:  Core (Other)
  Milestone: |   Severity:  Normal
Version: |   Keywords:
 Resolution: |  Has patch:  1
   Triage Stage:  Accepted   |Needs tests:  0
Needs documentation:  0  |  Easy pickings:  1
Patch needs improvement:  1  |
-+-
Changes (by patchhammer):

 * needs_better_patch:  0 => 1


Comment:

 15840.patch.diff fails to apply cleanly on to trunk

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15840: [patch] wrap the inner function of the condition decorator

[Django]

#15840: [patch] wrap the inner function of the condition decorator
-+-
   Reporter:  portante   |  Owner:  nobody
   Type: | Status:  new
  Cleanup/optimization   |  Component:  Core (Other)
  Milestone: |   Severity:  Normal
Version: |   Keywords:
 Resolution: |  Has patch:  1
   Triage Stage:  Accepted   |Needs tests:  0
Needs documentation:  0  |  Easy pickings:  1
Patch needs improvement:  0  |
-+-
Changes (by emulbreh):

 * needs_better_patch:   => 0
 * component:  Uncategorized => Core (Other)
 * needs_tests:   => 0
 * easy:   => 1
 * needs_docs:   => 0
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #15840: [patch] wrap the inner function of the condition decorator

[Django]

#15840: [patch] wrap the inner function of the condition decorator
--+--
 Reporter:  portante  | Owner:  nobody
 Type:  Cleanup/optimization  |Status:  new
Milestone:| Component:  Uncategorized
  Version:|  Severity:  Normal
 Keywords:|  Triage Stage:  Unreviewed
Has patch:  1 |
--+--
 Like all the other `inner` functions in the
 
[http://code.djangoproject.com/browser/django/trunk/django/views/decorators/http.py?rev=16028
 django/views/decorators/http.py] module, wrap the `inner` function so that
 it exposes it's wrapped function's attributes.

 Ran the unit tests successfully on my Mac Book Pro (10.6.7, 2 cores, 4
 GB), see attached unit test run output.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.