Re: [Django] #15841: User model conflicts with CommentDetailsForm

2011-04-21 Thread Django
#15841: User model conflicts with CommentDetailsForm
--+--
   Reporter:  admin@… |  Owner:  nobody
   Type:  Bug | Status:  closed
  Milestone:  |  Component:  contrib.comments
Version:  1.3 |   Severity:  Normal
 Resolution:  needsinfo   |   Keywords:
   Triage Stage:  Unreviewed  |  Has patch:  0
Needs documentation:  0   |Needs tests:  0
Patch needs improvement:  0   |  Easy pickings:  0
--+--
Changes (by aaugustin):

 * status:  new => closed
 * resolution:   => needsinfo
 * easy:   => 0


Comment:

 By design, !CommentDetailsForm requires an email address. As a direct
 consequence, so does !CommentForm. Many people rely on this behavior and
 it should not be changed lightly.

 If this is an issue for you, you can subclass !CommentDetailsForm and set
 `blank=True` for the email field.

 As far as I can tell, when a user is logged in and posts a comment without
 filling in his details,
 `django.contrib.comments.views.comments.post_comment` will add them based
 on the user's profile. However, this is not documented. Since a user
 without an email in his profile can always give it in the comments form, I
 don't think there's a bug.

 Please provide more information on how to reproduce your issue if this
 answer is not satisfying.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.



Re: [Django] #15841: User model conflicts with CommentDetailsForm (was: User conflict with CommentDetailsForm)

2011-04-17 Thread Django
#15841: User model conflicts with CommentDetailsForm
--+
   Reporter:  admin@… |Owner:  nobody
   Type:  Bug |   Status:  new
  Milestone:  |Component:  contrib.comments
Version:  1.3 | Severity:  Normal
 Resolution:  | Keywords:
   Triage Stage:  Unreviewed  |Has patch:  0
Needs documentation:  0   |  Needs tests:  0
Patch needs improvement:  0   |
--+
Changes (by admin@…):

 * needs_better_patch:   => 0
 * needs_docs:   => 0
 * needs_tests:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.