Re: [Django] #15856: Add a localflavor for Macedonia

[Django]

#15856: Add a localflavor for Macedonia
-+-
   Reporter: |  Owner:  nobody
  vasiliyeah | Status:  new
   Type:  New|  Component:  contrib.localflavor
  feature|   Severity:  Normal
  Milestone:  1.4|   Keywords:
Version:  SVN|  Has patch:  1
 Resolution: |Needs tests:  0
   Triage Stage:  Ready for  |  Easy pickings:  0
  checkin|
Needs documentation:  0  |
Patch needs improvement:  0  |
  UI/UX:  0  |
-+-
Changes (by jezdez):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15856: Add a localflavor for Macedonia

[Django]

#15856: Add a localflavor for Macedonia
-+-
   Reporter: |  Owner:  nobody
  vasiliyeah | Status:  new
   Type:  New|  Component:  contrib.localflavor
  feature|   Severity:  Normal
  Milestone:  1.4|   Keywords:
Version:  SVN|  Has patch:  1
 Resolution: |Needs tests:  0
   Triage Stage:  Accepted   |  Easy pickings:  0
Needs documentation:  0  |
Patch needs improvement:  0  |
  UI/UX:  0  |
-+-
Changes (by vasiliyeah):

 * needs_better_patch:  1 => 0
 * ui_ux:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15856: Add a localflavor for Macedonia

[Django]

#15856: Add a localflavor for Macedonia
-+-
   Reporter: |  Owner:  nobody
  vasiliyeah | Status:  new
   Type:  New|  Component:  contrib.localflavor
  feature|   Severity:  Normal
  Milestone:  1.4|   Keywords:
Version:  SVN|  Has patch:  1
 Resolution: |Needs tests:  0
   Triage Stage:  Accepted   |  Easy pickings:  0
Needs documentation:  0  |
Patch needs improvement:  1  |
-+-

Comment (by vasiliyeah):

 OK, got it. I removed the prefix and updated the code and docs
 accordingly. The reason they were prefixed is that the codes are HASC
 codes and those are hierarchical and prefixed wit the country code. But, I
 can't see a scenario where a conflict could arise if they are not.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15856: Add a localflavor for Macedonia

[Django]

#15856: Add a localflavor for Macedonia
-+-
   Reporter: |  Owner:  nobody
  vasiliyeah | Status:  new
   Type:  New|  Component:  contrib.localflavor
  feature|   Severity:  Normal
  Milestone:  1.4|   Keywords:
Version:  SVN|  Has patch:  1
 Resolution: |Needs tests:  0
   Triage Stage:  Accepted   |  Easy pickings:  0
Needs documentation:  0  |
Patch needs improvement:  1  |
-+-

Comment (by jezdez):

 I meant the name of the choice keys, e.g.:

 {{{
 MK_MUNICIPALITIES = (
 ('MK.AD', _(u'Aerodrom')),
 ('MK.AR', _(u'Aračinovo')),
 # ..
 )
 }}}

 Unless there is some kind of sensible reason (e.g. a standard or common
 sense) to prefix the choice key with "MK." we should just leave it out:

 {{{
 MK_MUNICIPALITIES = (
 ('AD', _(u'Aerodrom')),
 ('AR', _(u'Aračinovo')),
 # ..
 )
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15856: Add a localflavor for Macedonia

[Django]

#15856: Add a localflavor for Macedonia
-+-
   Reporter: |  Owner:  nobody
  vasiliyeah | Status:  new
   Type:  New|  Component:  contrib.localflavor
  feature|   Severity:  Normal
  Milestone:  1.4|   Keywords:
Version:  SVN|  Has patch:  1
 Resolution: |Needs tests:  0
   Triage Stage:  Accepted   |  Easy pickings:  0
Needs documentation:  0  |
Patch needs improvement:  1  |
-+-

Comment (by vasiliyeah):

 Disregard the pervious comment. I think what jezdez meant is that tuple
 wasn't prefixed with MK but it should have been. And I thought that I did
 prefix it. I've attached a patch with my latest work. I tried to keep
 stuff consistent with what is in other localflavors and reordered some of
 the code so it's sorted alphabetically.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15856: Add a localflavor for Macedonia

[Django]

#15856: Add a localflavor for Macedonia
-+-
   Reporter: |  Owner:  nobody
  vasiliyeah | Status:  new
   Type:  New|  Component:  contrib.localflavor
  feature|   Severity:  Normal
  Milestone:  1.4|   Keywords:
Version:  SVN|  Has patch:  1
 Resolution: |Needs tests:  0
   Triage Stage:  Accepted   |  Easy pickings:  0
Needs documentation:  0  |
Patch needs improvement:  1  |
-+-

Comment (by vasiliyeah):

 Replying to [comment:4 jezdez]:
 > Please attach the patch here for the sake of completeness.
 >
 > Unless there is a specific reason, please don't prefix the
 MUNICIPALITY_CHOICES  with "MK.".
 >
 > Also, the translation updates shouldn't be part of the patch.

 Are you sure about the prefix? I can remove it without a problem, but I
 did that in order to be consistent with the existing codebase for
 localflavor. Looking at choices tuples for other localflavors I can see
 that tupples are prefixed with the country code example:

 {{{HR_COUNTY_CHOICES}}} (this is a new one)

 {{{IS_POSTALCODES}}}

 {{{US_TERRITORIES}}}

 etc...

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15856: Add a localflavor for Macedonia

[Django]

#15856: Add a localflavor for Macedonia
-+-
   Reporter: |  Owner:  nobody
  vasiliyeah | Status:  new
   Type:  New|  Component:  contrib.localflavor
  feature|   Severity:  Normal
  Milestone:  1.4|   Keywords:
Version:  SVN|  Has patch:  1
 Resolution: |Needs tests:  0
   Triage Stage:  Accepted   |  Easy pickings:  0
Needs documentation:  0  |
Patch needs improvement:  1  |
-+-

Comment (by jezdez):

 Please attach the patch here for the sake of completeness.

 Unless there is a specific reason, please don't prefix the
 MUNICIPALITY_CHOICES  with "MK.".

 Also, the translation updates shouldn't be part of the patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15856: Add a localflavor for Macedonia

[Django]

#15856: Add a localflavor for Macedonia
-+-
   Reporter: |  Owner:  nobody
  vasiliyeah | Status:  new
   Type:  New|  Component:  contrib.localflavor
  feature|   Severity:  Normal
  Milestone:  1.4|   Keywords:
Version:  SVN|  Has patch:  1
 Resolution: |Needs tests:  0
   Triage Stage:  Accepted   |  Easy pickings:  0
Needs documentation:  0  |
Patch needs improvement:  1  |
-+-

Comment (by anonymous):

 The alphabetical order may be out of line when importing tests (mk should
 go before mx). I'll fix that.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15856: Add a localflavor for Macedonia

[Django]

#15856: Add a localflavor for Macedonia
-+-
   Reporter: |  Owner:  nobody
  vasiliyeah | Status:  new
   Type:  New|  Component:  contrib.localflavor
  feature|   Severity:  Normal
  Milestone:  1.4|   Keywords:
Version:  SVN|  Has patch:  1
 Resolution: |Needs tests:  0
   Triage Stage:  Accepted   |  Easy pickings:  0
Needs documentation:  0  |
Patch needs improvement:  1  |
-+-

Comment (by anonymous):

 The alphabetical order in the municipalities list looks as if it is not
 respected when you read it as it is with latin characters. When the
 translation is applied in Cyrillic it is in alphabetical order respecting
 the Cyrillic alphabet ordering абвгд... (abvgd). So it is like that
 intentionally os it's sorted properly when the translation to Macedonian
 is applied.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15856: Add a localflavor for Macedonia

[Django]

#15856: Add a localflavor for Macedonia
-+-
   Reporter: |  Owner:  nobody
  vasiliyeah | Status:  new
   Type:  New|  Component:  contrib.localflavor
  feature|   Severity:  Normal
  Milestone:  1.4|   Keywords:
Version:  SVN|  Has patch:  1
 Resolution: |Needs tests:  0
   Triage Stage:  Accepted   |  Easy pickings:  0
Needs documentation:  0  |
Patch needs improvement:  1  |
-+-
Changes (by aaugustin):

 * needs_better_patch:   => 1
 * stage:  Unreviewed => Accepted
 * easy:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 This work looks pretty good and the request is reasonable. Accepting the
 ticket.

 Reading through the patch, I noticed that sometimes the alphabetical order
 is not respected when inserting MK-related stuff in existing files; this
 should be fixed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #15856: Add a localflavor for Macedonia

[Django]

#15856: Add a localflavor for Macedonia
-+
 Reporter:  vasiliyeah   | Owner:  nobody
 Type:  New feature  |Status:  new
Milestone:  1.4  | Component:  contrib.localflavor
  Version:  SVN  |  Severity:  Normal
 Keywords:   |  Triage Stage:  Unreviewed
Has patch:  1|
-+
 I've created a localflavor package with form and model fields for a
 Macedonian localflavor. Tests and documentation are included. Also a
 translation for the mk locale is included. Although I'm not sure updates
 to translation are handled in this way anymore since the transition to
 transifex.

 There's a pull request on GitHub https://github.com/django/django/pull/22

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.