Re: [Django] #15866: get_model() and get_models() can return models that are not in INSTALLED_APPS

[Django]

#15866: get_model() and get_models() can return models that are not in
INSTALLED_APPS
-+-
 Reporter:  carljm   |Owner:  carljm
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:
  (models, ORM)  |   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|
Easy pickings:  0|
-+-

Comment (by Aymeric Augustin ):

 In [changeset:"9f13c3328199d2fa70235cdc63bb06b1efc5b117"]:
 {{{
 #!CommitTicketReference repository=""
 revision="9f13c3328199d2fa70235cdc63bb06b1efc5b117"
 Removed the only_installed argument of Apps.get_models.

 Refs #15903, #15866, #15850.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.dadc6963a7ab5e7bf834e6f585434437%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #15866: get_model() and get_models() can return models that are not in INSTALLED_APPS

[Django]

#15866: get_model() and get_models() can return models that are not in
INSTALLED_APPS
-+-
   Reporter:  carljm |  Owner:  carljm
   Type:  Bug| Status:  closed
  Milestone: |  Component:  Database layer
Version: |  (models, ORM)
 Resolution:  fixed  |   Severity:  Normal
   Triage Stage:  Accepted   |   Keywords:
Needs documentation:  0  |  Has patch:  1
Patch needs improvement:  0  |Needs tests:  0
 |  Easy pickings:  0
-+-

Comment (by carljm):

 Replying to [comment:5 jezdez]:
 > This should really have been added to the app-loading branch, not trunk.

 I don't mind porting this fix to app-loading branch, but fixing it in
 trunk resolved a problematic regression (#15850) which prevented reusable
 app authors from running their tests against trunk. I wouldn't want to
 delay that fix until app-loading lands, though if having this in trunk is
 a serious problem we could temporarily use a hackier workaround to resolve
 #15850.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15866: get_model() and get_models() can return models that are not in INSTALLED_APPS

[Django]

#15866: get_model() and get_models() can return models that are not in
INSTALLED_APPS
-+-
   Reporter:  carljm |  Owner:  carljm
   Type:  Bug| Status:  closed
  Milestone: |  Component:  Database layer
Version: |  (models, ORM)
 Resolution:  fixed  |   Severity:  Normal
   Triage Stage:  Accepted   |   Keywords:
Needs documentation:  0  |  Has patch:  1
Patch needs improvement:  0  |Needs tests:  0
 |  Easy pickings:  0
-+-
Changes (by jezdez):

 * easy:   => 0


Comment:

 This should really have been added to the app-loading branch, not trunk.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15866: get_model() and get_models() can return models that are not in INSTALLED_APPS

[Django]

#15866: get_model() and get_models() can return models that are not in
INSTALLED_APPS
-+-
   Reporter:  carljm |Owner:  carljm
   Type:  Bug|   Status:  assigned
  Milestone: |Component:  Database layer
Version: |  (models, ORM)
 Resolution: | Severity:  Normal
   Triage Stage:  Accepted   | Keywords:
Needs documentation:  0  |Has patch:  1
Patch needs improvement:  0  |  Needs tests:  0
-+-
Changes (by carljm):

 * has_patch:  0 => 1


Comment:

 Candidate fix for this with test here:
 https://github.com/carljm/django/compare/master...t15866

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15866: get_model() and get_models() can return models that are not in INSTALLED_APPS

[Django]

#15866: get_model() and get_models() can return models that are not in
INSTALLED_APPS
-+-
   Reporter:  carljm |Owner:  carljm
   Type:  Bug|   Status:  assigned
  Milestone: |Component:  Database layer
Version: |  (models, ORM)
 Resolution: | Severity:  Normal
   Triage Stage:  Accepted   | Keywords:
Needs documentation:  0  |Has patch:  0
Patch needs improvement:  0  |  Needs tests:  0
-+-

Comment (by carljm):

 #15850 is the most immediately problematic symptom of this bug.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15866: get_model() and get_models() can return models that are not in INSTALLED_APPS

[Django]

#15866: get_model() and get_models() can return models that are not in
INSTALLED_APPS
-+-
   Reporter:  carljm |Owner:  carljm
   Type:  Bug|   Status:  assigned
  Milestone: |Component:  Database layer
Version: |  (models, ORM)
 Resolution: | Severity:  Normal
   Triage Stage:  Accepted   | Keywords:
Needs documentation:  0  |Has patch:  0
Patch needs improvement:  0  |  Needs tests:  0
-+-
Changes (by carljm):

 * status:  new => assigned
 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * owner:  nobody => carljm
 * needs_docs:   => 0
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #15866: get_model() and get_models() can return models that are not in INSTALLED_APPS

[Django]

#15866: get_model() and get_models() can return models that are not in
INSTALLED_APPS
+-
 Reporter:  carljm  | Owner:  nobody
 Type:  Bug |Status:  new
Milestone:  | Component:  Database layer (models, ORM)
  Version:  |  Severity:  Normal
 Keywords:  |  Triage Stage:  Unreviewed
Has patch:  0   |
+-
 `register_models()` does not check if the app is present in
 INSTALLED_APPS, and so importing a models.py file will cause that apps'
 models to be available via `get_model()` or `get_models()`, even though
 the app is not installed (meaning it has no database tables, so actually
 using those models is almost certain to cause a database error).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.