Re: [Django] #15877: Exception:ModelForm has no model class specified

[Django]

#15877: Exception:ModelForm has no model class specified
-+-
 Reporter:  theaspect@…  |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Forms|  Version:  1.3
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Claude Paroz ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"cc53d9b30bd73c12413c28101d5db9f9f4df517c"]:
 {{{
 #!CommitTicketReference repository=""
 revision="cc53d9b30bd73c12413c28101d5db9f9f4df517c"
 Fixed #15877 -- Improved exception when ModelForm has no model class

 Thanks theaspect at gmail.com for the report and volrath for the
 patch.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #15877: Exception:ModelForm has no model class specified

[Django]

#15877: Exception:ModelForm has no model class specified
-+-
 Reporter:  theaspect@…  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Forms|  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by claudep):

 * status:  reopened => new
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #15877: Exception:ModelForm has no model class specified

[Django]

#15877: Exception:ModelForm has no model class specified
-+
 Reporter:  theaspect@…  |Owner:  nobody
 Type:  Bug  |   Status:  reopened
Component:  Forms|  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+

Comment (by vanschelven):

 The above story from 16 months ago checks out, I have no idea why it was
 never committed. I've reimplemented it as a pull request.

 https://github.com/django/django/pull/783

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #15877: Exception:ModelForm has no model class specified

[Django]

#15877: Exception:ModelForm has no model class specified
-+
 Reporter:  theaspect@…  |Owner:  nobody
 Type:  Bug  |   Status:  reopened
Component:  Forms|  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+

Comment (by volrath):

 I added a new version of the patch.

 I thought of that, but it seemed to me (from the comments on that part of
 the test) they were trying to test that even though ShortCategory didn't
 have a model class, having the same fields as the Category model was good
 enough to save the form using a base category instance.

 Anyway, There's the new patch with your correction.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15877: Exception:ModelForm has no model class specified

[Django]

#15877: Exception:ModelForm has no model class specified
-+
 Reporter:  theaspect@…  |Owner:  nobody
 Type:  Bug  |   Status:  reopened
Component:  Forms|  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+
Changes (by julien):

 * needs_better_patch:  0 => 1


Comment:

 The new test looks good. However, there's no need to remove the failing
 existing test. That could be fixed by adding '`class Meta: model =
 Category`' to `ShortCategory` to make it valid.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15877: Exception:ModelForm has no model class specified

[Django]

#15877: Exception:ModelForm has no model class specified
-+
 Reporter:  theaspect@…  |Owner:  nobody
 Type:  Bug  |   Status:  reopened
Component:  Forms|  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by volrath):

 * needs_tests:  1 => 0


Comment:

 I replaced previous patch with a new one that includes tests.

 There's one thing I'm not sure it's right: if you look the patch you'll
 see I deleted part of a test (`OldFormForXTests.test_with_data`) that's
 against the "`ModelForm.__init__` should raise the `ValueError` in all
 cases" restriction, and of course it was making that test fail. Please
 tell me if that should not be deleted so I can fix it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15877: Exception:ModelForm has no model class specified

[Django]

#15877: Exception:ModelForm has no model class specified
-+
 Reporter:  theaspect@…  |Owner:  nobody
 Type:  Bug  |   Status:  reopened
Component:  Forms|  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by julien):

 * needs_tests:  0 => 1


Comment:

 Thanks for the patch. Could you also provide some tests?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15877: Exception:ModelForm has no model class specified

[Django]

#15877: Exception:ModelForm has no model class specified
-+
 Reporter:  theaspect@…  |Owner:  nobody
 Type:  Bug  |   Status:  reopened
Component:  Forms|  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by volrath):

 * has_patch:  0 => 1
 * ui_ux:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15877: Exception:ModelForm has no model class specified

[Django]

#15877: Exception:ModelForm has no model class specified
---+--
   Reporter:  theaspect@…  |  Owner:  nobody
   Type:  Bug  | Status:  reopened
  Milestone:   |  Component:  Forms
Version:  1.3  |   Severity:  Normal
 Resolution:   |   Keywords:
   Triage Stage:  Accepted |  Has patch:  0
Needs documentation:  0|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
---+--
Changes (by jacob):

 * stage:  Unreviewed => Accepted


Comment:

 Verified. `ModelForm.__init__` should raise the `ValueError` in all cases.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15877: Exception:ModelForm has no model class specified

[Django]

#15877: Exception:ModelForm has no model class specified
---+--
   Reporter:  theaspect@…  |  Owner:  nobody
   Type:  Bug  | Status:  reopened
  Milestone:   |  Component:  Forms
Version:  1.3  |   Severity:  Normal
 Resolution:   |   Keywords:
   Triage Stage:  Unreviewed   |  Has patch:  0
Needs documentation:  0|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
---+--
Changes (by anonymous):

 * status:  closed => reopened
 * resolution:  needsinfo =>


Comment:

 it's pretty clear
 {{{
 class SomeModel(models.Model):
 ...

 class MyForm(forms.ModelForm):
 class Meta:
 pass

 f = MyForm() #raises exception (ModelForm has no model class specified.)
 f = MyForm(instance=SomeModel) #don't but expected too
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #15877: Exception:ModelForm has no model class specified

[Django]

#15877: Exception:ModelForm has no model class specified
---+
   Reporter:  theaspect@…  |  Owner:  nobody
   Type:  Bug  | Status:  closed
  Milestone:   |  Component:  Forms
Version:  1.3  |   Severity:  Normal
 Resolution:  needsinfo|   Keywords:
   Triage Stage:  Unreviewed   |  Has patch:  0
Needs documentation:  0|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
---+
Changes (by akaariai):

 * status:  new => closed
 * needs_docs:   => 0
 * resolution:   => needsinfo
 * needs_tests:   => 0
 * needs_better_patch:   => 0


Comment:

 I am afraid that there is not enough information about the problem to
 verify this as a bug. Giving concrete sample of the problem would help.
 That is, could you write Python code which would show the problem?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #15877: Exception:ModelForm has no model class specified

[Django]

#15877: Exception:ModelForm has no model class specified
-+
 Reporter:  theaspect@…  |  Owner:  nobody
 Type:  Bug  | Status:  new
Milestone:   |  Component:  Forms
  Version:  1.3  |   Severity:  Normal
 Keywords:   |   Triage Stage:  Unreviewed
Has patch:  0|  Easy pickings:  0
-+
 case:
 subj exception does not throws when
 in user class model is '''not''' specified
 in constructor instance is specified
 result:
 silently falls in validation returns > empty cleaned dict > nothing
 rendered
 expected:
 exception throws

 here:
 http://code.djangoproject.com/browser/django/trunk/django/forms/models.py#L229

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.