Re: [Django] #16096: Template instances should have an origin attribute.

[Django]

#16096: Template instances should have an origin attribute.
-+
 Reporter:  jdunck   |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Template system  |  Version:  1.3
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"8625c7aab3760d16572792fea23a95e572e28ead"]:
 {{{
 #!CommitTicketReference repository=""
 revision="8625c7aab3760d16572792fea23a95e572e28ead"
 Fixed #16096 -- Added origin attribute to template instances.

 Thanks jdunck for the suggestion.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.50cccef0aeee7bdc934fa8fde3c316f1%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16096: Template instances should have an origin attribute.

[Django]

#16096: Template instances should have an origin attribute.
-+
 Reporter:  jdunck   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Template system  |  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+
Changes (by timo):

 * needs_better_patch:  0 => 1
 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.de5494e538fb25317fc9584382e2dd52%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16096: Template instances should have an origin attribute.

[Django]

#16096: Template instances should have an origin attribute.
-+
 Reporter:  jdunck   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Template system  |  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by prestontimmons):

 I added a pull request for this here.

 https://github.com/django/django/pull/1534

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.ad9ebb553be53d0aa2156baf99013339%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16096: Template instances should have an origin attribute.

[Django]

#16096: Template instances should have an origin attribute.
---+-
   Reporter:  jdunck   |  Owner:  nobody
   Type:  New feature  | Status:  new
  Milestone:   |  Component:  Template system
Version:  1.3  |   Severity:  Normal
 Resolution:   |   Keywords:
   Triage Stage:  Accepted |  Has patch:  0
Needs documentation:  0|Needs tests:  0
Patch needs improvement:  0|  Easy pickings:  0
---+-
Changes (by julien):

 * stage:  Unreviewed => Accepted


Comment:

 This makes sense and it can't hurt. Are you thinking of any particular API
 other than just setting the `origin` attribute to the `Template` instance?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #16096: Template instances should have an origin attribute.

[Django]

#16096: Template instances should have an origin attribute.
-+---
 Reporter:  jdunck   |Owner:  nobody
 Type:  New feature  |   Status:  new
Milestone:   |Component:  Template system
  Version:  1.3  | Severity:  Normal
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|
-+---
 Templates are constructed with an optional origin argument; this is used
 for debugging purposes.

 But I think it would be useful for the Template instance to have an origin
 attribute -- then template origins could be more easily inspected and
 logged outside the django.template infrastructure.  The specific use case
 I have in mind is making it clearer to FE devs which templates/template
 dirs are being used for a given request.

 Template's constructor receives an origin parameter, so this should be a
 simple change.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.