Re: [Django] #16218: Class-based month archive doesn't behave like previous generic view

[Django]

#16218: Class-based month archive doesn't behave like previous generic view
---+-
 Reporter:  nnrcschmdt |Owner:  aaugustin
 Type:  Bug|   Status:  closed
Component:  Generic views  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-

Comment (by Aymeric Augustin ):

 In [changeset:"11f6295551fbcedae50df0efcae5eb34555a46dd"]:
 {{{
 #!CommitTicketReference repository=""
 revision="11f6295551fbcedae50df0efcae5eb34555a46dd"
 [1.5.x] Documented ArchiveIndexView's date_list context variable.

 Refs #16218.

 Backport of a0c67c6.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16218: Class-based month archive doesn't behave like previous generic view

[Django]

#16218: Class-based month archive doesn't behave like previous generic view
---+-
 Reporter:  nnrcschmdt |Owner:  aaugustin
 Type:  Bug|   Status:  closed
Component:  Generic views  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-

Comment (by Aymeric Augustin ):

 In [changeset:"11f6295551fbcedae50df0efcae5eb34555a46dd"]:
 {{{
 #!CommitTicketReference repository=""
 revision="11f6295551fbcedae50df0efcae5eb34555a46dd"
 [1.5.x] Documented ArchiveIndexView's date_list context variable.

 Refs #16218.

 Backport of a0c67c6.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16218: Class-based month archive doesn't behave like previous generic view

[Django]

#16218: Class-based month archive doesn't behave like previous generic view
---+-
 Reporter:  nnrcschmdt |Owner:  aaugustin
 Type:  Bug|   Status:  closed
Component:  Generic views  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-

Comment (by Aymeric Augustin ):

 In [changeset:"a0c67c69bf49d9e1902afd57d95b8511aa911ccb"]:
 {{{
 #!CommitTicketReference repository=""
 revision="a0c67c69bf49d9e1902afd57d95b8511aa911ccb"
 Documented ArchiveIndexView's date_list context variable.

 Refs #16218.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16218: Class-based month archive doesn't behave like previous generic view

[Django]

#16218: Class-based month archive doesn't behave like previous generic view
---+-
 Reporter:  nnrcschmdt |Owner:  aaugustin
 Type:  Bug|   Status:  closed
Component:  Generic views  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by Aymeric Augustin ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"baa33cd8faa16737524b1ac355802a10dd63571c"]:
 {{{
 #!CommitTicketReference repository=""
 revision="baa33cd8faa16737524b1ac355802a10dd63571c"
 Fixed #16218 -- date_list order in generic CBVs.

 Thanks nnrcschmdt for the report and bpeschier for the initial
 version of the patch.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16218: Class-based month archive doesn't behave like previous generic view

[Django]

#16218: Class-based month archive doesn't behave like previous generic view
---+-
 Reporter:  nnrcschmdt |Owner:  aaugustin
 Type:  Bug|   Status:  new
Component:  Generic views  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-

Comment (by aaugustin):

 Marking RFC per apollo13's comment on the PR.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16218: Class-based month archive doesn't behave like previous generic view

[Django]

#16218: Class-based month archive doesn't behave like previous generic view
---+-
 Reporter:  nnrcschmdt |Owner:  aaugustin
 Type:  Bug|   Status:  new
Component:  Generic views  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by aaugustin):

 * needs_better_patch:  1 => 0


Comment:

 I just reviewed the history of this ticket and updated the patch. Pull
 request: https://github.com/django/django/pull/362

 The documented order seems much more logical to me than the implemented
 order. Like nnrcschmdt and bpeschier, I'd prefer to restore the documented
 order, even though it introduces a backwards incompatibility.

 As an unscientific datapoint, I always reverse `date_list` in year and
 month views in my templates; when we fix this ticket I'll be able to
 remove that code.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16218: Class-based month archive doesn't behave like previous generic view

[Django]

#16218: Class-based month archive doesn't behave like previous generic view
---+-
 Reporter:  nnrcschmdt |Owner:  aaugustin
 Type:  Bug|   Status:  new
Component:  Generic views  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by aaugustin):

 * owner:  nobody => aaugustin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16218: Class-based month archive doesn't behave like previous generic view

[Django]

#16218: Class-based month archive doesn't behave like previous generic view
--+---
   Reporter:  nnrcschmdt  |  Owner:  nobody
   Type:  Bug | Status:  new
  Milestone:  |  Component:  Generic views
Version:  SVN |   Severity:  Normal
 Resolution:  |   Keywords:
   Triage Stage:  Accepted|  Has patch:  1
Needs documentation:  0   |Needs tests:  0
Patch needs improvement:  1   |  Easy pickings:  0
  UI/UX:  0   |
--+---
Changes (by adamnelson):

 * needs_better_patch:  0 => 1


Comment:

 Patch no longer cleanly applies

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16218: Class-based month archive doesn't behave like previous generic view

[Django]

#16218: Class-based month archive doesn't behave like previous generic view
--+---
   Reporter:  nnrcschmdt  |  Owner:  nobody
   Type:  Bug | Status:  new
  Milestone:  |  Component:  Generic views
Version:  SVN |   Severity:  Normal
 Resolution:  |   Keywords:
   Triage Stage:  Accepted|  Has patch:  1
Needs documentation:  0   |Needs tests:  0
Patch needs improvement:  0   |  Easy pickings:  0
  UI/UX:  0   |
--+---
Changes (by bpeschier):

 * has_patch:  0 => 1


Comment:

 Patch updates generic CBV to sort {{{date_list}}} in basic index view
 descending and year/month view ascending. It also adds tests to check the
 order. This covers the first fail in the report.

 The second fail is a different story: in the generic CBV code there is a
 section about preventing to link to empty pages ![1]. Conforming to that,
 the patch contains an update for the docs to clarify that behaviour with
 the {{{allow_empty}}} setting. This is different from the old generic
 views, where this data is given even if {{{allow_empty}}} is {{{False}}}.

 ![1]:
 
https://code.djangoproject.com/browser/django/trunk/django/views/generic/dates.py?rev=16363#L520

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16218: Class-based month archive doesn't behave like previous generic view

[Django]

#16218: Class-based month archive doesn't behave like previous generic view
--+---
   Reporter:  nnrcschmdt  |  Owner:  nobody
   Type:  Bug | Status:  new
  Milestone:  |  Component:  Generic views
Version:  SVN |   Severity:  Normal
 Resolution:  |   Keywords:
   Triage Stage:  Accepted|  Has patch:  0
Needs documentation:  0   |Needs tests:  0
Patch needs improvement:  0   |  Easy pickings:  0
  UI/UX:  0   |
--+---
Changes (by bpeschier):

 * stage:  Unreviewed => Accepted


Comment:

 According to the docs at https://docs.djangoproject.com/en/dev/ref/class-
 based-views/#montharchiveview, date_list should be ordered ascending.
 Seems like that is not the case, I added a test for ascending order in the
 generic CBV tests, which gives:

 {{{
 FAIL: test_date_list_order
 (regressiontests.generic_views.dates.ArchiveIndexViewTests)
 date_list should be ascending
 --
 Traceback (most recent call last):
   File "/Users/bpeschier/dev/python/envs/django-dev/django-
 trunk/tests/regressiontests/generic_views/dates.py", line 83, in
 test_date_list_order
 self.assertEqual(res.context['date_list'],
 list(sorted(res.context['date_list'])))
 AssertionError: Lists differ: [datetime.datetime(2011, 1, 1,... !=
 [datetime.datetime(2006, 1, 1,...
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16218: Class-based month archive doesn't behave like previous generic view

[Django]

#16218: Class-based month archive doesn't behave like previous generic view
--+---
   Reporter:  nnrcschmdt  |  Owner:  nobody
   Type:  Bug | Status:  new
  Milestone:  |  Component:  Generic views
Version:  SVN |   Severity:  Normal
 Resolution:  |   Keywords:
   Triage Stage:  Unreviewed  |  Has patch:  0
Needs documentation:  0   |Needs tests:  0
Patch needs improvement:  0   |  Easy pickings:  0
  UI/UX:  0   |
--+---

Comment (by bpeschier):

 Quick digging reveals that the old generic views do
 {{{
 date_list = queryset.dates(date_field, 'day')
 }}}

 while the new one does

 {{{
 date_list = queryset.dates(date_field, date_type)[::-1]
 }}}

 So, the two dates tested are just sorted differently apparently. The
 questions are: why? and does it hurt?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16218: Class-based month archive doesn't behave like previous generic view

[Django]

#16218: Class-based month archive doesn't behave like previous generic view
--+---
   Reporter:  nnrcschmdt  |  Owner:  nobody
   Type:  Bug | Status:  new
  Milestone:  |  Component:  Generic views
Version:  SVN |   Severity:  Normal
 Resolution:  |   Keywords:
   Triage Stage:  Unreviewed  |  Has patch:  0
Needs documentation:  0   |Needs tests:  0
Patch needs improvement:  0   |  Easy pickings:  0
  UI/UX:  0   |
--+---
Changes (by aaugustin):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Could you be a little bit more specific?

 I trust that applying this patch breaks the tests, but it's difficult to
 determine if that means the code does not behave according to the docs
 and/or obvious expectations.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #16218: Class-based month archive doesn't behave like previous generic view

[Django]

#16218: Class-based month archive doesn't behave like previous generic view
+---
 Reporter:  nnrcschmdt  |  Owner:  nobody
 Type:  Bug | Status:  new
Milestone:  |  Component:  Generic views
  Version:  SVN |   Severity:  Normal
 Keywords:  |   Triage Stage:  Unreviewed
Has patch:  0   |  Easy pickings:  0
UI/UX:  0   |
+---
 While converting some of the regression tests for generic views to class-
 based views, I've noticed that the class-based month archive doesn't
 behave like the previous generic views.

 Applying the attached patch breaks the tests:

 {{{
 FAIL: test_archive_month_date_list
 (regressiontests.views.tests.generic.date_based.MonthArchiveTest)
 ...
 AssertionError: datetime.datetime(2010, 1, 2, 0, 0) !=
 datetime.datetime(2010, 1, 1, 0, 0)

 FAIL: test_archive_month_includes_only_month
 (regressiontests.views.tests.generic.date_based.MonthArchiveTest)
 Regression for #3031: Archives around Feburary include only one month
 ...
 AssertionError: None != datetime.date(2004, 3, 1)
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.