Re: [Django] #16350: Small admin CSS issue: messagelist items should be capitalized to work well in other languages

[Django]

#16350: Small admin CSS issue: messagelist items should be capitalized to work 
well
in other languages
-+-
 Reporter:  semente  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:  css, admin, pt-br| Triage Stage:  Design
Has patch:  1|  decision needed
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  1|  Patch needs improvement:  0
 |UI/UX:  1
-+-

Comment (by julien):

 #16973 was closed as a dupe and has a different patch. See also the
 discussion on django-i18n: http://groups.google.com/group/django-
 i18n/browse_thread/thread/61c19470026d5a83

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16350: Small admin CSS issue: messagelist items should be capitalized to work well in other languages

[Django]

#16350: Small admin CSS issue: messagelist items should be capitalized to work 
well
in other languages
-+-
   Reporter:  semente|  Owner:  nobody
   Type:  Bug| Status:  new
  Milestone: |  Component:  contrib.admin
Version:  1.3|   Severity:  Normal
 Resolution: |   Keywords:  css, admin, pt-br
   Triage Stage:  Design |  Has patch:  1
  decision needed|Needs tests:  0
Needs documentation:  0  |  Easy pickings:  1
Patch needs improvement:  0  |
  UI/UX:  1  |
-+-

Comment (by BernhardEssl):

 Sorry, but I don't think that's a real problem. Why not use in your model
 the Meta class with ''verbose_name''?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16350: Small admin CSS issue: messagelist items should be capitalized to work well in other languages

[Django]

#16350: Small admin CSS issue: messagelist items should be capitalized to work 
well
in other languages
-+-
   Reporter:  semente|  Owner:  nobody
   Type:  Bug| Status:  new
  Milestone: |  Component:  contrib.admin
Version:  1.3|   Severity:  Normal
 Resolution: |   Keywords:  css, admin, pt-br
   Triage Stage:  Design |  Has patch:  1
  decision needed|Needs tests:  0
Needs documentation:  0  |  Easy pickings:  1
Patch needs improvement:  0  |
  UI/UX:  1  |
-+-
Changes (by julien):

 * needs_tests:  1 => 0


Comment:

 That's fair enough, it's debatable and I'm clearly in the minority, so I'm
 removing the flag. Thanks guys for sharing your thoughts!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16350: Small admin CSS issue: messagelist items should be capitalized to work well in other languages

[Django]

#16350: Small admin CSS issue: messagelist items should be capitalized to work 
well
in other languages
-+-
   Reporter:  semente|  Owner:  nobody
   Type:  Bug| Status:  new
  Milestone: |  Component:  contrib.admin
Version:  1.3|   Severity:  Normal
 Resolution: |   Keywords:  css, admin, pt-br
   Triage Stage:  Design |  Has patch:  1
  decision needed|Needs tests:  1
Needs documentation:  0  |  Easy pickings:  1
Patch needs improvement:  0  |
  UI/UX:  1  |
-+-

Comment (by lukeplant):

 I'd be happy to accept the change without a test. When it comes to testing
 specific output in HTML, the test can be extremely difficult to write in
 such a way that it really tests the issue, and even if you manage it, it
 can be so fragile that it is a liability not an asset - e.g. if you
 rearrange the HTML in the admin, the test will break (either by failing or
 by returning a false positive that just causes confusion later).

 I have seen tests written for very specific HTML output, and have often
 concluded that they were worse than useless.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16350: Small admin CSS issue: messagelist items should be capitalized to work well in other languages

[Django]

#16350: Small admin CSS issue: messagelist items should be capitalized to work 
well
in other languages
-+-
   Reporter:  semente|  Owner:  nobody
   Type:  Bug| Status:  new
  Milestone: |  Component:  contrib.admin
Version:  1.3|   Severity:  Normal
 Resolution: |   Keywords:  css, admin, pt-br
   Triage Stage:  Design |  Has patch:  1
  decision needed|Needs tests:  1
Needs documentation:  0  |  Easy pickings:  1
Patch needs improvement:  0  |
  UI/UX:  1  |
-+-

Comment (by semente):

 Replying to [comment:5 jezdez]:
 > Hmm, is it really valid for all languages to capitalize the first word?

 I'm almost sure that it is valid for all latin-based languages, but has
 other languages affected by this patch (you can see which one using
 {{{grep}}}) so maybe we should send that question to the i18n list and
 listen for opinions from people from that languages.

 About the test, I think is valid create a test for the {{{ capfirst }}}
 filter but not for that patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16350: Small admin CSS issue: messagelist items should be capitalized to work well in other languages

[Django]

#16350: Small admin CSS issue: messagelist items should be capitalized to work 
well
in other languages
-+-
   Reporter:  semente|  Owner:  nobody
   Type:  Bug| Status:  new
  Milestone: |  Component:  contrib.admin
Version:  1.3|   Severity:  Normal
 Resolution: |   Keywords:  css, admin, pt-br
   Triage Stage:  Design |  Has patch:  1
  decision needed|Needs tests:  1
Needs documentation:  0  |  Easy pickings:  1
Patch needs improvement:  0  |
  UI/UX:  1  |
-+-

Comment (by julien):

 No problem, I understand the frustration. Been there :-)

 Consistency in requiring tests for (nearly) everything is actually as
 important as the tests themselves, as it's always going to be subjective
 and debatable what is or is not big enough to require tests. Also,
 sometimes, small and seemingly harmless changes end up causing serious
 regressions. It is true that there are more important problems to solve in
 the admin, but everyone is free to spend their time working on the bits
 they want -- it's never going to be a waste of time. If someone cares
 enough about this problem then they'll fix it, write tests and fullfil all
 the requirements for this ticket to proceed.

 It's definitely OK to disagree, and please don't just take my word for it
 and don't let this disagreement hamper your contributions which are very
 much appreciated! :-)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16350: Small admin CSS issue: messagelist items should be capitalized to work well in other languages

[Django]

#16350: Small admin CSS issue: messagelist items should be capitalized to work 
well
in other languages
-+-
   Reporter:  semente|  Owner:  nobody
   Type:  Bug| Status:  new
  Milestone: |  Component:  contrib.admin
Version:  1.3|   Severity:  Normal
 Resolution: |   Keywords:  css, admin, pt-br
   Triage Stage:  Design |  Has patch:  1
  decision needed|Needs tests:  1
Needs documentation:  0  |  Easy pickings:  1
Patch needs improvement:  0  |
  UI/UX:  1  |
-+-

Comment (by aaugustin):

 Sorry for the angry tone in my reply. I wanted to say that, in this
 particular case, the cost of writing a test is very high compared to the
 importance of the bugfix: an utterly minor aesthetic tweak.

 I know the theory of testing, and I agree that tests are important — just
 look at the number of tickets where I set "needs tests". But we have to be
 realistic: if a good Django hacker spends 30 minutes to write a test for
 this, it's a waste of time. There are much more important bugs to fix in
 the admin.

 In short, IMO, we're not focusing on the right priorities. It's OK if you
 disagree and that's why I won't toggle the flag. Now let's stop hijacking
 the tracker with our private discussions :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16350: Small admin CSS issue: messagelist items should be capitalized to work well in other languages

[Django]

#16350: Small admin CSS issue: messagelist items should be capitalized to work 
well
in other languages
-+-
   Reporter:  semente|  Owner:  nobody
   Type:  Bug| Status:  new
  Milestone: |  Component:  contrib.admin
Version:  1.3|   Severity:  Normal
 Resolution: |   Keywords:  css, admin, pt-br
   Triage Stage:  Design |  Has patch:  1
  decision needed|Needs tests:  1
Needs documentation:  0  |  Easy pickings:  1
Patch needs improvement:  0  |
  UI/UX:  1  |
-+-

Comment (by julien):

 Replying to [comment:6 aaugustin]:
 > I'm curious to know how many of the 33 occurrences of capfirst in the
 admin are actually tested by the test suite :(
 >
 > You'd better close the ticket as 'wontfix'. It's more realistic than
 hoping that someone's going to write tests for this.

 Only this one would need to be tested to proceed with this particular
 ticket. If other cases were tested then that'd be even better, but it's
 not necessary here. It's important to write tests even for seemingly small
 changes like this one to avoid future regressions.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16350: Small admin CSS issue: messagelist items should be capitalized to work well in other languages

[Django]

#16350: Small admin CSS issue: messagelist items should be capitalized to work 
well
in other languages
-+-
   Reporter:  semente|  Owner:  nobody
   Type:  Bug| Status:  new
  Milestone: |  Component:  contrib.admin
Version:  1.3|   Severity:  Normal
 Resolution: |   Keywords:  css, admin, pt-br
   Triage Stage:  Design |  Has patch:  1
  decision needed|Needs tests:  1
Needs documentation:  0  |  Easy pickings:  1
Patch needs improvement:  0  |
  UI/UX:  1  |
-+-
Changes (by julien):

 * stage:  Accepted => Design decision needed


Comment:

 Replying to [comment:5 jezdez]:
 > Hmm, is it really valid for all languages to capitalize the first word?

 That's a good point, yet the admin already capitalizes the first word of
 some translatable strings (e.g. `verbose_name_plural` in
 `delete_selected_confirmation.html`). Moving to DDN until a clear answer
 can be provided on the best approach to handle this.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16350: Small admin CSS issue: messagelist items should be capitalized to work well in other languages

[Django]

#16350: Small admin CSS issue: messagelist items should be capitalized to work 
well
in other languages
+---
   Reporter:  semente   |  Owner:  nobody
   Type:  Bug   | Status:  new
  Milestone:|  Component:  contrib.admin
Version:  1.3   |   Severity:  Normal
 Resolution:|   Keywords:  css, admin, pt-br
   Triage Stage:  Accepted  |  Has patch:  1
Needs documentation:  0 |Needs tests:  1
Patch needs improvement:  0 |  Easy pickings:  1
  UI/UX:  1 |
+---

Comment (by aaugustin):

 Replying to [comment:4 julien]:
 > That's right, using `capfirst` in the template is the way to go. This
 now needs tests :)

 I'm curious to know how many of the 33 occurrences of capfirst in the
 admin are actually tested by the test suite :(

 You'd better close the ticket as 'wontfix'. It's more realistic than
 hoping that someone's going to write tests for this.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16350: Small admin CSS issue: messagelist items should be capitalized to work well in other languages

[Django]

#16350: Small admin CSS issue: messagelist items should be capitalized to work 
well
in other languages
+---
   Reporter:  semente   |  Owner:  nobody
   Type:  Bug   | Status:  new
  Milestone:|  Component:  contrib.admin
Version:  1.3   |   Severity:  Normal
 Resolution:|   Keywords:  css, admin, pt-br
   Triage Stage:  Accepted  |  Has patch:  1
Needs documentation:  0 |Needs tests:  1
Patch needs improvement:  0 |  Easy pickings:  1
  UI/UX:  1 |
+---

Comment (by jezdez):

 Hmm, is it really valid for all languages to capitalize the first word?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16350: Small admin CSS issue: messagelist items should be capitalized to work well in other languages

[Django]

#16350: Small admin CSS issue: messagelist items should be capitalized to work 
well
in other languages
+---
   Reporter:  semente   |  Owner:  nobody
   Type:  Bug   | Status:  new
  Milestone:|  Component:  contrib.admin
Version:  1.3   |   Severity:  Normal
 Resolution:|   Keywords:  css, admin, pt-br
   Triage Stage:  Accepted  |  Has patch:  1
Needs documentation:  0 |Needs tests:  1
Patch needs improvement:  0 |  Easy pickings:  1
  UI/UX:  1 |
+---
Changes (by julien):

 * needs_tests:  0 => 1


Comment:

 That's right, using `capfirst` in the template is the way to go. This now
 needs tests :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16350: Small admin CSS issue: messagelist items should be capitalized to work well in other languages

[Django]

#16350: Small admin CSS issue: messagelist items should be capitalized to work 
well
in other languages
+---
   Reporter:  semente   |  Owner:  nobody
   Type:  Bug   | Status:  new
  Milestone:|  Component:  contrib.admin
Version:  1.3   |   Severity:  Normal
 Resolution:|   Keywords:  css, admin, pt-br
   Triage Stage:  Accepted  |  Has patch:  1
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  1
  UI/UX:  1 |
+---

Comment (by semente):

 Hello aagustin, sorry for the mistakes in the patch!

 Django capitalize some letters in CSS or template, so maybe we should use
 the one that is used more often.

 Anyway, technically speaking, fix that kind of bug in the template is
 better (IMHO). To a user change that behavior in CSS him must provide a
 new CSS file (and add it in the ) or overwrite the whole CSS. So
 usually will be simpler if him just overwrite the template block.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16350: Small admin CSS issue: messagelist items should be capitalized to work well in other languages

[Django]

#16350: Small admin CSS issue: messagelist items should be capitalized to work 
well
in other languages
+---
   Reporter:  semente   |  Owner:  nobody
   Type:  Bug   | Status:  new
  Milestone:|  Component:  contrib.admin
Version:  1.3   |   Severity:  Normal
 Resolution:|   Keywords:  css, admin, pt-br
   Triage Stage:  Accepted  |  Has patch:  1
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  1
  UI/UX:  1 |
+---
Changes (by aaugustin):

 * needs_docs:  1 => 0
 * easy:  0 => 1


Comment:

 The CSS spec confirms that `text-transform: capitalize;` isn't appropriate
 here: http://www.w3.org/TR/2008/REC-CSS1-20080411/#text-transform

 I attached two new patches:

 - the first one fixes the problem in CSS — but that doesn't feel very
 Django-like;
 - the second one fixes the problem in the template — that's better IMO.

 (and I wanted to set "needs improvement", not "needs documentation"
 earlier — fat fingers)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16350: Small admin CSS issue: messagelist items should be capitalized to work well in other languages

[Django]

#16350: Small admin CSS issue: messagelist items should be capitalized to work 
well
in other languages
+---
   Reporter:  semente   |  Owner:  nobody
   Type:  Bug   | Status:  new
  Milestone:|  Component:  contrib.admin
Version:  1.3   |   Severity:  Normal
 Resolution:|   Keywords:  css, admin, pt-br
   Triage Stage:  Accepted  |  Has patch:  1
Needs documentation:  1 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  1 |
+---
Changes (by aaugustin):

 * needs_better_patch:   => 0
 * stage:  Unreviewed => Accepted
 * needs_tests:   => 0
 * needs_docs:   => 1


Comment:

 Patch doesn't apply cleanly — it wasn't created against SVN trunk. Also,
 capitalize isn't appropriate as it will capitalize each word (see attached
 screenshot).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #16350: Small admin CSS issue: messagelist items should be capitalized to work well in other languages

[Django]

#16350: Small admin CSS issue: messagelist items should be capitalized to work 
well
in other languages
---+---
 Reporter:  semente|  Owner:  nobody
 Type:  Bug| Status:  new
Milestone: |  Component:  contrib.admin
  Version:  1.3|   Severity:  Normal
 Keywords:  css, admin, pt-br  |   Triage Stage:  Unreviewed
Has patch:  1  |  Easy pickings:  0
UI/UX:  1  |
---+---
 Admin's messagelist items should be capitalized. When using the pt-br
 localization the first letter on the messages is not capitalized because
 it is the object name, who can't be capitalized in the POT files.

 I've attached a screenshot to you figure out better the problem.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.