Re: [Django] #16367: Exceptions thrown by middleware.process_response don't get to middleware.process_exception

[Django]

#16367: Exceptions thrown by middleware.process_response don't get to
middleware.process_exception
-+-
 Reporter:  bob84123 |Owner:  aaugustin
 Type:  New feature  |   Status:  closed
Component:  Core (Other) |  Version:  1.3
 Severity:  Normal   |   Resolution:  wontfix
 Keywords:   | Triage Stage:  Design
Has patch:  1|  decision needed
  Needs tests:  1|  Needs documentation:  1
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by aaugustin):

 * status:  assigned => closed
 * resolution:   => wontfix


Comment:

 Overall, the design of Django's middleware assumes that middleware is
 reliable and will not throw exceptions under normal circumstances.

 Besides, the current behavior is documented.

 Since TransactionMiddleware is now deprecated (it's basically impossible
 to implement this feature reliable as a middleware), the original use case
 has disappeared, and I'm going to close this ticket.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16367: Exceptions thrown by middleware.process_response don't get to middleware.process_exception

[Django]

#16367: Exceptions thrown by middleware.process_response don't get to
middleware.process_exception
-+-
 Reporter:  bob84123 |Owner:  aaugustin
 Type:  New feature  |   Status:  assigned
Component:  Core (Other) |  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Design
Has patch:  1|  decision needed
  Needs tests:  1|  Needs documentation:  1
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by aaugustin):

 * status:  new => assigned
 * owner:  nobody => aaugustin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16367: Exceptions thrown by middleware.process_response don't get to middleware.process_exception

[Django]

#16367: Exceptions thrown by middleware.process_response don't get to
middleware.process_exception
-+-
 Reporter:  bob84123 |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Core (Other) |  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Design
Has patch:  1|  decision needed
  Needs tests:  1|  Needs documentation:  1
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by anonymous):

 It would to be great to have process_exception called for exceptions that
 happen in a middleware. Hope there is progress on this bug soon.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16367: Exceptions thrown by middleware.process_response don't get to middleware.process_exception

[Django]

#16367: Exceptions thrown by middleware.process_response don't get to
middleware.process_exception
-+-
   Reporter:  bob84123   |  Owner:  nobody
   Type:  New| Status:  new
  feature|  Component:  Core (Other)
  Milestone: |   Severity:  Normal
Version:  1.3|   Keywords:
 Resolution: |  Has patch:  1
   Triage Stage:  Design |Needs tests:  1
  decision needed|  Easy pickings:  0
Needs documentation:  1  |
Patch needs improvement:  0  |
  UI/UX:  0  |
-+-
Changes (by aaugustin):

 * needs_better_patch:   => 0
 * component:  HTTP handling => Core (Other)
 * needs_tests:   => 1
 * needs_docs:   => 1
 * type:  Bug => New feature
 * stage:  Unreviewed => Design decision needed


Comment:

 Exception middleware currently works as advertised.

 https://docs.djangoproject.com/en/dev/topics/http/middleware/#process-
 exception:
 > Django calls process_exception() when a view raises an exception.

 You're proposing to change its behavior, so that it will also be called if
 an exception happens in a middleware. This requires a decision by a core
 developer.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #16367: Exceptions thrown by middleware.process_response don't get to middleware.process_exception

[Django]

#16367: Exceptions thrown by middleware.process_response don't get to
middleware.process_exception
--+---
 Reporter:  bob84123  |  Owner:  nobody
 Type:  Bug   | Status:  new
Milestone:|  Component:  HTTP handling
  Version:  1.3   |   Severity:  Normal
 Keywords:|   Triage Stage:  Unreviewed
Has patch:  1 |  Easy pickings:  0
UI/UX:  0 |
--+---
 If I have a custom exception handler, implemented as a middleware class
 with a process_exception method, this handler does not receive an
 exception that is thrown during another middleware's process_response
 method.  This mainly happens with
 django.middleware.transaction.TransactionMiddleware; if a view executes a
 query that violates a PostgreSQL constraint, an exception isn't thrown
 until the transaction is committed, which is inside the middleware, and so
 my exception logger can't catch that.

 I have a patch that fixes the issue and doesn't break anything else
 (according to the test suite).  I can't see any downsides of applying
 this, but I may be missing something, so let me know.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.