Re: [Django] #16433: Missing 'help_text' in admin form when showing the back reference for a OneToOne field.

[Django]

#16433: Missing 'help_text' in admin form when showing the back reference for a
OneToOne field.
---+
 Reporter:  chris@…|Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by Tim Graham ):

 In [changeset:"ef1259342b46cd4b63678a4acddf2a2b631d342c"]:
 {{{
 #!CommitTicketReference repository=""
 revision="ef1259342b46cd4b63678a4acddf2a2b631d342c"
 [1.6.x] Fixed #16433 -- Fixed a help_text/read only field interaction that
 caused an admin crash.

 Thanks chris at cogdon.org for the report and admackin for the patch.

 Backport of af953c45cc from master
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.85d33b81a52ad5d7943d78c4e851a067%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16433: Missing 'help_text' in admin form when showing the back reference for a OneToOne field.

[Django]

#16433: Missing 'help_text' in admin form when showing the back reference for a
OneToOne field.
---+
 Reporter:  chris@…|Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Tim Graham ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"af953c45cc56df28d02675e196eca1b54ce28a43"]:
 {{{
 #!CommitTicketReference repository=""
 revision="af953c45cc56df28d02675e196eca1b54ce28a43"
 Fixed #16433 -- Fixed a help_text/read only field interaction that caused
 an admin crash.

 Thanks chris at cogdon.org for the report and admackin for the patch.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.5c27442967fe6847d04ef86b28940cb2%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16433: Missing 'help_text' in admin form when showing the back reference for a OneToOne field.

[Django]

#16433: Missing 'help_text' in admin form when showing the back reference for a
OneToOne field.
---+
 Reporter:  chris@…|Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by frankoid):

 * cc: frankoid (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.10e75ae3ec5d9c3aeaf5fb4df4fe6e84%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16433: Missing 'help_text' in admin form when showing the back reference for a OneToOne field.

[Django]

#16433: Missing 'help_text' in admin form when showing the back reference for a
OneToOne field.
---+
 Reporter:  chris@…|Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by anonymous):

 In Django v 1.5.1 same Bug

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/074.545166791266d0603e097ed3ed72d874%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16433: Missing 'help_text' in admin form when showing the back reference for a OneToOne field.

[Django]

#16433: Missing 'help_text' in admin form when showing the back reference for a
OneToOne field.
---+
 Reporter:  chris@…|Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by net147):

 * cc: net147 (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16433: Missing 'help_text' in admin form when showing the back reference for a OneToOne field.

[Django]

#16433: Missing 'help_text' in admin form when showing the back reference for a
OneToOne field.
---+
 Reporter:  chris@…|Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  SVN
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by gcc):

 Please can we make help_text_for_field() a method of AdminReadonlyField
 instead of a static helper method, so that we can override it without
 monkey-patching?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16433: Missing 'help_text' in admin form when showing the back reference for a OneToOne field.

[Django]

#16433: Missing 'help_text' in admin form when showing the back reference for a
OneToOne field.
---+
 Reporter:  chris@…|Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  SVN
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by admackin):

 * needs_tests:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16433: Missing 'help_text' in admin form when showing the back reference for a OneToOne field.

[Django]

#16433: Missing 'help_text' in admin form when showing the back reference for a
OneToOne field.
---+
 Reporter:  chris@…|Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  SVN
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by admackin):

 The test case I've supplied here covers the ManyToMany case.

 However, I'm not sure if my fix is treating the symptom instead of the
 cause.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16433: Missing 'help_text' in admin form when showing the back reference for a OneToOne field.

[Django]

#16433: Missing 'help_text' in admin form when showing the back reference for a
OneToOne field.
---+
 Reporter:  chris@…|Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  SVN
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by admackin):

 * cc: admackin+django@… (added)


Comment:

 The same problem occurs for ManyToMany fields (for the backwards
 reference), but only if the `related_name` attribute is used.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16433: Missing 'help_text' in admin form when showing the back reference for a OneToOne field.

[Django]

#16433: Missing 'help_text' in admin form when showing the back reference for a
OneToOne field.
---+
 Reporter:  chris@…|Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  SVN
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by claudep):

 * needs_tests:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16433: Missing 'help_text' in admin form when showing the back reference for a OneToOne field.

[Django]

#16433: Missing 'help_text' in admin form when showing the back reference for a
OneToOne field.
---+
 Reporter:  chris@…|Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  SVN
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by admackin@…):

 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16433: Missing 'help_text' in admin form when showing the back reference for a OneToOne field.

[Django]

#16433: Missing 'help_text' in admin form when showing the back reference for a
OneToOne field.
+---
   Reporter:  chris@…   |  Owner:  nobody
   Type:  Bug   | Status:  new
  Milestone:|  Component:  contrib.admin
Version:  SVN   |   Severity:  Normal
 Resolution:|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+---
Changes (by aaugustin):

 * needs_better_patch:   => 0
 * needs_docs:   => 0
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #16433: Missing 'help_text' in admin form when showing the back reference for a OneToOne field.

[Django]

#16433: Missing 'help_text' in admin form when showing the back reference for a
OneToOne field.
-+---
 Reporter:  chris@…  |  Owner:  nobody
 Type:  Bug  | Status:  new
Milestone:   |  Component:  contrib.admin
  Version:  SVN  |   Severity:  Normal
 Keywords:   |   Triage Stage:  Unreviewed
Has patch:  0|  Easy pickings:  0
UI/UX:  0|
-+---
 I'm receiving the following exception in the admin pages for a particular
 construct:


 {{{
 Caught AttributeError while rendering: 'RelatedObject' object has no
 attribute 'help_text'
 }}}


 Here's the pastebin for the full exception: http://dpaste.com/564587/

 The problem, I believe, is that help_text is missing for the admin screens
 when attempting to show a "read only" field of an object that was
 automatically generated from a OneToOneField.

 Here's a reduced form of the models and admin pages that cause the error.
 The application is an art show management software, that has artists,
 pieces, invoices, and a class called "invoice item" that will attach a
 piece to an invoice with a price associated. A piece doesnt have a "sale
 price" until it gets attached to an invoice, a piece can only be on one
 invoice, but an invoice can have many pieces:


 {{{
 class Piece ( models.Model ):
 # most detail omitted
 name = models.CharField ( max_length = 100 )

 class Invoice ( models.Model ):
 # most detail omitted
 total_paid = models.DecimalField ( max_digits=7, decimal_places=2,
 blank=True, null=True )

 class InvoiceItem ( models.Model ):
 piece = models.OneToOneField ( Piece )
 invoice = models.ForeignKey ( Invoice )
 price = models.DecimalField ( max_digits=7, decimal_places=2 )
 def __unicode__ ( self ):
 return "%s for $%s" % ( self.invoice, self.price )
 }}}


 then in admin.py:


 {{{
 class PieceAdmin ( admin.ModelAdmin ):
 # most detail omitted
 fields = ( 'artist', 'pieceid', 'name', 'location', 'not_for_sale',
 'adult', 'min_bid', 'buy_now', 'voice_auction', 'bidsheet_scanned',
 'status', 'top_bid', 'invoiceitem' )
 readonly_fields = ( 'top_bid', 'invoiceitem' )
 }}}


 Most of the "fields" relate to fields that were omitted in the models
 above, or are methods of the PieceAdmin class. Of note is the
 'invoiceitem' field. This is a field automatically generated for a Piece
 because of the OneToOneField field on InvoiceItem. Having this as a
 "readonly_fields" makes it available to the model (that seems to be a
 requirement), however, the presence of this at all generates the above
 exception. This code _did_ work in 1.3. I suspect that help_text is new
 for 1.4, but not all possible combinations of this or that have had the
 help_text added. The above is a bit of a corner-case, I know :)

 I can probably work around this bug by creating an invoiceitem method (in
 much the same way I created a top_bid method).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.