Re: [Django] #16501: validators.py don't like unicode slug

[Django]

#16501: validators.py don't like unicode slug
---+
 Reporter:  norn   |Owner:  pbnan
 Type:  New feature|   Status:  new
Component:  Core (Other)   |  Version:  1.3
 Severity:  Normal |   Resolution:
 Keywords:  unicode, slug  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+

Comment (by timgraham):

 Well, I realized that 3rd approach is more or less the same as the PR
 linked in comment 16.

 I created a [https://groups.google.com/d/topic/django-
 developers/Ic2hH3AWdUg/discussion django-developers thread] to get
 feedback on the two approaches.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.c157b8e48db0e36afe7ac471729e7591%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #16501: validators.py don't like unicode slug

[Django]

#16501: validators.py don't like unicode slug
---+
 Reporter:  norn   |Owner:  pbnan
 Type:  New feature|   Status:  new
Component:  Core (Other)   |  Version:  1.3
 Severity:  Normal |   Resolution:
 Keywords:  unicode, slug  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+

Comment (by timgraham):

 An alternate approach suggested by Claude on the mailing list was to
 "create a new `validate_uslug` validator (better name anyone?) and allow a
 custom validator to be passed to the SlugField constructor." We need
 someone to compare these three approaches (at least) and find a consensus
 on the DevelopersMailingList in order to move this issue forward.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.90aebaed73ac905b97730e268ecb4936%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #16501: validators.py don't like unicode slug

[Django]

#16501: validators.py don't like unicode slug
---+
 Reporter:  norn   |Owner:  pbnan
 Type:  New feature|   Status:  new
Component:  Core (Other)   |  Version:  1.3
 Severity:  Normal |   Resolution:
 Keywords:  unicode, slug  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+

Comment (by fcurella):

 I've created an alternative pul request that adds
 `db.models.UnicodeSlugField` and `forms.UnicodeSlugField`
 https://github.com/django/django/pull/1987

 On one hand, I like the new field approach because it gives us an easier
 upgrade path. On the other hand, it feels like I'm polluting
 `django.db.models` and `django.forms` with slightly different versions of
 something that's already there.

 Unfortunately, just passing a regex argument (as suggested by Jacob) is
 not going to be enough, because we'll also have to pass an error message
 string for the validator.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.0304da3644c2f1d6b708230cfa894632%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16501: validators.py don't like unicode slug

[Django]

#16501: validators.py don't like unicode slug
---+
 Reporter:  norn   |Owner:  pbnan
 Type:  New feature|   Status:  new
Component:  Core (Other)   |  Version:  1.3
 Severity:  Normal |   Resolution:
 Keywords:  unicode, slug  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+

Comment (by fcurella):

 I've wrote a patch adding a ``unicode`` option for SlugField. Pull Request
 is at https://github.com/django/django/pull/1979

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.853030212368edebdc4b2f6394033b82%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16501: validators.py don't like unicode slug

[Django]

#16501: validators.py don't like unicode slug
---+
 Reporter:  norn   |Owner:  pbnan
 Type:  New feature|   Status:  new
Component:  Core (Other)   |  Version:  1.3
 Severity:  Normal |   Resolution:
 Keywords:  unicode, slug  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+

Comment (by slikts):

 One of the requirements in my app is that I need to have non-English slugs
 for use in URLs. This should pose no problem, since modern browsers
 support Unicode in URLs, and Django is a framework that supports modern
 practices as well, right? So I try to do it, but find out that `SlugField`
 only works with ASCII by default. This is mildly annoying, but not really
 a problem, since you can just extend `SlugField`, yes? So I look up the
 source for `SlugField` and modify the validator regexp like this:

 {{{
 slug_re = re.compile(r'^[-\w_]+$', re.UNICODE)
 validate_slug = RegexValidator(slug_re, "Enter a valid name consisting of
 letters, numbers, underscores or hyphens.", 'invalid')


 class SlugField(models.SlugField):
 default_validators = [validate_slug]
 }}}

 As it turns out, it just doesn't work, Unicode alphanumerical characters
 are still rejected as invalid, and I have not the slightest idea why. A
 workaround I found was extending directly from `CharField`, but having to
 completely reimplement Django functionality just because I want to use
 more than ASCII not very nice at all.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/062.da62881db7ced4d6cd42897a25a339eb%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16501: validators.py don't like unicode slug

[Django]

#16501: validators.py don't like unicode slug
---+
 Reporter:  norn   |Owner:  pbnan
 Type:  New feature|   Status:  new
Component:  Core (Other)   |  Version:  1.3
 Severity:  Normal |   Resolution:
 Keywords:  unicode, slug  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  1
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+
Changes (by FrankBie):

 * needs_better_patch:  0 => 1
 * needs_docs:  0 => 1


Comment:

 I would propose to add a UnicodeSlugField instead of introducing an
 incompatible change, thats why I would propose a patch needs update.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16501: validators.py don't like unicode slug

[Django]

#16501: validators.py don't like unicode slug
---+
 Reporter:  norn   |Owner:  pbnan
 Type:  New feature|   Status:  reopened
Component:  Core (Other)   |  Version:  1.3
 Severity:  Normal |   Resolution:
 Keywords:  unicode, slug  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by PaulM):

 * stage:  Ready for checkin => Accepted


Comment:

 I'm bumping this back out of RFC. While I agree wholeheartedly that we
 need to allow users to choose unicode slugs if they so desire, we can't
 just arbitrarily change the way this works. Many developers depend on the
 promise that the slug is ASCII. Arbitrarily switching to allow unicode
 characters will produce bugs in previously stable code, and may introduce
 security vulnerabilities.

 Django's backwards compatibility policy requires that features like this
 continue to work as documented. Before this patch is ready to commit, the
 patch must be re-worked so that the default slug behavior of reducing to
 ASCII remains. Whether or not the default behavior should change at some
 point in the future (1.5 or 1.6) is a matter that should be discussed on
 the django-dev list.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16501: validators.py don't like unicode slug

[Django]

#16501: validators.py don't like unicode slug
-+-
 Reporter:  norn |Owner:  pbnan
 Type:  New feature  |   Status:  reopened
Component:  Core (Other) |  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:  unicode, slug| Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by kwadrat):

 * cc: kwadrat (added)
 * stage:  Accepted => Ready for checkin


Comment:

 Reviewed - ready for checkin.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16501: validators.py don't like unicode slug

[Django]

#16501: validators.py don't like unicode slug
---+
 Reporter:  norn   |Owner:  pbnan
 Type:  New feature|   Status:  reopened
Component:  Core (Other)   |  Version:  1.3
 Severity:  Normal |   Resolution:
 Keywords:  unicode, slug  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by pbnan):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Closed accidentally, sorry.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16501: validators.py don't like unicode slug

[Django]

#16501: validators.py don't like unicode slug
---+
 Reporter:  norn   |Owner:  pbnan
 Type:  New feature|   Status:  closed
Component:  Core (Other)   |  Version:  1.3
 Severity:  Normal |   Resolution:  fixed
 Keywords:  unicode, slug  | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by pbnan):

 * status:  assigned => closed
 * resolution:   => fixed
 * has_patch:  0 => 1
 * type:  Bug => New feature


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16501: validators.py don't like unicode slug

[Django]

#16501: validators.py don't like unicode slug
---+
 Reporter:  norn   |Owner:  pbnan
 Type:  Bug|   Status:  assigned
Component:  Core (Other)   |  Version:  1.3
 Severity:  Normal |   Resolution:
 Keywords:  unicode, slug  | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by pbnan):

 * owner:  nobody => pbnan
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16501: validators.py don't like unicode slug

[Django]

#16501: validators.py don't like unicode slug
+---
   Reporter:  norn  |  Owner:  nobody
   Type:  Bug   | Status:  new
  Milestone:|  Component:  Core (Other)
Version:  1.3   |   Severity:  Normal
 Resolution:|   Keywords:  unicode, slug
   Triage Stage:  Accepted  |  Has patch:  0
Needs documentation:  0 |Needs tests:  0
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+---
Changes (by jacob):

 * stage:  Design decision needed => Accepted


Comment:

 Marking accepted: `SlugField` should be useful in most of the world, not
 just the English-speaking parts.

 (`SlugField` probably should take a `regex` argument so people could
 easily change the concept of what a "slug" is. But that's another ticket
 :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16501: validators.py don't like unicode slug

[Django]

#16501: validators.py don't like unicode slug
-+-
   Reporter:  norn   |  Owner:  nobody
   Type:  Bug| Status:  new
  Milestone: |  Component:  Core (Other)
Version:  1.3|   Severity:  Normal
 Resolution: |   Keywords:  unicode, slug
   Triage Stage:  Design |  Has patch:  0
  decision needed|Needs tests:  0
Needs documentation:  0  |  Easy pickings:  0
Patch needs improvement:  0  |
  UI/UX:  0  |
-+-

Comment (by aaugustin):

 Regarding browser support, the current consensus (per a recent discussion
 on the mailing list) is to drop IE6 and start at IE7 — released in 2006.
 We have to live with the fact that many developers use Django to create
 websites for end users that aren't on the cutting edge of technology :)

 In my opinion, the real issue here isn't the date of the RFC. It's the
 support in mainstream browsers (IE, Firefox, Chrome, and to a lesser
 extent Safari, Opera). I don't know if the RFC was actually implemented in
 these browsers, and when — many RFCs die unimplemented... That why I
 suggested that, if someone is interested in this, the first step is to
 prove that it works correctly in IE >= 7, Firefox >= 3, and the latest
 Chrome, Safari and Opera.

 Then, there's still the question of whether the percent-encoded version is
 more readable than the ASCII version, but that's a matter of taste, and
 I'm not the one who makes these decisions :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16501: validators.py don't like unicode slug

[Django]

#16501: validators.py don't like unicode slug
-+-
   Reporter:  norn   |  Owner:  nobody
   Type:  Bug| Status:  new
  Milestone: |  Component:  Core (Other)
Version:  1.3|   Severity:  Normal
 Resolution: |   Keywords:  unicode, slug
   Triage Stage:  Design |  Has patch:  0
  decision needed|Needs tests:  0
Needs documentation:  0  |  Easy pickings:  0
Patch needs improvement:  0  |
  UI/UX:  0  |
-+-
Changes (by aaugustin):

 * stage:  Unreviewed => Design decision needed


Comment:

 Replying to [comment:2 anonymous]:
 > The world is not english speaking only.

 Sure — as a native speaker of a language that uses accents heavily, I
 agree completely :)

 [[BR]]

 > Why do we have to do some magic instead of using out-of-the-box
 functionality?

 Well, if you don't like the out-of-the-box functionality that everyone
 else uses, it sounds reasonable to write you own variant. There's hardly
 any magic in my suggestion.

 

 Replying to [comment:3 justinlilly]:
 > Non-ASCII letters are completely valid in URL schemes.

 Yes, since RFC 3986, it's possible to use non-ASCII characters in URLs
 without ambiguities: the charset must be UTF-8.

 That RFC was published is 2005. Browser vendors may not have changed it
 immediately (historically, most browsers defaulted to latin1 in western
 languages), and some people still use browsers from a few years ago. I
 don't know exactly what's the current status. We need to check how
 mainstream browsers react to an URL like "http://localhost/how-to-brew-
 café/" before proceeding: do they properly utf-8-encode and percent-encode
 it?

 [[BR]]

 > The whole point of a slug isn't to contain ASCII letters. It is merely
 to provide a human-readable URL entry. There are plenty of humans who read
 outside of ASCII.

 I'm a bit confused by this. Django provides a `SlugField` that is designed
 to contain an URL-friendly version of a `CharField`. For instance, the
 title of a blog post could be "How to brew café" (in the `CharField`) and
 the slug would be "how-to-brew-cafe" (in the `SlugField`). If you assume
 that an URL can contain any text, you don't need `SlugField` at all; you
 can just use the original title.

 A drawback is that the actual, correct URL is: http://localhost/how-to-
 brew-caf%C3%A9/. Some browsers may percent-decode and utf-8-decode this to
 display it as: http://localhost/how-to-brew-café/ — I think at least
 Firefox does. I don't know about IE. If it turns out we have to choose
 between http://localhost/how-to-brew-caf%C3%A9/ and http://localhost/how-
 to-brew-cafe/, I think the latter is more readable.

 [[BR]]

 > Also, aaugustin, your tone came off a little combative/hostile. I'm sure
 you didn't mean it that way, but that's how it came out. Just a heads up.

 Thanks for the hint and sorry -- the tone of the original report got a bit
 on my nerves. Comment 2 is great too... :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16501: validators.py don't like unicode slug

[Django]

#16501: validators.py don't like unicode slug
--+---
   Reporter:  norn|  Owner:  nobody
   Type:  Bug | Status:  new
  Milestone:  |  Component:  Core (Other)
Version:  1.3 |   Severity:  Normal
 Resolution:  |   Keywords:  unicode, slug
   Triage Stage:  Unreviewed  |  Has patch:  0
Needs documentation:  0   |Needs tests:  0
Patch needs improvement:  0   |  Easy pickings:  0
  UI/UX:  0   |
--+---

Comment (by justinlilly):

 Non-ASCII letters are completely valid in URL schemes. The whole point of
 a slug isn't to contain ASCII letters. It is merely to provide a human-
 readable URL entry. There are plenty of humans who read outside of ASCII.
 Assuming the fix can be made backwards compatible, I see no reason not to
 have it.

 Also, aaugustin, your tone came off a little combative/hostile. I'm sure
 you didn't mean it that way, but that's how it came out. Just a heads up.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16501: validators.py don't like unicode slug

[Django]

#16501: validators.py don't like unicode slug
--+---
   Reporter:  norn|  Owner:  nobody
   Type:  Bug | Status:  new
  Milestone:  |  Component:  Core (Other)
Version:  1.3 |   Severity:  Normal
 Resolution:  |   Keywords:  unicode, slug
   Triage Stage:  Unreviewed  |  Has patch:  0
Needs documentation:  0   |Needs tests:  0
Patch needs improvement:  0   |  Easy pickings:  0
  UI/UX:  0   |
--+---

Comment (by anonymous):

 The world is not english speaking only.

 Why do we have to do some magic instead of using out-of-the-box
 functionality?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16501: validators.py don't like unicode slug

[Django]

#16501: validators.py don't like unicode slug
--+---
   Reporter:  norn|  Owner:  nobody
   Type:  Bug | Status:  new
  Milestone:  |  Component:  Core (Other)
Version:  1.3 |   Severity:  Normal
 Resolution:  |   Keywords:  unicode, slug
   Triage Stage:  Unreviewed  |  Has patch:  0
Needs documentation:  0   |Needs tests:  0
Patch needs improvement:  0   |  Easy pickings:  0
  UI/UX:  0   |
--+---
Changes (by aaugustin):

 * needs_docs:   => 0
 * easy:  1 => 0
 * needs_tests:   => 0
 * needs_better_patch:   => 0


Comment:

 Congrats, you have found the very best way to piss off the maintainers of
 an open-source project in your first sentence :)

 You may want to read the FAQ:
 https://docs.djangoproject.com/en/1.3/faq/contributing/#faq-contributing-
 code

 A bug won't be fixed if you don't submit a patch:
 https://docs.djangoproject.com/en/dev/internals/contributing/writing-code
 /submitting-patches/

 

 Now, regarding your report, out of the 4 files called `validators.py` in
 Django, I suppose you're referring to the one in `django/core`. You're
 saying that the built-in validator `django.core.validators.validate_slug`
 should accept unicode characters.

 This function is currently documented as:
 > A `RegexValidator` instance that ensures a value consists of only
 letters, numbers, underscores or hyphens.

 We could debate if "letters" means "ASCII letters" or "Unicode characters
 that have some property that says they're a letter". Currently, it means
 "ASCII letters".

 `validate_slug` is used in only one place in Django, as the default
 validator for `SlugField`.

 So, the real problem here is that `SlugField` will only accept ASCII
 letters.

 

 In my opinion, the whole point of a slug is to contain only ASCII
 characters, to make sure URLs built with slugs have no charset issues, no
 matter where they're copy-pasted (URL bars, email, IRC, IM, etc.)

 If the `SlugField` provided by Django doesn't meet your expectations, you
 can easily build your own:
 {{{
 class MyCustomSlugField(CharField):
 default_validators = [my_custom_validate_slug]
 }}}

 I'm leaning towards WONTFIX, but I'd like someone else to confirm my
 analysis before closing the ticket.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #16501: validators.py don't like unicode slug

[Django]

#16501: validators.py don't like unicode slug
---+--
 Reporter:  norn   |  Owner:  nobody
 Type:  Bug| Status:  new
Milestone: |  Component:  Core (Other)
  Version:  1.3|   Severity:  Normal
 Keywords:  unicode, slug  |   Triage Stage:  Unreviewed
Has patch:  0  |  Easy pickings:  1
UI/UX:  0  |
---+--
 I patch every new version of my django installation and wondering why
 nobody fixed this in branch tree.

 The problem is extremely simple - I like to use slug in my native language
 (and google likes the same). To fix the problem we just need to do this in
 validators.py:

 {{{
 slug_re = re.compile(r'^[-\w]+$',flags=re.U)
 }}}

 instead of this

 {{{
 slug_re = re.compile(r'^[-\w]+$')
 }}}

 The solution is simple. And the same we should do with URLValidator.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.