Re: [Django] #16655: Silent error in ModelAdmin.list_display callables...

[Django]

#16655: Silent error in ModelAdmin.list_display callables...
---+
 Reporter:  jedie  |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  contrib.admin  |  Version:  1.3
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by aaugustin):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 Fixed in [617d077f].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #16655: Silent error in ModelAdmin.list_display callables...

[Django]

#16655: Silent error in ModelAdmin.list_display callables...
---+
 Reporter:  jedie  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  1.3
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by aaugustin):

 * needs_tests:  1 => 0


Comment:

 Now there's a pull request with tests (from #18593):
 https://github.com/django/django/pull/193

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16655: Silent error in ModelAdmin.list_display callables...

[Django]

#16655: Silent error in ModelAdmin.list_display callables...
---+
 Reporter:  jedie  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  1.3
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by pjdelport):

 I found this ticket after independently running into and submitting a fix
 for this bug: see #18593.

 The patch is almost the same, but includes a test, and fixes
 `callable_year()` to be more in line with `model_year()` and
 `modeladmin_year()`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16655: Silent error in ModelAdmin.list_display callables...

[Django]

#16655: Silent error in ModelAdmin.list_display callables...
---+
 Reporter:  jedie  |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  1.3
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by frank.harper@…):

 I just started learning Django using version 1.3.1, and got bitten by this
 bug.

 I think the fix really should be a high priority because the tutorial
 (very well done BTW), starts out with models and Admin mode. By definition
 beginners will be making a lot of mistakes that can cause AttributeError,
 and because of this bug they will have no feedback whatsoever about what
 is wrong. This makes for a very bad learning experience.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16655: Silent error in ModelAdmin.list_display callables...

[Django]

#16655: Silent error in ModelAdmin.list_display callables...
+---
   Reporter:  jedie |  Owner:  nobody
   Type:  Bug   | Status:  new
  Milestone:|  Component:  contrib.admin
Version:  1.3   |   Severity:  Normal
 Resolution:|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  1
Needs documentation:  0 |Needs tests:  1
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+---

Comment (by jedie):

 Replying to [comment:2 aaugustin]:
 > Finally, regarding the test that seems wrong to you, could you open a
 separate ticket?

 IMHO the two things are related. Both should be changed together, isn't
 it?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16655: Silent error in ModelAdmin.list_display callables...

[Django]

#16655: Silent error in ModelAdmin.list_display callables...
+---
   Reporter:  jedie |  Owner:  nobody
   Type:  Bug   | Status:  new
  Milestone:|  Component:  contrib.admin
Version:  1.3   |   Severity:  Normal
 Resolution:|   Keywords:
   Triage Stage:  Accepted  |  Has patch:  1
Needs documentation:  0 |Needs tests:  1
Patch needs improvement:  0 |  Easy pickings:  0
  UI/UX:  0 |
+---
Changes (by aaugustin):

 * needs_tests:  0 => 1
 * stage:  Design decision needed => Accepted


Comment:

 I reached Alex on IRC, he doesn't have a strong opinion on this ticket,
 besides the fact that it "needs more comprehensive tests for starters".

 We've done a decent effort and found no reason to catch !AttributeError.
 Let's consider it a bug.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16655: Silent error in ModelAdmin.list_display callables...

[Django]

#16655: Silent error in ModelAdmin.list_display callables...
-+-
   Reporter:  jedie  |  Owner:  nobody
   Type:  Bug| Status:  new
  Milestone: |  Component:  contrib.admin
Version:  1.3|   Severity:  Normal
 Resolution: |   Keywords:
   Triage Stage:  Design |  Has patch:  1
  decision needed|Needs tests:  0
Needs documentation:  0  |  Easy pickings:  0
Patch needs improvement:  0  |
  UI/UX:  0  |
-+-
Changes (by aaugustin):

 * stage:  Unreviewed => Design decision needed


Comment:

 This code was introduced as part of r11965 (read-only fields in the
 admin). It catches !AttributeError explicitly, and it certainly does so
 for a reason (or at least it did at the time it was written).
 Unfortunately, after some investigation, I can't figure out that reason.

 Note that if someone has a callable in `list_display` that sometimes
 raises !AttributeError, currently this is silently ignored, but with your
 patch it will crash the admin. It is possible to break backwards
 compatibility to fix bugs, but we should just be extra careful and make
 sure your proposal is really the right thing to do. I don't feel we have
 enough information right now.

 Finally, regarding the test that seems wrong to you, could you open a
 separate ticket?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16655: Silent error in ModelAdmin.list_display callables...

[Django]

#16655: Silent error in ModelAdmin.list_display callables...
--+---
   Reporter:  jedie   |  Owner:  nobody
   Type:  Bug | Status:  new
  Milestone:  |  Component:  contrib.admin
Version:  1.3 |   Severity:  Normal
 Resolution:  |   Keywords:
   Triage Stage:  Unreviewed  |  Has patch:  1
Needs documentation:  0   |Needs tests:  0
Patch needs improvement:  0   |  Easy pickings:  0
  UI/UX:  0   |
--+---
Changes (by jedie):

 * needs_better_patch:   => 0
 * has_patch:  0 => 1
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 Is probably only !AttributeError, catch here:
 
https://code.djangoproject.com/browser/django/trunk/django/contrib/admin/templatetags/admin_list.py#L168

 Seems that one unittests is wrong, isn't it? I correct this in the patch.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #16655: Silent error in ModelAdmin.list_display callables...

[Django]

#16655: Silent error in ModelAdmin.list_display callables...
---+---
 Reporter:  jedie  |  Owner:  nobody
 Type:  Bug| Status:  new
Milestone: |  Component:  contrib.admin
  Version:  1.3|   Severity:  Normal
 Keywords: |   Triage Stage:  Unreviewed
Has patch:  0  |  Easy pickings:  0
UI/UX:  0  |
---+---
 Errors in
 
[https://docs.djangoproject.com/en/1.3/ref/contrib/admin/#django.contrib.admin.ModelAdmin.list_display
 ModelAdmin.list_display callables] would be ignored.

 I suspect not only a '''!AttributeError'''.

 Example:
 {{{#!python
 class FooAdmin(admin.ModelAdmin):
 list_display = ('foobar',)

 def foobar(self, obj):
   raise AttributeError # ignored!
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.