Re: [Django] #16812: FieldsTests.test_urlfield_10 fails since r16760

[Django]

#16812: FieldsTests.test_urlfield_10 fails since r16760
-+
 Reporter:  aaugustin|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Forms|  Version:  SVN
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by aaugustin):

 In [17803]:
 {{{
 #!CommitTicketReference repository="" revision="17803"
 [1.3.X] Fixed #16812 -- Percent-encode URLs in verify_exists, to fix test
 failures on Python 2.5 and 2.6. Backport of r16838 from trunk.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16812: FieldsTests.test_urlfield_10 fails since r16760

[Django]

#16812: FieldsTests.test_urlfield_10 fails since r16760
-+
 Reporter:  aaugustin|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  Forms|  Version:  SVN
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by loewis):

 In [16950]:
 {{{
 #!CommitTicketReference repository="" revision="16950"
 Merged revisions
 
16743,16745,16747-16750,16752-16754,16756-16760,16770,16773-16800,16802-16804,16806,16808,16811,16813,16815,16817-16826,16829-16833,16835-16836,16838-16843,16845-16858,16860-16866,16868,16871-16877,16882-16890,16893-16947
 via svnmerge from
 https://code.djangoproject.com/svn/django/trunk

 
   r16743 | gabrielhurley | 2011-09-09 23:36:58 +0200 (Fr, 09 Sep 2011) | 2
 lines

   Fixed #16791 -- Updated a broken URL in the README file. Thanks to
 paulcwatts for the report and patch.
 
   r16745 | Alex | 2011-09-09 23:45:58 +0200 (Fr, 09 Sep 2011) | 1 line

   Switch to using explicit new-style division behavior, rather than
 relying on teh classic behavior.
 
   r16747 | SmileyChris | 2011-09-10 00:32:38 +0200 (Sa, 10 Sep 2011) | 1
 line

   Fix and test for cleaning a non-string value in a URLField
 
   r16748 | gabrielhurley | 2011-09-10 00:33:28 +0200 (Sa, 10 Sep 2011) | 2
 lines

   Fixed #16786 -- Minor cleanups in the memcached section of the caching
 topic guide. Thanks to jamesp for the report and patch.
 
   r16749 | jbronn | 2011-09-10 00:34:23 +0200 (Sa, 10 Sep 2011) | 1 line

   Fixed #16408 -- Fixed conversion of dates, and other problems with the
 SpatiaLite backend.
 
   r16750 | jbronn | 2011-09-10 00:47:18 +0200 (Sa, 10 Sep 2011) | 1 line

   Removed extra call to `syncdb` that slipped in with r16749.
 
   r16752 | SmileyChris | 2011-09-10 00:57:12 +0200 (Sa, 10 Sep 2011) | 1
 line

   Fixes #16664 -- URLField's to_python method fails with ValueError on
 some urls on python 2.7. Based on patch by zigzag.
 
   r16753 | russellm | 2011-09-10 01:02:33 +0200 (Sa, 10 Sep 2011) | 1 line

   Added two pointless query repeats to work around a known issue with
 MySQL that was causing failures in our test suite.
 
   r16754 | gabrielhurley | 2011-09-10 01:25:48 +0200 (Sa, 10 Sep 2011) | 2
 lines

   Fixed #16782 -- Corrected a broken cross-reference to the database
 engine setting in the tutorial. Thanks to mjumbewu for the report and
 patch.
 
   r16756 | kmtracey | 2011-09-10 02:05:48 +0200 (Sa, 10 Sep 2011) | 2
 lines

   Fixed #15722: ensure formsets evaluate to True even if they have no
 forms. Thanks mlavin.
 
   r16757 | jbronn | 2011-09-10 02:29:34 +0200 (Sa, 10 Sep 2011) | 1 line

   Fixed #13670 -- Comparisons with the spatial adapter won't blow up in
 some corner cases.  Thanks, milosu for the bug report and jpaulett for the
 patch.
 
   r16758 | russellm | 2011-09-10 02:46:38 +0200 (Sa, 10 Sep 2011) | 1 line

   Added protection against spoofing of X_FORWARDED_HOST headers. A
 security announcement will be made shortly.
 
   r16759 | russellm | 2011-09-10 02:46:48 +0200 (Sa, 10 Sep 2011) | 1 line

   Corrected an issue which could allow attackers to manipulate session
 data using the cache. A security announcement will be made shortly.
 
   r16760 | russellm | 2011-09-10 02:47:00 +0200 (Sa, 10 Sep 2011) | 1 line

   Altered the behavior of URLField to avoid a potential DOS vector, and to
 avoid potential leakage of local filesystem data. A security announcement
 will be made shortly.
 
   r16770 | Alex | 2011-09-10 03:53:56 +0200 (Sa, 10 Sep 2011) | 1 line

   Make ``Formset.__getitem__`` O(1), rather than O(n).  If you override
 ``__iter__`` you now need to also override ``__getitem__`` for consistant
 behavior.  Thanks to Carl and Russ for the review.
 
   r16773 | Alex | 2011-09-10 04:42:05 +0200 (Sa, 10 Sep 2011) | 1 line

   Fixed #11404.  Added ``FormSet.has_changed``, for consistancy with
 ``Form.has_changed``. Thanks to michelts for the patch.
 
   r16774 | Alex | 2011-09-10 04:52:37 +0200 (Sa, 10 Sep 2011) | 1 line

   Fixed #16793. Added more cross referencing to the load tag's
 documentation.  Thanks to bluejeansummer for the patch.
 
   r16775 | jbronn | 2011-09-10 05:04:30 +0200 (Sa, 10 Sep 2011) | 1 line

   Fixed #16790 -- Modified the geographic admin to work after r16594.
 Thanks, jdiego, for the bug report and patch.
 
   r16776 | carljm | 2011-09-10 05:26:13 +0200 (Sa, 10 Sep 2011) | 1 

Re: [Django] #16812: FieldsTests.test_urlfield_10 fails since r16760

[Django]

#16812: FieldsTests.test_urlfield_10 fails since r16760
-+-
   Reporter:  aaugustin  |  Owner:  nobody
   Type:  Bug| Status:  closed
  Milestone: |  Component:  Forms
Version:  SVN|   Severity:  Release blocker
 Resolution:  fixed  |   Keywords:
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
Changes (by carljm):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [16838]:
 {{{
 #!CommitTicketReference repository="" revision="16838"
 Fixed #16812 -- Percent-encode URLs in verify_exists, to fix test failures
 on Python 2.5 and 2.6.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16812: FieldsTests.test_urlfield_10 fails since r16760

[Django]

#16812: FieldsTests.test_urlfield_10 fails since r16760
-+-
   Reporter:  aaugustin  |  Owner:  nobody
   Type:  Bug| Status:  new
  Milestone: |  Component:  Forms
Version:  SVN|   Severity:  Release blocker
 Resolution: |   Keywords:
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
Changes (by aaugustin):

 * needs_better_patch:  1 => 0


Comment:

 A quick search turns up: http://en.wikipedia.org/wiki/Percent-
 encoding#Current_standard:
 > The generic URI syntax mandates that new URI schemes that provide for
 the representation of character data in a URI must, in effect, represent
 characters from the unreserved set without translation, and should convert
 all other characters to bytes according to UTF-8, and then percent-encode
 those values. This requirement was introduced in January 2005 with the
 publication of RFC 3986. URI schemes introduced before this date are not
 affected.

 

 New patch implements this.

 Note that this piece of code will be removed in Django 1.5, I'd be OK with
 just skipping the test on Python < 2.7.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16812: FieldsTests.test_urlfield_10 fails since r16760

[Django]

#16812: FieldsTests.test_urlfield_10 fails since r16760
-+-
   Reporter:  aaugustin  |  Owner:  nobody
   Type:  Bug| Status:  new
  Milestone: |  Component:  Forms
Version:  SVN|   Severity:  Release blocker
 Resolution: |   Keywords:
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  1  |  Easy pickings:  0
  UI/UX:  0  |
-+-
Changes (by aaugustin):

 * needs_better_patch:  0 => 1


Comment:

 Note that this probably isn't a perfect way to quote an URL (I haven't
 checked the RFC yet).

 Other components should be quoted too, but with some exclusions. For
 instance, don't quote `&` and `=` in `query`: `query = urllib.quote(query,
 '&=')`.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16812: FieldsTests.test_urlfield_10 fails since r16760

[Django]

#16812: FieldsTests.test_urlfield_10 fails since r16760
-+-
   Reporter:  aaugustin  |  Owner:  nobody
   Type:  Bug| Status:  new
  Milestone: |  Component:  Forms
Version:  SVN|   Severity:  Release blocker
 Resolution: |   Keywords:
   Triage Stage:  Accepted   |  Has patch:  1
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
Changes (by aaugustin):

 * has_patch:  0 => 1


Comment:

 Django masks the exception, to get the original traceback you can edit
 `django/core/validators.py` as follows:
 {{{
 Index: django/core/validators.py
 ===
 --- django/core/validators.py   (révision 16831)
 +++ django/core/validators.py   (copie de travail)
 @@ -126,6 +126,7 @@
  else:
  opener.open(req)
  except ValueError:
 +raise
  raise ValidationError(_(u'Enter a valid URL.'),
 code='invalid')
  except: # urllib2.URLError, httplib.InvalidURL, etc.
  raise broken_error
 }}}

 Django converts unicode `url` to `utf-8`, which is correct. However, it
 doesn't URLencode it. At least the path should be urlencoded. Attached
 patch works under python 2.5. 2.6 and 2.7.

 Since this fixes a broken test, it doesn't need an additional test.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16812: FieldsTests.test_urlfield_10 fails since r16760

[Django]

#16812: FieldsTests.test_urlfield_10 fails since r16760
-+-
   Reporter:  aaugustin  |  Owner:  nobody
   Type:  Bug| Status:  new
  Milestone: |  Component:  Forms
Version:  SVN|   Severity:  Release blocker
 Resolution: |   Keywords:
   Triage Stage:  Accepted   |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-

Comment (by apollo13):

 > Here's what I get under OS X Lion, with Python from Mac Ports

 Can't see it under 10.6 with python2.5 or python2.6 from macports.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #16812: FieldsTests.test_urlfield_10 fails since r16760

[Django]

#16812: FieldsTests.test_urlfield_10 fails since r16760
-+-
   Reporter:  aaugustin  |  Owner:  nobody
   Type:  Bug| Status:  new
  Milestone: |  Component:  Forms
Version:  SVN|   Severity:  Release blocker
 Resolution: |   Keywords:
   Triage Stage:  Accepted   |  Has patch:  0
Needs documentation:  0  |Needs tests:  0
Patch needs improvement:  0  |  Easy pickings:  0
  UI/UX:  0  |
-+-
Changes (by julien):

 * stage:  Unreviewed => Accepted


Comment:

 Yes, I can confirm that this error appears on my CI server too (Ubuntu
 10.04.2 LTS with Python 2.6).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #16812: FieldsTests.test_urlfield_10 fails since r16760

[Django]

#16812: FieldsTests.test_urlfield_10 fails since r16760
---+---
 Reporter:  aaugustin  |Owner:  nobody
 Type:  Bug|   Status:  new
Milestone: |Component:  Forms
  Version:  SVN| Severity:  Release blocker
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+---
 This failure happen in Python 2.5 and 2.6 but it apparently doesn't show
 up on all OSes.

 The CI server reports it:
 *
 
http://ci.djangoproject.com/job/Django/database=sqlite3,python=python2.5/lastCompletedBuild/testReport/regressiontests.forms.tests.fields/FieldsTests/test_urlfield_10/
 *
 
http://ci.djangoproject.com/job/Django/database=sqlite3,python=python2.6/lastCompletedBuild/testReport/regressiontests.forms.tests.fields/FieldsTests/test_urlfield_10/
 *
 
http://ci.djangoproject.com/job/Django/database=sqlite3,python=python2.7/lastCompletedBuild/testReport/regressiontests.forms.tests.fields/FieldsTests/test_urlfield_10/



 Here's what I get under OS X Lion, with Python from Mac Ports:
 {{{

 myk@mYk tests % PYTHONPATH=.. python2.5 runtests.py --settings=test_sqlite
 forms
 ~/Documents/dev/django-trunk/tests
 Creating test database for alias 'default'...
 Creating test database for alias 'other'...
 
...E...
 ==
 ERROR: test_urlfield_10 (regressiontests.forms.tests.fields.FieldsTests)
 --
 Traceback (most recent call last):
   File "/Users/myk/Documents/dev/django-
 trunk/tests/regressiontests/forms/tests/fields.py", line 697, in
 test_urlfield_10
 self.assertEqual(url, f.clean(url))
   File "/Users/myk/Documents/dev/django-trunk/django/forms/fields.py",
 line 153, in clean
 self.run_validators(value)
   File "/Users/myk/Documents/dev/django-trunk/django/forms/fields.py",
 line 142, in run_validators
 raise ValidationError(errors)
 ValidationError: [u'Enter a valid URL.']

 --
 Ran 311 tests in 2.924s

 FAILED (errors=1)
 Destroying test database for alias 'default'...
 Destroying test database for alias 'other'...
 myk@mYk tests % PYTHONPATH=.. python2.6 runtests.py --settings=test_sqlite
 forms
 ~/Documents/dev/django-trunk/tests
 Creating test database for alias 'default'...
 Creating test database for alias 'other'...
 
...E...
 ==
 ERROR: test_urlfield_10 (regressiontests.forms.tests.fields.FieldsTests)
 --
 Traceback (most recent call last):
   File "/Users/myk/Documents/dev/django-
 trunk/tests/regressiontests/forms/tests/fields.py", line 697, in
 test_urlfield_10
 self.assertEqual(url, f.clean(url))
   File "/Users/myk/Documents/dev/django-trunk/django/forms/fields.py",
 line 153, in clean
 self.run_validators(value)
   File "/Users/myk/Documents/dev/django-trunk/django/forms/fields.py",
 line 142, in run_validators
 raise ValidationError(errors)
 ValidationError: [u'Enter a valid URL.']

 --
 Ran 311 tests in 1.941s

 FAILED (errors=1)
 Destroying test database for alias 'default'...
 Destroying test database for alias 'other'...
 myk@mYk tests % PYTHONPATH=.. python2.7 runtests.py --settings=test_sqlite
 forms
 ~/Documents/dev/django-trunk/tests
 Creating test database for alias 'default'...
 Creating test database for alias 'other'...
 
...
 --
 Ran 311 tests in 2.666s

 OK
 Destroying test database for alias