Re: [Django] #17066: Exception TypeError when using GeoIP

2013-02-15 Thread Django 
#17066: Exception TypeError when using GeoIP
+-
 Reporter:  mitar   |Owner:  nobody
 Type:  Bug |   Status:  closed
Component:  GIS |  Version:  1.4
 Severity:  Normal  |   Resolution:  fixed
 Keywords:  | Triage Stage:  Ready for checkin
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+-
Changes (by Claude Paroz ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"35185495e3f70f900b542bf95d744f51e5c5cb92"]:
 {{{
 #!CommitTicketReference repository=""
 revision="35185495e3f70f900b542bf95d744f51e5c5cb92"
 Fixed #17066 -- Prevented TypeError in GeoIP.__del__

 When garbaging GeoIP instances, it happens that GeoIP_delete is
 already None.
 Thanks mitar for the report and stefanw for tests.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #17066: Exception TypeError when using GeoIP

2013-02-11 Thread Django 
#17066: Exception TypeError when using GeoIP
+-
 Reporter:  mitar   |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  GIS |  Version:  1.4
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Ready for checkin
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+-
Changes (by claudep):

 * stage:  Accepted => Ready for checkin


Comment:

 Thanks for the research on that issue. I guess that we might have
 difficulties to come with a test for this, so I suggest to simply add the
 `if GeoIP_delete is None` safeguard, and call it a day!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #17066: Exception TypeError when using GeoIP

2013-02-11 Thread Django 
#17066: Exception TypeError when using GeoIP
+
 Reporter:  mitar   |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  GIS |  Version:  1.4
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by stefanw):

 * status:  closed => new
 * cc: stefanw (added)
 * resolution:  needsinfo =>


Comment:

 I can confirm this on Django 1.4.3 with geoip 1.4.8.

 I attached a test project that should reproduce this error. Instructions:
 Extract, install requirements (Django==1.4.3) and run `runtest.sh` which
 downloads GeoIP country data (slightly too big to attach) and then does a
 `syncdb` (any Django command will do).

 The exception should be the last line of the output. The culprit is
 obviously in `django.contrib.gis.geoip.base.GeoIP.__del__` where
 `GeoIP_delete` is None when this method is called.

 Replacing `__del__` with the following removes the exception, but may
 leave file handles lying around (I have no deeper knowledge about that).

 {{{
 def __del__(self):
 # Cleaning any GeoIP file handles lying around.
 if GeoIP_delete is None:
 return
 if self._country: GeoIP_delete(self._country)
 if self._city: GeoIP_delete(self._city)
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #17066: Exception TypeError when using GeoIP

2012-10-06 Thread Django 
#17066: Exception TypeError when using GeoIP
+-
 Reporter:  mitar   |Owner:  nobody
 Type:  Bug |   Status:  closed
Component:  GIS |  Version:  1.4
 Severity:  Normal  |   Resolution:  needsinfo
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+-
Changes (by claudep):

 * status:  new => closed
 * resolution:   => needsinfo


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #17066: Exception TypeError when using GeoIP

2012-09-06 Thread Django 
#17066: Exception TypeError when using GeoIP
+
 Reporter:  mitar   |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  GIS |  Version:  1.4
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+

Comment (by claudep):

 It could be useful if anyone could provide us with a basic project where
 this error can be reproduced.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #17066: Exception TypeError when using GeoIP

2012-09-06 Thread Django 
#17066: Exception TypeError when using GeoIP
+
 Reporter:  mitar   |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  GIS |  Version:  1.4
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by anonymous):

 * version:  1.3 => 1.4


Comment:

 Same here after migrating to Django 1.4.1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #17066: Exception TypeError when using GeoIP

2012-01-05 Thread Django 
#17066: Exception TypeError when using GeoIP
+
 Reporter:  mitar   |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  GIS |  Version:  1.3
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+

Comment (by robbyd):

 +1 I am getting this bug as well. Django 1.3.1

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17066: Exception TypeError when using GeoIP

2011-11-25 Thread Django 
#17066: Exception TypeError when using GeoIP
+
 Reporter:  mitar   |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  GIS |  Version:  1.3
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by aaugustin):

 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17066: Exception TypeError when using GeoIP

2011-10-18 Thread Django 
#17066: Exception TypeError when using GeoIP
+--
 Reporter:  mitar   |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  GIS |  Version:  1.3
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Unreviewed
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+--
Changes (by aaugustin):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 This looks similar to #13488 and #13843.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #17066: Exception TypeError when using GeoIP

2011-10-18 Thread Django 
#17066: Exception TypeError when using GeoIP
+
 Reporter:  mitar   |  Owner:  nobody
 Type:  Bug | Status:  new
Component:  GIS |Version:  1.3
 Severity:  Normal  |   Keywords:
 Triage Stage:  Unreviewed  |  Has patch:  0
Easy pickings:  0   |  UI/UX:  0
+
 When using GeoIP in my code I am getting such error at the end of syncdb
 call:

 {{{
 Exception TypeError: "'NoneType' object is not callable" in > ignored
 }}}

 It seems there is some race condition? I am using Python 2.7.2 on Mac OS
 X. It has threaded support enabled. Django 1.3. python-geoip 1.2.5,
 libgeoip 1.4.7.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.