Re: [Django] #17085: Deprecate "add_to_builtins" and replace with API on Template

[Django]

#17085: Deprecate "add_to_builtins" and replace with API on Template
-+--
 Reporter:  carljm   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Template system  |  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--
Changes (by timgraham):

 * cc: aaugustin (added)
 * status:  closed => new
 * resolution:  duplicate =>
 * stage:  Accepted => Unreviewed


Comment:

 Reopening this since #17093 was closed and `add_to_builtins()` still
 exists so maybe this is worth addressing?

 I came across the issue in trying to test djangoproject.com with Django
 1.8 and saw that [https://github.com/jezdez/django-
 hosts/blob/c12a343473ab8633e09b6bc716b67e0eaafc76e7/django_hosts/apps.py#L23
 django-hosts] isn't compatible as it imports `from django.template import
 add_to_builtins` which is no longer there due to the namespace cleanup.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.e7537d14c8f4d147610bcacfd157c3eb%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #17085: Deprecate "add_to_builtins" and replace with API on Template

[Django]

#17085: Deprecate "add_to_builtins" and replace with API on Template
-+-
 Reporter:  carljm   |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Template system  |  Version:  SVN
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by carljm):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 Closing this as dupe of #17093 since dealing with the add_to_builtins
 problem makes the most sense in the context of that refactor.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17085: Deprecate "add_to_builtins" and replace with API on Template

[Django]

#17085: Deprecate "add_to_builtins" and replace with API on Template
-+
 Reporter:  carljm   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Template system  |  Version:  SVN
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+

Comment (by carljm):

 This ticket was based on the false premise that `add_to_builtins` was
 documented API - I really thought I'd seen it in a corner of the docs
 somewhere. Given that it's not, I think it should just be removed, and we
 don't need to add an API to replace it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17085: Deprecate "add_to_builtins" and replace with API on Template

[Django]

#17085: Deprecate "add_to_builtins" and replace with API on Template
-+
 Reporter:  carljm   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Template system  |  Version:  SVN
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+
Changes (by ptone):

 * stage:  Unreviewed => Accepted


Comment:

 add_to_builtins is not a documented function - but seems to have made it
 into use extensive in the wild.

 its primary use currently in Django is either:

 add the truly global builtin tags and filters in template/base.py

 add template tags into builtin space as a convenience for tests

 the API you propose sounds like a python level alternative to the load
 tag.

 From the context of the template, this is magic and far less explicit than
 using the load tag

 It looks like most of the wild use of add_to_builtins is to provide
 "convenience" by 3rd party apps to make their tags global.  But I would
 say that they should be re-documented as requiring the load tag in the
 users base.html if they want it everywhere

 I think a deprecation of add_to_builtins with a replacement of
 _add_to_builtins could be done to get the message.  But I think we should
 be encouraging more explicitness in the template space, not enabling less.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17085: Deprecate "add_to_builtins" and replace with API on Template (was: Deprecate "add_to_builtins")

[Django]

#17085: Deprecate "add_to_builtins" and replace with API on Template
-+--
 Reporter:  carljm   |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Template system  |  Version:  SVN
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.