Re: [Django] #17228: params context variable from TemplateView is inconsistent with other get_context_data implementations

[Django]

#17228: params context variable from TemplateView is inconsistent with other
get_context_data implementations
--+
 Reporter:  ptone |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Generic views |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Claude Paroz ):

 In [changeset:"5ebd0452ba6ff93980e6f9a8958f6ea01c835ffe"]:
 {{{
 #!CommitTicketReference repository=""
 revision="5ebd0452ba6ff93980e6f9a8958f6ea01c835ffe"
 [1.5.x] Fixed #19714 -- Updated documentation about TemplateView context

 Thanks Aramgutang for the report. Refs #17228.
 Backport of 56e553129 from master.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #17228: params context variable from TemplateView is inconsistent with other get_context_data implementations

[Django]

#17228: params context variable from TemplateView is inconsistent with other
get_context_data implementations
--+
 Reporter:  ptone |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Generic views |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Claude Paroz ):

 In [changeset:"5ebd0452ba6ff93980e6f9a8958f6ea01c835ffe"]:
 {{{
 #!CommitTicketReference repository=""
 revision="5ebd0452ba6ff93980e6f9a8958f6ea01c835ffe"
 [1.5.x] Fixed #19714 -- Updated documentation about TemplateView context

 Thanks Aramgutang for the report. Refs #17228.
 Backport of 56e553129 from master.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #17228: params context variable from TemplateView is inconsistent with other get_context_data implementations

[Django]

#17228: params context variable from TemplateView is inconsistent with other
get_context_data implementations
--+
 Reporter:  ptone |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Generic views |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by Claude Paroz ):

 In [changeset:"56e553129f554f83c8e99ef3368544921dbd8a82"]:
 {{{
 #!CommitTicketReference repository=""
 revision="56e553129f554f83c8e99ef3368544921dbd8a82"
 Fixed #19714 -- Updated documentation about TemplateView context

 Thanks Aramgutang for the report. Refs #17228.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #17228: params context variable from TemplateView is inconsistent with other get_context_data implementations

[Django]

#17228: params context variable from TemplateView is inconsistent with other
get_context_data implementations
--+
 Reporter:  ptone |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  Generic views |  Version:  master
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Andrew Godwin ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [f04bb6d798b07aa5e7c1d99d700fa6ddc7d39e62]:
 {{{
 #!CommitTicketReference repository=""
 revision="f04bb6d798b07aa5e7c1d99d700fa6ddc7d39e62"
 Fixed #17228 -- params context variable is inconsistent

 Remove the params variable from the context and just put the variables
 in directly.

 This had not been committed previously as the original pattern was used
 in the functional generic views and we wanted consistency between them,
 but django.views.generic.simple.direct_to_template is now gone so we can
 do it 'right'.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #17228: params context variable from TemplateView is inconsistent with other get_context_data implementations

[Django]

#17228: params context variable from TemplateView is inconsistent with other
get_context_data implementations
--+
 Reporter:  ptone |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Generic views |  Version:  SVN
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by anonymous):

 see #17381 for some related discussion

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17228: params context variable from TemplateView is inconsistent with other get_context_data implementations

[Django]

#17228: params context variable from TemplateView is inconsistent with other
get_context_data implementations
--+
 Reporter:  ptone |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Generic views |  Version:  SVN
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by ptone):

 I have inadvertently essentially duplicated this issue in #17381 however
 there is a subtle difference.

 My greater gripe is with taking all kwargs to get_context_data and
 stuffing it into the params context variable.

 If the legacy behavior is to be supported, it would be better IMO to have
 the get method call self.get_context_data thusly:

 {{{
 context = self.get_context_data(params=kwargs)
 }}}

 instead of

 {{{
 context = self.get_context_data(**kwargs)
 }}}

 This would allow get_context_data to be called with other kwargs in a call
 chain from a subclass without all those kwargs getting sucked into the
 params context variable.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17228: params context variable from TemplateView is inconsistent with other get_context_data implementations

[Django]

#17228: params context variable from TemplateView is inconsistent with other
get_context_data implementations
--+
 Reporter:  ptone |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  Generic views |  Version:  SVN
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by aaugustin):

 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17228: params context variable from TemplateView is inconsistent with other get_context_data implementations

[Django]

#17228: params context variable from TemplateView is inconsistent with other
get_context_data implementations
-+-
 Reporter:  ptone|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  SVN
Component:  Generic views|   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by ptone):

 The reason for params is to allow easier migration from
 direct_to_template:

 https://docs.djangoproject.com/en/dev/ref/generic-views/#django-views-
 generic-simple-direct-to-template

 However, I still think that the pattern is deviant enough from the main
 CBV to warrant a deprecation, which won't completely kick in until a
 version after function based views are completely removed from Django.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17228: params context variable from TemplateView is inconsistent with other get_context_data implementations (was: params context variable is from TemplateView is inconsistent with other

[Django]

#17228: params context variable from TemplateView is inconsistent with other
get_context_data implementations
-+-
 Reporter:  ptone|Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  SVN
Component:  Generic views|   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by ptone):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.