Re: [Django] #17236: Documentation of session behavior during login

[Django]

#17236: Documentation of session behavior during login
-+-
 Reporter:  bruth|Owner:
 Type:   |  krzysiumed
  Cleanup/optimization   |   Status:  closed
Component:  Documentation|  Version:
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  1|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by claudep):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [17704]:
 {{{
 #!CommitTicketReference repository="" revision="17704"
 Fixed #17236 -- Clarified that anonymous session data are retained after
 login. Thanks krzysiumed for the patch.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17236: Documentation of session behavior during login

[Django]

#17236: Documentation of session behavior during login
-+-
 Reporter:  bruth|Owner:
 Type:   |  krzysiumed
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  1|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by jezdez):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17236: Documentation of session behavior during login

[Django]

#17236: Documentation of session behavior during login
-+-
 Reporter:  bruth|Owner:
 Type:   |  krzysiumed
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by krzysiumed):

 * cc: krzysiumed@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17236: Documentation of session behavior during login

[Django]

#17236: Documentation of session behavior during login
-+-
 Reporter:  bruth|Owner:
 Type:   |  krzysiumed
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by krzysiumed):

 * cc: krzysiumed@… (removed)
 * needs_better_patch:  1 => 0


Comment:

 OK, I amended the patch: the grammar was improved and a note in sphinx
 docs was added.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17236: Documentation of session behavior during login

[Django]

#17236: Documentation of session behavior during login
-+-
 Reporter:  bruth|Owner:
 Type:   |  krzysiumed
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  1|UI/UX:  0
-+-
Changes (by ptone):

 * needs_better_patch:  0 => 1


Comment:

 "Note that when logging in session," the grammar is off, not sure what
 exactly you meant

 Also this is a change to a docstring, and Django's docs are not
 autogenerated, so docs should also be updated in the source files of the
 sphinx documentation.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17236: Documentation of session behavior during login

[Django]

#17236: Documentation of session behavior during login
-+-
 Reporter:  bruth|Owner:
 Type:   |  krzysiumed
  Cleanup/optimization   |   Status:  assigned
Component:  Documentation|  Version:
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by krzysiumed):

 * cc: krzysiumed@… (added)
 * has_patch:  0 => 1
 * type:  Uncategorized => Cleanup/optimization


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17236: Documentation of session behavior during login

[Django]

#17236: Documentation of session behavior during login
---+--
 Reporter:  bruth  |Owner:  krzysiumed
 Type:  Uncategorized  |   Status:  assigned
Component:  Documentation  |  Version:
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--
Changes (by krzysiumed):

 * status:  new => assigned
 * owner:  nobody => krzysiumed


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17236: Documentation of session behavior during login

[Django]

#17236: Documentation of session behavior during login
---+
 Reporter:  bruth  |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Documentation  |  Version:
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Changes (by PaulM):

 * needs_better_patch:   => 0
 * stage:  Unreviewed => Accepted
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 The docs need to point out that session data is retained when going from
 anonymous session to a logged in session retains data set during the
 anonymous session, but that sessions are cleared entirely when logging
 out.

 The first bullet point in the email is incorrect - the flush code does
 delete the session, causing a new session id to be created.
 
https://github.com/django/django/blob/master/django/contrib/sessions/backends/base.py#L240-257

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #17236: Documentation of session behavior during login

[Django]

#17236: Documentation of session behavior during login
---+
 Reporter:  bruth  |  Owner:  nobody
 Type:  Uncategorized  | Status:  new
Component:  Documentation  |Version:
 Severity:  Normal |   Keywords:
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  1  |  UI/UX:  0
---+
 Discussion here: http://groups.google.com/group/django-
 developers/browse_thread/thread/93dd04dc07ddf612

 This slice of code regarding the session behavior during login should be
 documented:
 
https://github.com/django/django/blob/master/django/contrib/auth/__init__.py#L63-70

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.