Re: [Django] #17305: Cache middleware keys too difficult to customize

[Django]

#17305: Cache middleware keys too difficult to customize
-+-
 Reporter:  subsume  |Owner:
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:
Component:  Core (Cache system)  |   Resolution:  invalid
 Severity:  Normal   | Triage Stage:  Design
 Keywords:   |  decision needed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by subsume):

 The idea was making the cache keys which django creates digestible to
 other services but django is such a mess in this regard its just easier to
 duplicate my cache entirely for the sake of letting something else access
 it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17305: Cache middleware keys too difficult to customize

[Django]

#17305: Cache middleware keys too difficult to customize
-+-
 Reporter:  subsume  |Owner:
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:
Component:  Core (Cache system)  |   Resolution:  invalid
 Severity:  Normal   | Triage Stage:  Design
 Keywords:   |  decision needed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by aaugustin):

 * status:  new => closed
 * resolution:   => invalid


Comment:

 Closing ticket since the reporter has lost interest and I'm skeptical
 about the idea. I'd need a more detailed proposal, and analysis of the
 consequence wrt. backwards compatibility, to validate it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17305: Cache middleware keys too difficult to customize

[Django]

#17305: Cache middleware keys too difficult to customize
-+-
 Reporter:  subsume  |Owner:
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:
Component:  Core (Cache system)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Design
 Keywords:   |  decision needed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by subsume):

 * owner:  subsume =>


Comment:

 FWIW I abandoned this. Nobody besides me minds how its setup now, my
 related ticket #17313 was closed with a nonsense explanation, and the more
 I dig into the CACHE_MIDDLEWARE_ANONYMOUS_ONLY the more I realize that
 setting is totally misleading to begin with and has absolutely nothing to
 do with anonymous users.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17305: Cache middleware keys too difficult to customize

[Django]

#17305: Cache middleware keys too difficult to customize
-+-
 Reporter:  subsume  |Owner:  subsume
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:
Component:  Core (Cache system)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Design
 Keywords:   |  decision needed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by aaugustin):

 * stage:  Unreviewed => Design decision needed


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17305: Cache middleware keys too difficult to customize

[Django]

#17305: Cache middleware keys too difficult to customize
-+-
 Reporter:  subsume  |Owner:  subsume
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:
Component:  Core (Cache system)  |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by subsume):

 Also I think there's an oversight in the Fetch middleware:

 
https://code.djangoproject.com/browser/django/trunk/django/middleware/cache.py#L133

 Perhaps someone can inform me if I am being ignorant, but the Fetch
 middleware seems to make no reference to
 settings.CACHE_MIDDLEWARE_UNAUTHENTICATED_ONLY before creating a
 connection to cache and checking for the value. The only reason it happens
 to work in the current setup is because the Update happens to skip
 creation of a key. So even though I have explicitly set UNUAUTH=True, when
 I use a key that isn't generated by the above utils, it will result in my
 auth users getting a cached version.

 Began ticket about this #17313

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17305: Cache middleware keys too difficult to customize

[Django]

#17305: Cache middleware keys too difficult to customize
-+-
 Reporter:  subsume  |Owner:  subsume
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:
Component:  Core (Cache system)  |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by subsume):

 I had thought of that and I'm open to a patch that makes things backwards
 compatible--I didn't know how to approach that given the drasticness as
 you say. Still, I hope that drastic changes aren't a blocker to giving
 people useful hooks. Also, I had to update the tests and found them to not
 be difficult to adapt as the classmethods can still be used separately.

 Subclassing the existing middleware wouldn't have been fruitful at all. If
 you take a look at them, the internals are entrenched by these "utils". It
 is the organization of these utils that makes these middlewares un-
 subclassable (usefully anyway).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17305: Cache middleware keys too difficult to customize

[Django]

#17305: Cache middleware keys too difficult to customize
-+-
 Reporter:  subsume  |Owner:  subsume
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:
Component:  Core (Cache system)  |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by ptone):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 unused in Django itself doesn't mean that other people aren't making use
 of those util functions in other code in the form of custom cache
 middleware - this is a rather drastic and backwards incompatible refactor

 What problems would you have had in solving your problem if you had simply
 chosen to subclass the existing middleware and modify it to suit your
 needs?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #17305: Cache middleware keys too difficult to customize

[Django]

#17305: Cache middleware keys too difficult to customize
--+-
 Reporter:  subsume   |  Owner:  subsume
 Type:  Cleanup/optimization  | Status:  new
Component:  Core (Cache system)   |Version:
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  1
Easy pickings:  0 |  UI/UX:  0
--+-
 Attached is a patch which brings many otherwise-unused "utils.cache" utils
 under the middleware method as classmethods. This is to provide easy hooks
 so that people can make their own cache key structures.

 In case anyone cares, the problem I ran into was that nginx couldn't
 digest the default cache keys which that middlware creates as they were
 needlessly complex.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.