Re: [Django] #17429: if ordering = None incorrect result

2012-01-03 Thread Django 
#17429: if ordering = None incorrect result
-+-
 Reporter:  self@…   |Owner:  bigkevmcd
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.3
  (models, ORM)  |   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by julien):

 Replying to [comment:3 anonymous]:
 > Would it be better to set ordering to () if ordering is None in Model
 setup? That way this same bug will not raise its head in other places of
 the code.

 I think it's best to at least put some safe-guarding in
 `SQLCompiler.get_ordering()` as that was done in [17334]. If you see any
 place in the code where more safe-guarding is required, please open a new
 ticket. Thanks!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17429: if ordering = None incorrect result

2012-01-03 Thread Django 
#17429: if ordering = None incorrect result
-+-
 Reporter:  self@…   |Owner:  bigkevmcd
 Type:  Bug  |   Status:  closed
Component:  Database layer   |  Version:  1.3
  (models, ORM)  |   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by julien):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [17334]:
 {{{
 #!CommitTicketReference repository="" revision="17334"
 Fixed #17429 -- Ensured that `Meta.ordering=None` works the same if it
 were an empty list. Thanks to self[at]dicos[dot]ru for the report and to
 bigkevmcd for the patch.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17429: if ordering = None incorrect result

2012-01-03 Thread Django 
#17429: if ordering = None incorrect result
-+-
 Reporter:  self@…   |Owner:  bigkevmcd
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.3
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-

Comment (by anonymous):

 Would it be better to set ordering to () if ordering is None in Model
 setup? That way this same bug will not raise its head in other places of
 the code.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17429: if ordering = None incorrect result

2011-12-21 Thread Django 
#17429: if ordering = None incorrect result
-+-
 Reporter:  self@…   |Owner:  bigkevmcd
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.3
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by bigkevmcd):

 * owner:  nobody => bigkevmcd
 * has_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17429: if ordering = None incorrect result

2011-12-17 Thread Django 
#17429: if ordering = None incorrect result
-+-
 Reporter:  self@…   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  1.3
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  0|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by bpeschier):

 * needs_better_patch:   => 0
 * stage:  Unreviewed => Accepted
 * needs_tests:   => 0
 * needs_docs:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #17429: if ordering = None incorrect result

2011-12-16 Thread Django 
#17429: if ordering = None incorrect result
--+
 Reporter:  self@…|  Owner:  nobody
 Type:  Bug   | Status:  new
Component:  Database layer (models, ORM)  |Version:  1.3
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  0 |  UI/UX:  0
--+
 Model:
 {{{
 #!div style="font-size: 80%"
 Code highlighting:
   {{{#!python
 class SomeModel(models.Model):
 value = models.DecimalField(max_digits=5, decimal_places=2)

 class Meta:
 ordering = None

 In [4]: SomeModel.objects.create(value=1)
 Out[4]: 

 In [5]:  SomeModel.objects.create(value=2)
 Out[5]: 

 In [6]: SomeModel.objects.count()
 Out[6]: 2

 In [7]: SomeModel.objects.all()
 Out[7]: []
   }}}
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.