Re: [Django] #17506: Minor tidyup in session DB backend

[Django]

#17506: Minor tidyup in session DB backend
-+-
 Reporter:  FunkyBob |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:  SVN
Component:  contrib.sessions |   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:  session  |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by julien):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [17390]:
 {{{
 #!CommitTicketReference repository="" revision="17390"
 Fixed #17506 -- Did a minor optimization in the sessions' database
 backend. Thanks to FunkyBob for the report and patch.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17506: Minor tidyup in session DB backend

[Django]

#17506: Minor tidyup in session DB backend
-+-
 Reporter:  FunkyBob |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  SVN
Component:  contrib.sessions |   Resolution:
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:  session  |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+-
Changes (by claudep):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17506: Minor tidyup in session DB backend

[Django]

#17506: Minor tidyup in session DB backend
--+
 Reporter:  FunkyBob  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.sessions  |  Version:  SVN
 Severity:  Normal|   Resolution:
 Keywords:  session   | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+
Changes (by anonymous):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17506: Minor tidyup in session DB backend

[Django]

#17506: Minor tidyup in session DB backend
--+
 Reporter:  FunkyBob  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.sessions  |  Version:  SVN
 Severity:  Normal|   Resolution:
 Keywords:  session   | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  1
Easy pickings:  1 |UI/UX:  0
--+
Changes (by lukeplant):

 * needs_docs:   => 0
 * needs_better_patch:   => 1
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 Accepted, but the method needs to actually return the value - with your
 patch it returns `None` always. Once this is fixed the ticket can be
 marked 'ready for checkin'.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #17506: Minor tidyup in session DB backend

[Django]

#17506: Minor tidyup in session DB backend
--+-
 Reporter:  FunkyBob  |  Owner:  nobody
 Type:  Cleanup/optimization  | Status:  new
Component:  contrib.sessions  |Version:  SVN
 Severity:  Normal|   Keywords:  session
 Triage Stage:  Unreviewed|  Has patch:  1
Easy pickings:  1 |  UI/UX:  0
--+-
 The ORM docs suggest using exists() can be more efficient than
 try:get()/except:

 Here's a patch to do just that in the session DB backend.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.