Re: [Django] #17818: Generic edit generic views don't create `fail_silently` success messages anymore.

[Django]

#17818: Generic edit generic views don't create `fail_silently` success messages
anymore.
-+-
 Reporter:  charettes|Owner:  charettes
 Type:  New feature  |   Status:  closed
Component:  Generic views|  Version:  master
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:  views generic edit   | Triage Stage:  Accepted
  messages   |  Needs documentation:  1
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by charettes):

 * status:  new => closed
 * resolution:   => duplicate


Comment:

 Closing as duplicate of #16319.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #17818: Generic edit generic views don't create `fail_silently` success messages anymore.

[Django]

#17818: Generic edit generic views don't create `fail_silently` success messages
anymore.
-+-
 Reporter:  charettes|Owner:  charettes
 Type:  New feature  |   Status:  new
Component:  Generic views|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  views generic edit   | Triage Stage:  Accepted
  messages   |  Needs documentation:  1
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by hirokiky):

 * cc: hirokiky@… (added)
 * needs_tests:  1 => 0


Comment:

 I added a patch for testing this feature.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #17818: Generic edit generic views don't create `fail_silently` success messages anymore.

[Django]

#17818: Generic edit generic views don't create `fail_silently` success messages
anymore.
-+-
 Reporter:  charettes|Owner:  charettes
 Type:  New feature  |   Status:  new
Component:  Generic views|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  views generic edit   | Triage Stage:  Accepted
  messages   |  Needs documentation:  1
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  1|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by mjtamlyn):

 * cc: marc.tamlyn@… (added)
 * needs_docs:  0 => 1
 * version:  1.3 => master
 * needs_tests:  0 => 1


Comment:

 I'm +1 on this feature being reintroduced, but -1 on it being on by
 default, especially as this would constitute a backwards incompatibility
 to me. We have views around which create messages similar to this, and
 turning it back on by default would mean duplicate messages, or messages
 where none were expected.

 That said it's probably a useful feature by default, but I think there
 should be an upgrade path.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #17818: Generic edit generic views don't create `fail_silently` success messages anymore.

[Django]

#17818: Generic edit generic views don't create `fail_silently` success messages
anymore.
-+-
 Reporter:  charettes|Owner:  charettes
 Type:  New feature  |   Status:  new
Component:  Generic views|  Version:  1.3
 Severity:  Normal   |   Resolution:
 Keywords:  views generic edit   | Triage Stage:  Accepted
  messages   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by aaugustin):

 * needs_better_patch:   => 0
 * needs_docs:   => 0
 * type:  Uncategorized => New feature
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #17818: Generic edit generic views don't create `fail_silently` success messages anymore.

[Django]

#17818: Generic edit generic views don't create `fail_silently` success messages
anymore.
---+-
 Reporter:  charettes  |  Owner:  charettes
 Type:  Uncategorized  | Status:  new
Component:  Generic views  |Version:  1.3
 Severity:  Normal |   Keywords:  views generic edit messages
 Triage Stage:  Unreviewed |  Has patch:  1
Easy pickings:  0  |  UI/UX:  0
---+-
 It looks like the creation of success messages on valid form submission
 was oversight when the generic class based views were designed.

 Here's a link to the [https://groups.google.com/forum/#!topic/django-
 developers/3UcEeutA5Qg django-developper discussion] that motivated the
 creation of this ticket.

 I'm also attaching a patch (with no tests and docs) that provide a simple
 yet overridable implementation that mimic the deprecated function based
 behaviour.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.