Re: [Django] #17848: Template context processors cache needs to be restored after it is cleared

[Django]

#17848: Template context processors cache needs to be restored after it is 
cleared
--+--
 Reporter:  ryankask  |Owner:  ryan
 Type:  Bug   |   Status:  closed
Component:  contrib.auth  |  Version:  1.4-beta-1
 Severity:  Normal|   Resolution:  fixed
 Keywords:  tests | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+--
Changes (by claudep):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [17885]:
 {{{
 #!CommitTicketReference repository="" revision="17885"
 Fixed #17848 -- Added setting_changed signal for cases when
 TEMPLATE_CONTEXT_PROCESSORS is overriden in tests.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17848: Template context processors cache needs to be restored after it is cleared

[Django]

#17848: Template context processors cache needs to be restored after it is 
cleared
--+--
 Reporter:  ryankask  |Owner:  ryan
 Type:  Bug   |   Status:  new
Component:  contrib.auth  |  Version:  1.4-beta-1
 Severity:  Normal|   Resolution:
 Keywords:  tests | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+--

Comment (by claudep):

 Note that currenlty, the test
 messages.SessionTest.test_middleware_disabled_fail_silently does not pass
 when it is run individually, which is a symptom of the context processors
 cache issue (fixed in the latest patch).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17848: Template context processors cache needs to be restored after it is cleared

[Django]

#17848: Template context processors cache needs to be restored after it is 
cleared
--+--
 Reporter:  ryankask  |Owner:  ryan
 Type:  Bug   |   Status:  new
Component:  contrib.auth  |  Version:  1.4-beta-1
 Severity:  Normal|   Resolution:
 Keywords:  tests | Triage Stage:  Accepted
Has patch:  1 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  1 |UI/UX:  0
--+--
Changes (by claudep):

 * severity:  Release blocker => Normal


Comment:

 Severity back to normal. Patch using setting_changed signal will be
 applied later.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17848: Template context processors cache needs to be restored after it is cleared

[Django]

#17848: Template context processors cache needs to be restored after it is 
cleared
-+--
 Reporter:  ryankask |Owner:  ryan
 Type:  Bug  |   Status:  new
Component:  contrib.auth |  Version:  1.4-beta-1
 Severity:  Release blocker  |   Resolution:
 Keywords:  tests| Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+--

Comment (by claudep):

 In [17736]:
 {{{
 #!CommitTicketReference repository="" revision="17736"
 Reset template context processors cache after tests. Refs #17848.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17848: Template context processors cache needs to be restored after it is cleared

[Django]

#17848: Template context processors cache needs to be restored after it is 
cleared
-+--
 Reporter:  ryankask |Owner:  ryan
 Type:  Bug  |   Status:  new
Component:  contrib.auth |  Version:  1.4-beta-1
 Severity:  Release blocker  |   Resolution:
 Keywords:  tests| Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+--

Comment (by aaugustin):

 I'm not comfortable with large changes this close to 1.4 final. I think we
 could commit the first version now, and implement the
 `signal_setting`-based technique after 1.4.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17848: Template context processors cache needs to be restored after it is cleared

[Django]

#17848: Template context processors cache needs to be restored after it is 
cleared
-+--
 Reporter:  ryankask |Owner:  ryan
 Type:  Bug  |   Status:  new
Component:  contrib.auth |  Version:  1.4-beta-1
 Severity:  Release blocker  |   Resolution:
 Keywords:  tests| Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+--
Changes (by claudep):

 * stage:  Ready for checkin => Accepted


Comment:

 I'd just like some other committer to judge if the signal_setting approach
 might be a little cleaner. I also changed TEMPLATE_CONTEXT_PROCESSORS
 overriding in other tests to be consistent.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17848: Template context processors cache needs to be restored after it is cleared

[Django]

#17848: Template context processors cache needs to be restored after it is 
cleared
-+-
 Reporter:  ryankask |Owner:  ryan
 Type:  Bug  |   Status:  new
Component:  contrib.auth |  Version:
 Severity:  Release blocker  |  1.4-beta-1
 Keywords:  tests|   Resolution:
Has patch:  1| Triage Stage:  Ready for
  Needs tests:  0|  checkin
Easy pickings:  1|  Needs documentation:  0
 |  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by ptone):

 * stage:  Unreviewed => Ready for checkin


Comment:

 Just ran tests and they pass - this looks like a sane approach

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17848: Template context processors cache needs to be restored after it is cleared

[Django]

#17848: Template context processors cache needs to be restored after it is 
cleared
-+--
 Reporter:  ryankask |Owner:  ryan
 Type:  Bug  |   Status:  new
Component:  contrib.auth |  Version:  1.4-beta-1
 Severity:  Release blocker  |   Resolution:
 Keywords:  tests| Triage Stage:  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+--

Comment (by ryankask):

 You're right. That's much simpler.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17848: Template context processors cache needs to be restored after it is cleared

[Django]

#17848: Template context processors cache needs to be restored after it is 
cleared
-+--
 Reporter:  ryankask |Owner:  ryan
 Type:  Bug  |   Status:  new
Component:  contrib.auth |  Version:  1.4-beta-1
 Severity:  Release blocker  |   Resolution:
 Keywords:  tests| Triage Stage:  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+--
Changes (by claudep):

 * needs_docs:   => 0
 * needs_tests:   => 0
 * needs_better_patch:   => 0


Comment:

 I think it would be easier to just empty the cache again at the end of the
 tests.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #17848: Template context processors cache needs to be restored after it is cleared

[Django]

#17848: Template context processors cache needs to be restored after it is 
cleared
-+
 Reporter:  ryankask |  Owner:  ryan
 Type:  Bug  | Status:  new
Component:  contrib.auth |Version:  1.4-beta-1
 Severity:  Release blocker  |   Keywords:  tests
 Triage Stage:  Unreviewed   |  Has patch:  1
Easy pickings:  1|  UI/UX:  0
-+
 I contributed the portion of the patch for #16366 where
 ``context._standard_context_processors`` is set to ``None`.

 Unfortunatley, I neglected to restore the cache as it was at the end of
 the test.

 The effect of this is that cache is now wrong for the rest of my project
 (and will be for others) and other tests fail.

 This patch fixes this.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.