Re: [Django] #17890: django.contrib.admin.site extra_context

[Django]

#17890: django.contrib.admin.site extra_context
-+-
 Reporter:  riccardodivirgilio   |Owner:
 Type:  Bug  |  berkerpeksag
Component:  contrib.admin|   Status:  closed
 Severity:  Normal   |  Version:  master
 Keywords:  extra_context|   Resolution:  fixed
Has patch:  1| Triage Stage:  Accepted
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"c8dcded930a1d0ee5688ae2c2eeb8c33d942009f"]:
 {{{
 #!CommitTicketReference repository=""
 revision="c8dcded930a1d0ee5688ae2c2eeb8c33d942009f"
 Fixed #17890 -- Added an extra_context parameter to
 AdminSite.password_change().
 }}}

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.0fb9a446635c6a6169ec1afb2181eb0b%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #17890: django.contrib.admin.site extra_context

[Django]

#17890: django.contrib.admin.site extra_context
-+-
 Reporter:  riccardodivirgilio   |Owner:
 Type:  Bug  |  berkerpeksag
Component:  contrib.admin|   Status:  assigned
 Severity:  Normal   |  Version:  master
 Keywords:  extra_context|   Resolution:
Has patch:  1| Triage Stage:  Accepted
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by berkerpeksag):

 * owner:  nobody => berkerpeksag
 * needs_docs:  1 => 0
 * status:  new => assigned
 * needs_better_patch:  1 => 0


Comment:

 https://github.com/django/django/pull/3644

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.44e49c26158a3c202527455fbb1ee298%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #17890: django.contrib.admin.site extra_context

[Django]

#17890: django.contrib.admin.site extra_context
+
 Reporter:  riccardodivirgilio  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  master
 Severity:  Normal  |   Resolution:
 Keywords:  extra_context   | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  1
  Needs tests:  0   |  Patch needs improvement:  1
Easy pickings:  0   |UI/UX:  0
+
Changes (by timmartin):

 * cc: timmartin (added)


Comment:

 Since the ticket was opened, `each_context()` has been added to the
 `AdminSite` class, so it's possible to provide additional context fields
 by subclassing `AdminSite` and overriding `each_context()`. Does this make
 this ticket unnecessary? I'll happily fix up the patch if it's useful, but
 I don't want to do that if the feature is no longer needed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/076.3fb690e16f85bf43782bb723e6e190e7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #17890: django.contrib.admin.site extra_context

[Django]

#17890: django.contrib.admin.site extra_context
+
 Reporter:  riccardodivirgilio  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  master
 Severity:  Normal  |   Resolution:
 Keywords:  extra_context   | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  1
  Needs tests:  0   |  Patch needs improvement:  1
Easy pickings:  0   |UI/UX:  0
+
Changes (by lucmult):

 * needs_better_patch:  0 => 1
 * needs_docs:  0 => 1


Comment:

 Hi,

 I didn't understand the use case of this `extra_context`.

 I think the same result it's possible to achieve overwriting the template.

 Can you explain better the use case of this new `extra_context`?

 For the patch/pull request:

 1 - It'd need to update docs:
 
https://docs.djangoproject.com/en/dev/topics/auth/default/#django.contrib.auth.views.password_change

 2 - It'd need to update the provided template, currently it's ignoring
 `extra_context`

 Thanks.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #17890: django.contrib.admin.site extra_context

[Django]

#17890: django.contrib.admin.site extra_context
+
 Reporter:  riccardodivirgilio  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  master
 Severity:  Normal  |   Resolution:
 Keywords:  extra_context   | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+

Comment (by smuss):

 I closed the previous pull request and opened a new one at
 https://github.com/django/django/pull/499.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #17890: django.contrib.admin.site extra_context

[Django]

#17890: django.contrib.admin.site extra_context
+
 Reporter:  riccardodivirgilio  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  master
 Severity:  Normal  |   Resolution:
 Keywords:  extra_context   | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by anonymous):

 * keywords:   => extra_context


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17890: django.contrib.admin.site extra_context

[Django]

#17890: django.contrib.admin.site extra_context
+
 Reporter:  riccardodivirgilio  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  master
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by smuss):

 * needs_tests:  1 => 0


Comment:

 Tests added to pull request.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17890: django.contrib.admin.site extra_context

[Django]

#17890: django.contrib.admin.site extra_context
+
 Reporter:  riccardodivirgilio  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  master
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  1   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by claudep):

 * needs_tests:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17890: django.contrib.admin.site extra_context

[Django]

#17890: django.contrib.admin.site extra_context
+
 Reporter:  riccardodivirgilio  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  master
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  1   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by smuss):

 * cc: stephenmuss@… (added)
 * has_patch:  0 => 1


Comment:

 Have created a patch and submitted a pull request at
 https://github.com/django/django/pull/64

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #17890: django.contrib.admin.site extra_context

[Django]

#17890: django.contrib.admin.site extra_context
+
 Reporter:  riccardodivirgilio  |Owner:  nobody
 Type:  Bug |   Status:  new
Component:  contrib.admin   |  Version:  SVN
 Severity:  Normal  |   Resolution:
 Keywords:  | Triage Stage:  Accepted
Has patch:  0   |  Needs documentation:  0
  Needs tests:  0   |  Patch needs improvement:  0
Easy pickings:  0   |UI/UX:  0
+
Changes (by claudep):

 * needs_better_patch:   => 0
 * stage:  Unreviewed => Accepted
 * needs_tests:   => 0
 * needs_docs:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #17890: django.contrib.admin.site extra_context

[Django]

#17890: django.contrib.admin.site extra_context
+
 Reporter:  riccardodivirgilio  |  Owner:  nobody
 Type:  Bug | Status:  new
Component:  contrib.admin   |Version:  SVN
 Severity:  Normal  |   Keywords:
 Triage Stage:  Unreviewed  |  Has patch:  0
Easy pickings:  0   |  UI/UX:  0
+
 hi, in django.contrib.admin.site the method  password_change do not
 support extra_context, i think it's a minor bug to be fixed.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.