Re: [Django] #18098: order_with_respect_to should construct set_RELATED_order() method name from related_name

[Django]

#18098: order_with_respect_to should construct set_RELATED_order() method name 
from
related_name
-+-
 Reporter:  pressureman  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  1
  Needs tests:  1|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by timo):

 * needs_better_patch:  0 => 1
 * needs_tests:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/069.e751f1884934c9a48e8c1dd875a53c93%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18098: order_with_respect_to should construct set_RELATED_order() method name from related_name

[Django]

#18098: order_with_respect_to should construct set_RELATED_order() method name 
from
related_name
-+-
 Reporter:  pressureman  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:   |  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  0|
-+-
Changes (by aaugustin):

 * stage:  Design decision needed => Accepted


Comment:

 We're getting rid of the DDN state, and this is a valid problem.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18098: order_with_respect_to should construct set_RELATED_order() method name from related_name

[Django]

#18098: order_with_respect_to should construct set_RELATED_order() method name 
from
related_name
-+-
 Reporter:  pressureman  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Design
 Keywords:   |  decision needed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by anonymous):

 How about making the order_with_respect_to attribute either a model name
 string for backwards compatibility, or a two-tuple, containing the parent
 model, and a name to assign the relationship? It's perhaps not the most
 elegant, but would satisfy both requirements.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #18098: order_with_respect_to should construct set_RELATED_order() method name from related_name

[Django]

#18098: order_with_respect_to should construct set_RELATED_order() method name 
from
related_name
-+-
 Reporter:  pressureman  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:  Design
 Keywords:   |  decision needed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by aaugustin):

 * stage:  Unreviewed => Design decision needed


Comment:

 The problem is valid. However the proposed solution doesn't guarantee
 backwards compatibility. I'm not sure of what we should do.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #18098: order_with_respect_to should construct set_RELATED_order() method name from related_name

[Django]

#18098: order_with_respect_to should construct set_RELATED_order() method name 
from
related_name
-+-
 Reporter:  pressureman  |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Database layer   |  Version:  SVN
  (models, ORM)  |   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by pressureman):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 This following situation would cause this problem to surface:

 {{{
 class Device(models.Model):
 name = CharField(max_length=60, unique=True)
 ...


 # foo/models.py
 class ExpansionModule(models.Model):
 device = models.ForeignKey(Device,
 related_name='foo_expansionmodule_set')
 module_type = models.CharField(max_length=32,
 choices=EXPANSION_MODULE_CHOICES)
 ... # additional fields specific to foo

 class Meta:
 order_with_respect_to = 'device'


 # bar/models.py
 class ExpansionModule(models.Model):
 device = models.ForeignKey(Device,
 related_name='bar_expansionmodule_set')
 module_type = models.CharField(max_length=32,
 choices=EXPANSION_MODULE_CHOICES)
 ... # additional fields specific to bar

 class Meta:
 order_with_respect_to = 'device'
 }}}

 "Device" objects would only have the one `set_expansionmodule_order()`
 method.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #18098: order_with_respect_to should construct set_RELATED_order() method name from related_name

[Django]

#18098: order_with_respect_to should construct set_RELATED_order() method name 
from
related_name
--+
 Reporter:  pressureman   |  Owner:  nobody
 Type:  Bug   | Status:  new
Component:  Database layer (models, ORM)  |Version:  SVN
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  1
Easy pickings:  0 |  UI/UX:  0
--+
 If two identically named models in separate apps refer to a parent to the
 same parent model in their order_with_respect_to, only one
 set_RELATED_order() method is created on the parent model.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.