Re: [Django] #18321: generic_views unit tests are not respecting database feature supports_timezones

[Django]

#18321: generic_views unit tests are not respecting database feature
supports_timezones
---+--
 Reporter:  manfre |Owner:  nobody
 Type:  Bug|   Status:  closed
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:  wontfix
 Keywords: | Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+--
Changes (by aaugustin):

 * status:  new => closed
 * needs_docs:   => 0
 * resolution:   => wontfix
 * needs_tests:   => 0
 * needs_better_patch:   => 0


Comment:

 MySQL, SQLite and Oracle have `support_timezones = False` because either
 they're unable to store aware datetimes or their Python adapters are
 unable to handle them.

 But it's important to test that they behave correctly when `USE_TZ =
 True`. Your patch would disable several tests for these three backends,
 which isn't acceptable. I suspect you misunderstood the meaning of the
 `supports_timezones` feature flag.

 (Also, there are other tests that require timezone support, starting with
 tests.modeltests.timezones, I'm not sure why the patch only applies to
 tests.regressiontests.generic_views.)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #18321: generic_views unit tests are not respecting database feature supports_timezones

[Django]

#18321: generic_views unit tests are not respecting database feature
supports_timezones
---+
 Reporter:  manfre |  Owner:  nobody
 Type:  Bug| Status:  new
Component:  Testing framework  |Version:  master
 Severity:  Normal |   Keywords:
 Triage Stage:  Unreviewed |  Has patch:  1
Easy pickings:  0  |  UI/UX:  0
---+
 Tests that specifically target timezone support, should be skipped if the
 database backend states it does not support timezones.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.