Re: [Django] #18355: Add ordering mixin for class based generic views

[Django]

#18355: Add ordering mixin for class based generic views
---+-
 Reporter:  aaugustin  |Owner:  pjrharley
 Type:  New feature|   Status:  closed
Component:  Generic views  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"2724cdbff635a40819f206411de23e9b14867a58"]:
 {{{
 #!CommitTicketReference repository=""
 revision="2724cdbff635a40819f206411de23e9b14867a58"
 Fixed #18355 -- Added ordering options to list based generic views.

 Added MultipleObjectMixin.ordering and get_ordering().

 Refs #21450.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.ada379f21ce8bb64388ba139ab771a95%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18355: Add ordering mixin for class based generic views

[Django]

#18355: Add ordering mixin for class based generic views
---+-
 Reporter:  aaugustin  |Owner:  pjrharley
 Type:  New feature|   Status:  assigned
Component:  Generic views  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by pjrharley):

 * needs_better_patch:  1 => 0


Comment:

 Patch updated. Thanks for the review.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.70fde25af8e2eb2d5581da334c127fe7%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18355: Add ordering mixin for class based generic views

[Django]

#18355: Add ordering mixin for class based generic views
---+-
 Reporter:  aaugustin  |Owner:  pjrharley
 Type:  New feature|   Status:  assigned
Component:  Generic views  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by timo):

 * needs_better_patch:  0 => 1


Comment:

 I left comments for improvement on PR. Please uncheck "Patch needs
 improvement" when you update it, thanks.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.5e4adb683b640ce6615556d09ef37801%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18355: Add ordering mixin for class based generic views

[Django]

#18355: Add ordering mixin for class based generic views
---+-
 Reporter:  aaugustin  |Owner:  pjrharley
 Type:  New feature|   Status:  assigned
Component:  Generic views  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by pjrharley):

 * owner:  anonymous => pjrharley


Comment:

 Try assigning to myself while signed in instead...

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.e544a993b35bf6a1a5189c80e7d83393%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18355: Add ordering mixin for class based generic views

[Django]

#18355: Add ordering mixin for class based generic views
---+-
 Reporter:  aaugustin  |Owner:  anonymous
 Type:  New feature|   Status:  assigned
Component:  Generic views  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by anonymous):

 * status:  new => assigned
 * owner:   => anonymous
 * has_patch:  0 => 1


Comment:

 I've added a PR for this here:

 https://github.com/django/django/pull/2097

 Not sure if the approach is right - feedback welcome. I suspect the docs
 need improvement - more than happy to do that if the code is looking good.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.e3519812cdebac3bb493b03adcec8906%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18355: Add ordering mixin for class based generic views

[Django]

#18355: Add ordering mixin for class based generic views
---+
 Reporter:  aaugustin  |Owner:
 Type:  New feature|   Status:  new
Component:  Generic views  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by aaugustin):

 * owner:  aaugustin =>
 * status:  assigned => new


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.688a876dccae99d55efbb3a454043334%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18355: Add ordering mixin for class based generic views

[Django]

#18355: Add ordering mixin for class based generic views
---+-
 Reporter:  aaugustin  |Owner:  aaugustin
 Type:  New feature|   Status:  assigned
Component:  Generic views  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by aaugustin):

 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/067.cb1ea4b436f1ce705f593de2ea965e1d%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18355: Add ordering mixin for class based generic views

[Django]

#18355: Add ordering mixin for class based generic views
---+-
 Reporter:  aaugustin  |Owner:  aaugustin
 Type:  New feature|   Status:  new
Component:  Generic views  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-

Comment (by aaugustin):

 The goals were clear to me when I was working on the date-based views, but
 unfortunately I've lost track of it since then...

 I think it's just about implementing the API in the ticket description,
 documenting it, and taking advantage of it in the date-based views while
 preserving backwards-compat.

 You're very welcome to take over on this ticket if you'd like to as it's
 pretty low on my priority list.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18355: Add ordering mixin for class based generic views

[Django]

#18355: Add ordering mixin for class based generic views
---+-
 Reporter:  aaugustin  |Owner:  aaugustin
 Type:  New feature|   Status:  new
Component:  Generic views  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by mjtamlyn):

 * cc: marc.tamlyn@… (added)


Comment:

 Would this functionality apply only to list views? This would certainly
 give a good advantage as one's instinct is to apply the `get_queryset`
 changes to every view with the same Model, but ordering is rather useless
 when we're simply doing a `DetailView` (and could impose a performance
 problem). So the code would perhaps live in `BaseListView` rather than
 `MultipleObjectMixin`.

 That said, if this functionality is only hitting list views, it actually
 fits in with a larger subject area of search/ordering/filtering as defined
 by the user. In reality this is probably just one of the first hooks we
 might need to implement that kind of functionality well, but it may be
 worth considering the larger list-view-customisation issue.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18355: Add ordering mixin for class based generic views (was: Date-based generic views should enforce ordering)

[Django]

#18355: Add ordering mixin for class based generic views
---+-
 Reporter:  aaugustin  |Owner:  aaugustin
 Type:  New feature|   Status:  new
Component:  Generic views  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.