Re: [Django] #18391: Inline forms fail to delete objects when PK is a custom field

[Django]

#18391: Inline forms fail to delete objects when PK is a custom field
-+-
 Reporter:  max@…|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:  inline form custom   | Triage Stage:
  field  |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by aaugustin):

 * status:  new => closed
 * resolution:   => needsinfo
 * component:  Forms => contrib.admin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18391: Inline forms fail to delete objects when PK is a custom field

[Django]

#18391: Inline forms fail to delete objects when PK is a custom field
-+-
 Reporter:  max@…|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  inline form custom   | Triage Stage:
  field  |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by aaugustin):

 The patch doesn't contain a test case. Could you provide a minimal example
 that triggers the bug (custom field, model and admin definitions)? Or at
 least the full traceback? That would save us some guesswork! :)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #18391: Inline forms fail to delete objects when PK is a custom field

[Django]

#18391: Inline forms fail to delete objects when PK is a custom field
-+-
 Reporter:  max@…|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Forms|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  inline form custom   | Triage Stage:
  field  |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  1|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by aaugustin):

 * needs_better_patch:   => 0
 * needs_tests:   => 1
 * easy:  1 => 0
 * needs_docs:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #18391: Inline forms fail to delete objects when PK is a custom field

[Django]

#18391: Inline forms fail to delete objects when PK is a custom field
+--
 Reporter:  max@…   |  Owner:  nobody
 Type:  Bug | Status:  new
Component:  Forms   |Version:  master
 Severity:  Normal  |   Keywords:  inline form custom field
 Triage Stage:  Unreviewed  |  Has patch:  1
Easy pickings:  1   |  UI/UX:  0
+--
 I have custom field type. It's a uuid. If I make an inline form in admin
 interface with a model that has this custom field as a primary key I can't
 delete it from the admin interface. I get an error that a NoneType doesn't
 have some attributes.

 The problem is that in _construct_form the primary key is got via
 get_db_prep_lookup which will always return a string. But in
 _existing_object when it initializes self._object_dict is just takes an
 object. Which must not be of a string type.

 Patch to eliminate it is attached.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.