Re: [Django] #18430: CachedFilesMixin crashed when CSS files contains non-ascii utf-8 character

[Django]

#18430: CachedFilesMixin crashed when CSS files contains non-ascii utf-8 
character
-+-
 Reporter:  brantyoung   |Owner:  dbrgn
 Type:  Bug  |   Status:  closed
Component:  contrib.staticfiles  |  Version:  1.4
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:
Has patch:  0|  Unreviewed
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  1|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by Jannis Leidel ):

 * status:  reopened => closed
 * resolution:   => fixed


Comment:

 In [3727f6d09681e4cb23d67e14ecc677a364c991bd]:
 {{{
 #!CommitTicketReference repository=""
 revision="3727f6d09681e4cb23d67e14ecc677a364c991bd"
 Fixed #18430 -- Use the FILE_CHARSET setting when reading from a file
 during post processing with the cached staticfiles storage. Thanks to
 Brant Young for initial debugging.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #18430: CachedFilesMixin crashed when CSS files contains non-ascii utf-8 character

[Django]

#18430: CachedFilesMixin crashed when CSS files contains non-ascii utf-8 
character
-+-
 Reporter:  brantyoung   |Owner:  dbrgn
 Type:  Bug  |   Status:  reopened
Component:  contrib.staticfiles  |  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
Has patch:  0|  Unreviewed
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  1|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by brantyoung):

 * status:  closed => reopened
 * resolution:  needsinfo =>


Comment:

 I create a minimal project to reproduce this ticket:
 https://bitbucket.org/brantyoung/cached_files_mixin_bug/overview

 It's weird, if I moving all of font files to any directory except
 *PROJECTROOT*/css, every thing works fine.

 But if both iconic-font.css and font files in the same **sub-directory**,
 CachedFilesMixin will crash.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #18430: CachedFilesMixin crashed when CSS files contains non-ascii utf-8 character

[Django]

#18430: CachedFilesMixin crashed when CSS files contains non-ascii utf-8 
character
-+-
 Reporter:  brantyoung   |Owner:  dbrgn
 Type:  Bug  |   Status:  closed
Component:  contrib.staticfiles  |  Version:  1.4
 Severity:  Normal   |   Resolution:  needsinfo
 Keywords:   | Triage Stage:
Has patch:  0|  Unreviewed
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  1|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by aaugustin):

 * status:  new => closed
 * resolution:   => needsinfo


Comment:

 Closing as 'needsinfo' since there isn't info to reproduce the issue.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #18430: CachedFilesMixin crashed when CSS files contains non-ascii utf-8 character

[Django]

#18430: CachedFilesMixin crashed when CSS files contains non-ascii utf-8 
character
-+-
 Reporter:  brantyoung   |Owner:  dbrgn
 Type:  Bug  |   Status:  new
Component:  contrib.staticfiles  |  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:
Has patch:  0|  Unreviewed
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  1|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by dbrgn):

 * severity:  Release blocker => Normal


Comment:

 I can't reproduce this on current trunk using `STATICFILES_STORAGE =
 'django.contrib.staticfiles.storage.CachedStaticFilesStorage'` (which uses
 the CachedFilesMixin). I even tried converting the css file to latin1,
 which garbled the contents, but still worked using collectstatic.

 Could you provide a CSS file that causes problems for you?

 Or can somebody else reproduce the problem?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #18430: CachedFilesMixin crashed when CSS files contains non-ascii utf-8 character

[Django]

#18430: CachedFilesMixin crashed when CSS files contains non-ascii utf-8 
character
-+-
 Reporter:  brantyoung   |Owner:  dbrgn
 Type:  Bug  |   Status:  new
Component:  contrib.staticfiles  |  Version:  1.4
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:
Has patch:  0|  Unreviewed
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  1|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by dbrgn):

 * owner:  nobody => dbrgn
 * needs_docs:   => 0
 * needs_tests:   => 0
 * needs_better_patch:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #18430: CachedFilesMixin crashed when CSS files contains non-ascii utf-8 character

[Django]

#18430: CachedFilesMixin crashed when CSS files contains non-ascii utf-8 
character
-+
 Reporter:  brantyoung   |  Owner:  nobody
 Type:  Bug  | Status:  new
Component:  contrib.staticfiles  |Version:  1.4
 Severity:  Release blocker  |   Keywords:
 Triage Stage:  Unreviewed   |  Has patch:  0
Easy pickings:  1|  UI/UX:  0
-+
 Traceback (most recent call last):
 {{{
 ...
 ...
   File ".../ENV/local/lib/python2.7/site-
 packages/django/contrib/staticfiles/management/commands/collectstatic.py",
 line 120, in collect
 for original_path, processed_path, processed in processor:
   File ".../ENV/local/lib/python2.7/site-
 packages/django/contrib/staticfiles/storage.py", line 226, in post_process
 content = pattern.sub(converter, content)
 UnicodeDecodeError: 'ascii' codec can't decode byte 0xf0 in position 366:
 ordinal not in range(128)
 }}}

 Reproduce：

 # save a css file that contains non-ascii utf-8 character (ie Chinese
 character):
 {{{
 .icon-link:before { content: "错"; }
 }}}
 # set ``STATICFILES_STORAGE`` to any storage class that will involve
 CachedFilesMixin mixin
 # run ``manage.py collectstatic``

 Howto fix:

 I relace following code:

 {{{
 content = original_file.read().decode
 }}}

 to:

 {{{
 content = original_file.read().decode('utf-8')
 }}}

 just worked as expected.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.