subject:"\[Django\] #18468\: Add the ability to define comments in table \/ columns"

Re: [Django] #18468: Add the ability to define comments in table / columns

2023-01-12 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:
 |  KimSoungRyoul
 Type:  New feature  |   Status:  closed
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by GitHub ):

 In [changeset:"648005dee62481acc1784e5c9625e90f0fd6aab4" 648005d]:
 {{{
 #!CommitTicketReference repository=""
 revision="648005dee62481acc1784e5c9625e90f0fd6aab4"
 Refs #18468 -- Used obj_description() with a catalog name on PostgreSQL.

 obj_description(object oid) without a catalog name is deprecated since
 there is no guarantee that OIDs are unique across different system
 catalogs.

 Thanks Tim Graham for the report.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070185a5efdc86-8f799a01-d1ee-45b2-9909-dae0f13f51e1-00%40eu-central-1.amazonses.com.

Re: [Django] #18468: Add the ability to define comments in table / columns

2022-12-27 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:
 |  KimSoungRyoul
 Type:  New feature  |   Status:  closed
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"78f163a4fb3937aca2e71786fbdd51a0ef39629e" 78f163a]:
 {{{
 #!CommitTicketReference repository=""
 revision="78f163a4fb3937aca2e71786fbdd51a0ef39629e"
 Fixed #18468 -- Added support for comments on columns and tables.

 Thanks Jared Chung, Tom Carrick, David Smith, Nick Pope, and Mariusz
 Felisiak for reviews.

 Co-authored-by: Mariusz Felisiak 
 Co-authored-by: Nick Pope 
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701855758c51d-14655aaf-b741-44f0-9956-d49f0ecb8e94-00%40eu-central-1.amazonses.com.

Re: [Django] #18468: Add the ability to define comments in table / columns

2022-12-27 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:
 |  KimSoungRyoul
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070185536f849c-5355442a-fe08-4ac6-901e-f04a0bae9efb-00%40eu-central-1.amazonses.com.

Re: [Django] #18468: Add the ability to define comments in table / columns

2022-12-27 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:
 |  KimSoungRyoul
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/0107018552f367ad-750a51e0-5ad9-4f30-9689-74d353c65e2c-00%40eu-central-1.amazonses.com.

Re: [Django] #18468: Add the ability to define comments in table / columns

2022-12-20 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:
 |  KimSoungRyoul
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * owner:  Jared Chung => KimSoungRyoul


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701852ec6ebe0-da5215e3-1bd9-4a76-80bc-f10a703a3171-00%40eu-central-1.amazonses.com.

Re: [Django] #18468: Add the ability to define comments in table / columns

2022-11-03 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:  Jared
 |  Chung
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/010701843c9971bf-37bf5616-974a-4c27-8fff-4938e1e86e06-00%40eu-central-1.amazonses.com.

Re: [Django] #18468: Add the ability to define comments in table / columns

2022-10-19 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:  Jared
 |  Chung
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Tim Graham):

 * needs_better_patch:  1 => 0


Comment:

 After updating a patch, you can uncheck "Patch needs improvement" on the
 ticket so that it appears in the review queue.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070183f0cbe692-c4366c01-8df0-4dd0-8bdd-7986368adbc8-00%40eu-central-1.amazonses.com.

Re: [Django] #18468: Add the ability to define comments in table / columns

2022-10-19 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:  Jared
 |  Chung
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by KimSoungRyoul):

 Hi a few days ago I fix pullrequest  to target release 4.2

 Fixed an issue on the Oracle side

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/01070183f0a805fa-95e83ff5-4765-4694-9d06-b0749f0bf7e8-00%40eu-central-1.amazonses.com.

Re: [Django] #18468: Add the ability to define comments in table / columns

2021-10-12 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:  Jared
 |  Chung
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Jared Chung):

 Status update: KSR has updated the patch on github
 https://github.com/django/django/pull/14463 and there's continued
 discussion there, including additional changes proposed by other community
 members...

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.5174435044c9b97ffa806ae2077ce8bb%40djangoproject.com.

Re: [Django] #18468: Add the ability to define comments in table / columns

2021-09-10 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:  Jared
 |  Chung
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * needs_better_patch:  0 => 1
 * stage:  Ready for checkin => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.6fa7e768b3859231a946f92c4d7d13c7%40djangoproject.com.

Re: [Django] #18468: Add the ability to define comments in table / columns

2021-09-04 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:  Jared
 |  Chung
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by KimSoungRyoul):

 May I change assignee to me?perhaps is there any problem?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.11f7f4c01e9d528fa3f80bf1bc8e15aa%40djangoproject.com.

Re: [Django] #18468: Add the ability to define comments in table / columns

2021-08-28 Thread Django

* stage: Accepted => Ready for checkin

Comment:

**Update:** This patch has been reviewed (refer to
[https://github.com/django/django/pull/14463#issuecomment-907692312 this
comment on the Github PR] for the details on the patch review checklist
for this patch). I have marked it "Ready for checkin"

**Note:** Although I am the owner of this ticket, I am NOT the author of
this patch. The author of the patch is KimSoungRyoul. Because I am not the
author, I conducted the patch review using
[https://docs.djangoproject.com/en/dev/internals/contributing/writing-code
/submitting-patches/#patch-review-checklist the patch review checklist].

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/065.e2bef90d2351fced6b3f3293a18fdcb0%40djangoproject.com.

Re: [Django] #18468: Add the ability to define comments in table / columns

2021-08-06 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:  Jared
 |  Chung
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Jared Chung):

 * needs_better_patch:  1 => 0
 * needs_tests:  1 => 0
 * needs_docs:  1 => 0


Old description:

> Hello,
>
> That would be nice if it was possible to include comment on table /
> columns at creation time with the syncdb manage.py option.
>
> 
> 
>
> **new proposal**  (kimsoungryoul : 2020.03.23)
>
> We will develop the code such as below
>
> {{{
>
> class AModel(models.Model):
>  aaa = model.CharField(help_text="i am help_text",
> db_column_comment="i am db_comment",~~~)
>
>  class Meta:
>db_table = "a_model_example_name"
>db_table_comment ="this is a_model comment "
>
> }}}

New description:

 Database-level comments are valuable for database administrators, data
 analysts, data scientists, and others who are looking to consume data that
 is managed by Django. Most Django-supported databases also support table-
 level and column-level comments. This ticket would add functionality to
 Django to allow Django users to specify comments for syncdb manage.py to
 enter into the database.

 
 

 **new proposal**  (kimsoungryoul : 2020.03.23)

 We will develop the code such as below

 {{{

 class AModel(models.Model):
  aaa = model.CharField(help_text="i am help_text",
 db_column_comment="i am db_comment",~~~)

  class Meta:
db_table = "a_model_example_name"
db_table_comment ="this is a_model comment "

 }}}

--

Comment:

 This patch is ready for review. It meets everything on the checklist. I'm
 updating the status so it shows up in `Patches Needing Review` on the
 Development Dashboard.

 If you would like additional information about some of the design and
 implementation decisions behind this patch, please refer to the Github
 Pull Request conversation at https://github.com/django/django/pull/14463

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.72d8011d5dcaff9ffb93ac052d3654e5%40djangoproject.com.

Re: [Django] #18468: Add the ability to define comments in table / columns

2021-07-25 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:  Jared
 |  Chung
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Jared Chung):

 Update: This feature is still being actively developed. KimSoungRyoul has
 been leading the development, and we've received input as well from
 knyghty on the PR. Docs and unit tests have been written, and right now we
 are discussing edge cases that need to be properly handled or explicitly
 "unsupported" (such as, for example, Django model classes or fields that
 Django doesn't actually create in the db such as M2M fields, proxy models,
 abstract base classes, and more).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.3b5f9504d57f01fd559663d161aacf18%40djangoproject.com.

Re: [Django] #18468: Add the ability to define comments in table / columns

2021-06-06 Thread Django

Comment (by Jared Chung):

Status update: KimSoungRyoul has created a new PR
([https://github.com/django/django/pull/14463/ here]) that addresses some
of the suggestions raised by atombrella in May 2020 on the previous PR
([https://github.com/django/django/pull/12605 here]). Huge thanks to
KimSoungRyoul for resuming work on this feature!

The new PR is not complete yet. Still needed:
1) Test coverage.
2) Additional changes to the proposed docs including further explanation,
a warning about lack of SQLite support, and a warning about overwriting
comments made by DBAs in the db, versionadded annotation, and a couple
other things.
3) Release note.
4) General code review, especially related to where sqlite warnings should
be triggered in the code to avoid having hard-coded vendor names in
django/db/models/base.py.

Next steps: I'll add some suggestions directly to the new PR and post
updates here as this PR progresses.

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/065.a49a2d434ef979374edfd0690e18914f%40djangoproject.com.

Re: [Django] #18468: Add the ability to define comments in table / columns

2021-05-08 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:  jchubber
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  dev
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by jchubber):

 * owner:  KimSoungRyoul => jchubber


Comment:

 Owner updated based on suggestion in django-developers group
 https://groups.google.com/g/django-developers/c/guVTzO3RhUs

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.3cd14ec50538911d3ff31e2278333aea%40djangoproject.com.

Re: [Django] #18468: Add the ability to define comments in table / columns

2020-12-01 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:
 |  KimSoungRyoul
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Damien):

 Rebased a previous PR to add support to inspectdb here:
 https://github.com/django/django/pull/13737

 Still missing some tests and it looks like we would like it to be a
 verbose_name field and not a comment

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.4115bf3569791d70f9fa8b831f65fd60%40djangoproject.com.

Re: [Django] #18468: Add the ability to define comments in table / columns

2020-05-02 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:
 |  KimSoungRyoul
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by felixxm):

 This patch is not ready for a review. Docs and tests are still missing.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.991f392b8036ea65bf6324fd71b1e72a%40djangoproject.com.

Re: [Django] #18468: Add the ability to define comments in table / columns

2020-05-02 Thread Django

Comment (by KimSoungRyoul):

Hi felixxm

I want this feature to be reflected in Django.3.1

I know this feature that many people won't use.

but some people who communicate with DBA would be helpful this feature

sometimes ORM take control from DBA

like these situation...

{{{

DBAs: we want to know comment(help_text) not to *.py could you use
COMMENT SQL in migrationFile?

Developers: No, It's Impossible because django ORM does not support
COMMENT SQL

DBAs: that means .. should we refer *.py file everytimes even though
COMMENT SQL exists but can't use?
DBAs: it's illogical

Developers: but if we use COMMENT SQL, we customize everytimes to generate
migrate files
Developers: it's inefficient

}}}

That's one of the reasons for avoiding ORM.

If you don't mind me asking...
could you give me a feedback to this feature?

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/065.3dd09f0b5bd22716468db6cfbcc387dc%40djangoproject.com.

Re: [Django] #18468: Add the ability to define comments in table / columns

2020-04-07 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:
 |  KimSoungRyoul
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by KimSoungRyoul):

 If you don't mind me asking...

 could you give me a feedback to this feature?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.bedc3c8a11a45a28301d6bc25c1e2326%40djangoproject.com.

Re: [Django] #18468: Add the ability to define comments in table / columns

2020-04-05 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:
 |  KimSoungRyoul
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Description changed by KimSoungRyoul:

Old description:

> Hello,
>
> That would be nice if it was possible to include comment on table /
> columns at creation time with the syncdb manage.py option.
>
> 
> 
>
> **new proposal**  (kimsoungryoul : 2020.03.23)
>
> We will develop the code such as below
>
> {{{
>
> class AModel(models.Model):
>  aaa = model.CharField(help_text="i am help_text",
> db_column_comment="i am db_comment",~~~)
>
>  class Meta:
>db_table = "a_model_example_name"
>db_table_comment ="this is a_model comment "
>
> }}}
>
> settings .py
> {{{
>
> ENABLE_DB_COMMENT_WITH_HELP_TEXT = False # default
>
> }}}
>
> if it's True
>
> help_text is used for db_column_comment

New description:

 Hello,

 That would be nice if it was possible to include comment on table /
 columns at creation time with the syncdb manage.py option.

 
 

 **new proposal**  (kimsoungryoul : 2020.03.23)

 We will develop the code such as below

 {{{

 class AModel(models.Model):
  aaa = model.CharField(help_text="i am help_text",
 db_column_comment="i am db_comment",~~~)

  class Meta:
db_table = "a_model_example_name"
db_table_comment ="this is a_model comment "

 }}}

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.53b54ef320582591270d5c19145473f2%40djangoproject.com.

Re: [Django] #18468: Add the ability to define comments in table / columns

2020-04-05 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:
 |  KimSoungRyoul
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by KimSoungRyoul):

 here is mail list for this feature

 https://groups.google.com/forum/?nomobile=true#!topic/django-
 developers/guVTzO3RhUs

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.54dc1741fe5b3ee2216511f2912b29d9%40djangoproject.com.

Re: [Django] #18468: Add the ability to define comments in table / columns

2020-04-05 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:
 |  KimSoungRyoul
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by KimSoungRyoul):

 i agree. your opinion.

 i remove new settings. **ENABLE_DB_COMMENT_WITH_HELP_TEXT**


 AND

 i added few a more commit for support  postgresql oracle

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.8087cd2b258a750aeab6ae6d806f707a%40djangoproject.com.

Re: [Django] #18468: Add the ability to define comments in table / columns

2020-03-29 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:
 |  KimSoungRyoul
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Comment (by felixxm):

 Adding a new setting is always a bit controversial. This should be
 discussed first on DevelopersMailingList. Personally I don't think that we
 need it.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.cc7f37df9c90fe3b86f9a992421791d8%40djangoproject.com.

Re: [Django] #18468: Add the ability to define comments in table / columns

2020-03-29 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:
 |  KimSoungRyoul
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Description changed by KimSoungRyoul:

Old description:

> Hello,
>
> That would be nice if it was possible to include comment on table /
> columns at creation time with the syncdb manage.py option.
>
> 
> 
>
> **new proposal**  (kimsoungryoul : 2020.03.23)
>
> We will develop the code such as below
>
> {{{
>
> class AModel(models.Model):
>  aaa = model.CharField(help_text="i am help_text",
> db_column_comment="i am db_comment",~~~)
>
>  class Meta:
>db_table = "a_model_example_name"
>db_table_comment ="this is a_model comment "
>
> }}}
>

> {{{
>
> settings ENABLE_DB_COMMENT_WITH_HELP_TEXT = False # default
>
> }}}
>
> if it's True
>
> help_text is used for db_column_comment

New description:

 Hello,

 That would be nice if it was possible to include comment on table /
 columns at creation time with the syncdb manage.py option.

 
 

 **new proposal**  (kimsoungryoul : 2020.03.23)

 We will develop the code such as below

 {{{

 class AModel(models.Model):
  aaa = model.CharField(help_text="i am help_text",
 db_column_comment="i am db_comment",~~~)

  class Meta:
db_table = "a_model_example_name"
db_table_comment ="this is a_model comment "

 }}}

 settings .py
 {{{

 ENABLE_DB_COMMENT_WITH_HELP_TEXT = False # default

 }}}

 if it's True

 help_text is used for db_column_comment

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.4ef3a8c3009e67d5ce2d9ac5a7d3224b%40djangoproject.com.

Re: [Django] #18468: Add the ability to define comments in table / columns

2020-03-29 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:
 |  KimSoungRyoul
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Description changed by KimSoungRyoul:

Old description:

> Hello,
>
> That would be nice if it was possible to include comment on table /
> columns at creation time with the syncdb manage.py option.
>
> 
> 
>
> **new proposal**  (kimsoungryoul : 2020.03.23)
>
> We will develop the code such as below
>
> {{{
>
> class AModel(models.Model):
>  aaa = model.CharField(help_text="i am help_text", db_comment="i am
> db_comment",~~~)
>
>  class Meta:
>db_table = "a_model_example_name"
>db_table_comment ="this is a_model comment "
>
> }}}

New description:

 Hello,

 That would be nice if it was possible to include comment on table /
 columns at creation time with the syncdb manage.py option.

 
 

 **new proposal**  (kimsoungryoul : 2020.03.23)

 We will develop the code such as below

 {{{

 class AModel(models.Model):
  aaa = model.CharField(help_text="i am help_text",
 db_column_comment="i am db_comment",~~~)

  class Meta:
db_table = "a_model_example_name"
db_table_comment ="this is a_model comment "

 }}}


 {{{

 default settings ENABLE_DB_COMMENT_WITH_HELP_TEXT = False

 }}}

 if it's True

 help_text is used for db_column_comment

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.5fc28a3c22288f5060b130267a2a3555%40djangoproject.com.

Re: [Django] #18468: Add the ability to define comments in table / columns

2020-03-29 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:
 |  KimSoungRyoul
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Description changed by KimSoungRyoul:

Old description:

> Hello,
>
> That would be nice if it was possible to include comment on table /
> columns at creation time with the syncdb manage.py option.
>
> 
> 
>
> **new proposal**  (kimsoungryoul : 2020.03.23)
>
> We will develop the code such as below
>
> {{{
>
> class AModel(models.Model):
>  aaa = model.CharField(help_text="i am help_text",
> db_column_comment="i am db_comment",~~~)
>
>  class Meta:
>db_table = "a_model_example_name"
>db_table_comment ="this is a_model comment "
>
> }}}
>

> {{{
>
> default settings ENABLE_DB_COMMENT_WITH_HELP_TEXT = False
>
> }}}
>
> if it's True
>
> help_text is used for db_column_comment

New description:

 Hello,

 That would be nice if it was possible to include comment on table /
 columns at creation time with the syncdb manage.py option.

 
 

 **new proposal**  (kimsoungryoul : 2020.03.23)

 We will develop the code such as below

 {{{

 class AModel(models.Model):
  aaa = model.CharField(help_text="i am help_text",
 db_column_comment="i am db_comment",~~~)

  class Meta:
db_table = "a_model_example_name"
db_table_comment ="this is a_model comment "

 }}}


 {{{

 settings ENABLE_DB_COMMENT_WITH_HELP_TEXT = False # default

 }}}

 if it's True

 help_text is used for db_column_comment

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.fb7152bebce5d05e4bbc348ff58e89d7%40djangoproject.com.

Re: [Django] #18468: Add the ability to define comments in table / columns

2020-03-23 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:
 |  KimSoungRyoul
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Description changed by KimSoungRyoul:

Old description:

> Hello,
>
> That would be nice if it was possible to include comment on table /
> columns at creation time with the syncdb manage.py option.
>

>
> **new proposal**  (kimsoungryoul : 2020.03.23)
>
> We will develop the code such as below
>
> {{{
>
> class AModel(models.Model):
>  aaa = model.CharField(help_text="i am help_text", db_comment="i am
> db_comment",~~~)
>
>  class Meta:
>db_table = "a_model_example_name"
>db_table_comment ="this is a_model comment "
>
> }}}

New description:

 Hello,

 That would be nice if it was possible to include comment on table /
 columns at creation time with the syncdb manage.py option.

 
 

 **new proposal**  (kimsoungryoul : 2020.03.23)

 We will develop the code such as below

 {{{

 class AModel(models.Model):
  aaa = model.CharField(help_text="i am help_text", db_comment="i am
 db_comment",~~~)

  class Meta:
db_table = "a_model_example_name"
db_table_comment ="this is a_model comment "

 }}}

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.de624b1c76ecb34084a9c2001c2fbab4%40djangoproject.com.

Re: [Django] #18468: Add the ability to define comments in table / columns

2020-03-23 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:
 |  KimSoungRyoul
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Description changed by KimSoungRyoul:

Old description:

> Hello,
>
> That would be nice if it was possible to include comment on table /
> columns at creation time with the syncdb manage.py option.
>

>
> **new proposal**
>
> We will develop the code such as below
>
> {{{
>
> class AModel(models.Model):
>  aaa = model.CharField(help_text="i am help_text", db_comment="i am
> db_comment",~~~)
>
>  class Meta:
>db_table = "a_model_example_name"
>db_table_comment ="this is a_model comment "
>
> }}}

New description:

 Hello,

 That would be nice if it was possible to include comment on table /
 columns at creation time with the syncdb manage.py option.



 **new proposal**  (kimsoungryoul : 2020.03.23)

 We will develop the code such as below

 {{{

 class AModel(models.Model):
  aaa = model.CharField(help_text="i am help_text", db_comment="i am
 db_comment",~~~)

  class Meta:
db_table = "a_model_example_name"
db_table_comment ="this is a_model comment "

 }}}

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.d40fbf6eb3e09001683eb71b012b47fc%40djangoproject.com.

Re: [Django] #18468: Add the ability to define comments in table / columns

2020-03-23 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:
 |  KimSoungRyoul
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Description changed by KimSoungRyoul:

Old description:

> Hello,
>
> That would be nice if it was possible to include comment on table /
> columns at creation time with the syncdb manage.py option.
>
> There could be a new Model Meta option like:
>comment = 'This table is for storing blabla"
> And a new Field option like:
>comment = 'This field is for ...'
>
> Thanks a lot

New description:

 Hello,

 That would be nice if it was possible to include comment on table /
 columns at creation time with the syncdb manage.py option.



 **new proposal**

 We will develop the code such as below

 {{{

 class AModel(models.Model):
  aaa = model.CharField(help_text="i am help_text", db_comment="i am
 db_comment",~~~)

  class Meta:
db_table = "a_model_example_name"
db_table_comment ="this is a_model comment "

 }}}

--

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.a3eeb3f4b1c86a46d5171a0648d1565c%40djangoproject.com.

Re: [Django] #18468: Add the ability to define comments in table / columns

2020-03-23 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:
 |  KimSoungRyoul
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-

Old description:

> Hello,
>
> That would be nice if it was possible to include comment on table /
> columns at creation time with the syncdb manage.py option.
>
> There could be a new Model Meta option like:
>comment = 'This table is for storing blabla"
> And a new Field option like:
>comment = 'This field is for ...'
>
> Thanks a lot

New description:

 Hello,

 That would be nice if it was possible to include comment on table /
 columns at creation time with the syncdb manage.py option.

 There could be a new Model Meta option like:
comment = 'This table is for storing blabla"
 And a new Field option like:
comment = 'This field is for ...'

 Thanks a lot

--

Comment (by KimSoungRyoul):

 i assign it to me

 i will close this pullRequest caused by imperfection
 https://github.com/django/django/pull/12605

 I will bring a new PullRequest as soon as possible.

 in at least a week

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.2a9500c97daa164584193e6f414c3bdc%40djangoproject.com.

Re: [Django] #18468: Add the ability to define comments in table / columns

2020-03-22 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:
 |  KimSoungRyoul
 Type:  New feature  |   Status:  assigned
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  1|  Needs documentation:  1
  Needs tests:  1|  Patch needs improvement:  1
Easy pickings:  0|UI/UX:  0
-+-
Changes (by felixxm):

 * status:  new => assigned
 * needs_better_patch:  0 => 1
 * needs_tests:  0 => 1
 * owner:  nobody => KimSoungRyoul
 * needs_docs:  0 => 1
 * has_patch:  0 => 1


Comment:

 [https://github.com/django/django/pull/12605 PR]

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.9d9847e33d3e284f3b03f90cfc672ef0%40djangoproject.com.

Re: [Django] #18468: Add the ability to define comments in table / columns

2019-11-07 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Ivan Chernoff):

 Replying to [comment:13 Rodrigo Silva]:
 > Replying to [comment:8 Ivan Chernoff]:
 > > After discussion on mailing list, the feature is good and can be
 added. (https://groups.google.com/forum/?nomobile=true#!topic/django-
 developers/guVTzO3RhUs)
 > > I'll prepare patch for review.
 >
 > Any news on this patch? It looks like there is a green light for one,
 and Tim already answered  about the preferable approach. Do you need any
 help on making this hapen? It would be a fantastic feature for Django!

 I've a small library based on contenttype design: on post-migrate it
 copies all comments to database (PostgreSQL only).
 https://github.com/vanadium23/django-db-comments

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.a9d66624739099e17159243879500ee6%40djangoproject.com.

Re: [Django] #18468: Add the ability to define comments in table / columns

2019-11-04 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by MestreLion):

 Replying to [comment:8 Ivan Chernoff]:
 > After discussion on mailing list, the feature is good and can be added.
 (https://groups.google.com/forum/?nomobile=true#!topic/django-
 developers/guVTzO3RhUs)
 > I'll prepare patch for review.

 Any news on this patch? It looks like there is a green light for one, and
 Tim already answered  about the preferable approach. Do you need any help
 on making this hapen? It would be a fantastic feature for Django!

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.00dac99af91b0920b5f6e96f787c5a21%40djangoproject.com.

Re: [Django] #18468: Add the ability to define comments in table / columns

2018-03-23 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham):

 I'm not sure what you mean by "comment for django admin". There isn't an
 existing option with that name.

 As for the implementation, the second approach sounds better.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.e2247499242813d15891c6458a5d80c3%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18468: Add the ability to define comments in table / columns

2018-03-23 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Ivan Chernoff):

 Anyone?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.61729c960770dfd50107f051160a7395%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18468: Add the ability to define comments in table / columns

2018-03-18 Thread Django

Comment (by Ivan Chernoff):

Replying to [comment:9 Tim Graham]:
> I guess the model field option could be called `db_column_comment`. I
closed #28407 (introspecting column comments) as a duplicate since that
should be implemented as part of this.

I think that we don't need new param, because `comment` for django admin
may be useful to store in database. But I can't decide on implementation,
can you give me an advice?
Postgres and oracle have a syntax like `comment on {table}.{column}` for
storing comments, so this needs to be done after table/column creation, so
there are two ways:

1. Add it to post migrate signal, as for content types. But I can
implement it as a third-party lib
2. Add this SQL after database creation in schema.py

Which way is better?

--
Ticket URL:
Django
The Web framework for perfectionists with deadlines.

--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/django-updates/065.863158b8e61123925e7f36f56165d90e%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18468: Add the ability to define comments in table / columns

2018-03-12 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Tim Graham):

 I guess the model field option could be called `db_column_comment`. I
 closed #28407 (introspecting column comments) as a duplicate since that
 should be implemented as part of this.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.6e1b0ba7cfee126a170902d3abaf8fee%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18468: Add the ability to define comments in table / columns

2018-03-11 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  Marc Rechté  |Owner:  nobody
 Type:  New feature  |   Status:  new
Component:  Database layer   |  Version:  master
  (models, ORM)  |
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Ivan Chernoff):

 * status:  closed => new
 * cc: Ivan Chernoff (added)
 * version:  1.4 => master
 * has_patch:  1 => 0
 * resolution:  duplicate =>
 * stage:  Unreviewed => Accepted


Comment:

 After discussion on mailing list, the feature is good and can be added.
 (https://groups.google.com/forum/?nomobile=true#!topic/django-
 developers/guVTzO3RhUs)
 I'll prepare patch for review.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.72e565d0b452b8616be5bc2c7e5db257%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

Re: [Django] #18468: Add the ability to define comments in table / columns (was: Define COMMENT in table / colomns)

2016-06-04 Thread Django

#18468: Add the ability to define comments in table / columns
-+-
 Reporter:  mrechte  |Owner:  nobody
 Type:  New feature  |   Status:  closed
Component:  Database layer   |  Version:  1.4
  (models, ORM)  |
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:   | Triage Stage:
 |  Unreviewed
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by timgraham):

 * status:  new => closed
 * type:  Uncategorized => New feature
 * resolution:   => duplicate


Comment:

 The correct way to reopen a ticket closed as "wontfix" is to start a
 discussion on the DevelopersMailingList. If there is consensus there to
 add the feature, then we reopen the ticket.

--
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/065.9747e1ac097f8561670a0a5a233572ab%40djangoproject.com.
For more options, visit https://groups.google.com/d/optout.

40 matches

Mail list logo