Re: [Django] #18549: Admin should not use verbose_name_plural for OneToOne field

[Django]

#18549: Admin should not use verbose_name_plural for OneToOne field
-+-
 Reporter:  Roy Smith|Owner:  Tim
 |  McCurrach
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"a91bf80459d6674dd8c6a182d0f6296d50be0361" a91bf804]:
 {{{
 #!CommitTicketReference repository=""
 revision="a91bf80459d6674dd8c6a182d0f6296d50be0361"
 [3.2.x] Fixed #18549 -- Fixed heading for inlines with a OneToOneField.

 Used verbose_name instead of verbose_name_plural.

 Backport of 0aff3fd7110d1bd431a35bb28d8688693b98d886 from master.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.594a97c3c5c55307a6138cc45db132b6%40djangoproject.com.

Re: [Django] #18549: Admin should not use verbose_name_plural for OneToOne field

[Django]

#18549: Admin should not use verbose_name_plural for OneToOne field
-+-
 Reporter:  Roy Smith|Owner:  Tim
 |  McCurrach
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:  fixed
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"0aff3fd7110d1bd431a35bb28d8688693b98d886" 0aff3fd7]:
 {{{
 #!CommitTicketReference repository=""
 revision="0aff3fd7110d1bd431a35bb28d8688693b98d886"
 Fixed #18549 -- Fixed heading for inlines with a OneToOneField.

 Used verbose_name instead of verbose_name_plural.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.a29d50c1bb784215ce438857c087a5b6%40djangoproject.com.

Re: [Django] #18549: Admin should not use verbose_name_plural for OneToOne field

[Django]

#18549: Admin should not use verbose_name_plural for OneToOne field
-+-
 Reporter:  Roy Smith|Owner:  Tim
 |  McCurrach
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-

Comment (by Mariusz Felisiak ):

 In [changeset:"13409a0c0db0ae322d58a1fceef678f8bca067fb" 13409a0c]:
 {{{
 #!CommitTicketReference repository=""
 revision="13409a0c0db0ae322d58a1fceef678f8bca067fb"
 Refs #18549 -- Added test for heading of foreign key inlines.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.47f5ea833fc0e4f040bd6f5847446b6b%40djangoproject.com.

Re: [Django] #18549: Admin should not use verbose_name_plural for OneToOne field

[Django]

#18549: Admin should not use verbose_name_plural for OneToOne field
-+-
 Reporter:  Roy Smith|Owner:  Tim
 |  McCurrach
 Type:  Bug  |   Status:  assigned
Component:  contrib.admin|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:   | Triage Stage:  Ready for
 |  checkin
Has patch:  1|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by Mariusz Felisiak):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.24dd31c483b346d76b7d136c49bf2997%40djangoproject.com.

Re: [Django] #18549: Admin should not use verbose_name_plural for OneToOne field

[Django]

#18549: Admin should not use verbose_name_plural for OneToOne field
---+-
 Reporter:  Roy Smith  |Owner:  Tim McCurrach
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by Tim McCurrach):

 * needs_better_patch:  1 => 0
 * needs_tests:  1 => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.37a74785afbb7f7511c46a7beae6c06b%40djangoproject.com.

Re: [Django] #18549: Admin should not use verbose_name_plural for OneToOne field

[Django]

#18549: Admin should not use verbose_name_plural for OneToOne field
---+-
 Reporter:  Roy Smith  |Owner:  Tim McCurrach
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+-
Changes (by Tim McCurrach):

 * owner:  (none) => Tim McCurrach
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.de146e3509f183c233091f14201d5031%40djangoproject.com.

Re: [Django] #18549: Admin should not use verbose_name_plural for OneToOne field

[Django]

#18549: Admin should not use verbose_name_plural for OneToOne field
---+
 Reporter:  Roy Smith  |Owner:  (none)
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Mariusz Felisiak):

 * owner:  vanessagomes => (none)
 * status:  assigned => new


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.406da286bed66e2af17e03bfd8d712d1%40djangoproject.com.

Re: [Django] #18549: Admin should not use verbose_name_plural for OneToOne field

[Django]

#18549: Admin should not use verbose_name_plural for OneToOne field
---+
 Reporter:  Roy Smith  |Owner:  vanessagomes
 Type:  Bug|   Status:  assigned
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+
Changes (by Mariusz Felisiak):

 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.69d2b8f451140b9ac1dac25a0e395520%40djangoproject.com.

Re: [Django] #18549: Admin should not use verbose_name_plural for OneToOne field

[Django]

#18549: Admin should not use verbose_name_plural for OneToOne field
---+
 Reporter:  RoySmith   |Owner:  vanessagomes
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  1  |  Patch needs improvement:  1
Easy pickings:  0  |UI/UX:  0
---+
Changes (by timo):

 * needs_better_patch:  0 => 1
 * needs_tests:  0 => 1


Comment:

 This needs tests, ideally adding `max_num=1` to an existing tabular and
 stacked inline and verifying the  text. The existing patch also causes
 some test failures due to the added whitespace.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.7ff89cf4fc4b881029f346474ecad406%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18549: Admin should not use verbose_name_plural for OneToOne field

[Django]

#18549: Admin should not use verbose_name_plural for OneToOne field
---+
 Reporter:  RoySmith   |Owner:  vanessagomes
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by anonymous):

 * cc: 4glitch@… (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18549: Admin should not use verbose_name_plural for OneToOne field

[Django]

#18549: Admin should not use verbose_name_plural for OneToOne field
---+
 Reporter:  RoySmith   |Owner:  vanessagomes
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by claudep):

 Note that you are hard-coding usage of plural for 0 items, which is not
 true for all languages. However, I'm not sure there is a better solution
 i18n-wise (as using blocktrans will only partially solve it and add a non-
 sense translatable string to po files).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18549: Admin should not use verbose_name_plural for OneToOne field

[Django]

#18549: Admin should not use verbose_name_plural for OneToOne field
---+
 Reporter:  RoySmith   |Owner:  vanessagomes
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+

Comment (by harph):

 I submitted a pull request. This is the url:
 https://github.com/django/django/pull/498

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18549: Admin should not use verbose_name_plural for OneToOne field

[Django]

#18549: Admin should not use verbose_name_plural for OneToOne field
---+
 Reporter:  RoySmith   |Owner:  vanessagomes
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by harph):

 * cc: harph (added)


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18549: Admin should not use verbose_name_plural for OneToOne field

[Django]

#18549: Admin should not use verbose_name_plural for OneToOne field
---+
 Reporter:  RoySmith   |Owner:  vanessagomes
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by harph):

 * has_patch:  0 => 1
 * version:  1.4 => master


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18549: Admin should not use verbose_name_plural for OneToOne field

[Django]

#18549: Admin should not use verbose_name_plural for OneToOne field
---+
 Reporter:  RoySmith   |Owner:  vanessagomes
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by vanessagomes):

 * owner:  nobody => vanessagomes


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #18549: Admin should not use verbose_name_plural for OneToOne field

[Django]

#18549: Admin should not use verbose_name_plural for OneToOne field
---+
 Reporter:  RoySmith   |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  contrib.admin  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  0  |UI/UX:  0
---+
Changes (by julien):

 * needs_docs:   => 0
 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #18549: Admin should not use verbose_name_plural for OneToOne field

[Django]

#18549: Admin should not use verbose_name_plural for OneToOne field
---+
 Reporter:  RoySmith   |  Owner:  nobody
 Type:  Bug| Status:  new
Component:  contrib.admin  |Version:  1.4
 Severity:  Normal |   Keywords:
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  0  |  UI/UX:  0
---+
 Do something like the following:

 {{{
 class Foo(Model):
  i = IntegerField()
  bar = OneToOneField("Bar")

 class FooInline(admin.TabularInline):
 model = Foo

 class Bar(Model):
 i = Integerfield()

 class BarAdmin(admin.ModelAdmin):
 inlines = [FooInline]

 admin.site.register(Foo, FooAdmin)
 admin.site.register(Bar)
 }}}

 When you edit a Bar in the admin, the formset section for entering a Foo
 will be labeled "Foos" (plural).  Since it's a one-to-one mapping, it
 should be labeled "Foo" (singular).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.