Re: [Django] #18593: Admin change list swallows unrelated AttributeErrors from callable display fields

[Django]

#18593: Admin change list swallows unrelated AttributeErrors from callable 
display
fields
-+-
 Reporter:  pjdelport|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  1.4
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:  admin, list_display  | Triage Stage:  Design
Has patch:  1|  decision needed
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by aaugustin):

 Fixed in [617d077f].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18593: Admin change list swallows unrelated AttributeErrors from callable display fields

[Django]

#18593: Admin change list swallows unrelated AttributeErrors from callable 
display
fields
-+-
 Reporter:  pjdelport|Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  contrib.admin|  Version:  1.4
 Severity:  Normal   |   Resolution:  duplicate
 Keywords:  admin, list_display  | Triage Stage:  Design
Has patch:  1|  decision needed
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by aaugustin):

 * status:  new => closed
 * resolution:   => duplicate


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #18593: Admin change list swallows unrelated AttributeErrors from callable display fields

[Django]

#18593: Admin change list swallows unrelated AttributeErrors from callable 
display
fields
-+-
 Reporter:  pjdelport|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:  admin, list_display  | Triage Stage:  Design
Has patch:  1|  decision needed
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by pjdelport):

 I found an older ticket for this same bug: #16655.

 From the comments, the proposed change was discussed and accepted back
 then, but needed a test: does this patch resolve that?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #18593: Admin change list swallows unrelated AttributeErrors from callable display fields

[Django]

#18593: Admin change list swallows unrelated AttributeErrors from callable 
display
fields
-+-
 Reporter:  pjdelport|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:  admin, list_display  | Triage Stage:  Design
Has patch:  1|  decision needed
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by aaugustin):

 * stage:  Unreviewed => Design decision needed


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #18593: Admin change list swallows unrelated AttributeErrors from callable display fields

[Django]

#18593: Admin change list swallows unrelated AttributeErrors from callable 
display
fields
-+-
 Reporter:  pjdelport|Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.admin|  Version:  1.4
 Severity:  Normal   |   Resolution:
 Keywords:  admin, list_display  | Triage Stage:
Has patch:  1|  Unreviewed
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  0|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by pjdelport):

 * needs_docs:   => 0
 * has_patch:  0 => 1
 * needs_tests:   => 0
 * needs_better_patch:   => 0


Comment:

 I added a fix and regression test for this on !GitHub:
 [https://github.com/django/django/pull/193 #193].

 It turns out the test suite itself contained a latent bug that was being
 masked by this: the above patch fixes that too.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #18593: Admin change list swallows unrelated AttributeErrors from callable display fields

[Django]

#18593: Admin change list swallows unrelated AttributeErrors from callable 
display
fields
---+-
 Reporter:  pjdelport  |  Owner:  nobody
 Type:  Bug| Status:  new
Component:  contrib.admin  |Version:  1.4
 Severity:  Normal |   Keywords:  admin, list_display
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  0  |  UI/UX:  0
---+-
 If a callable display field on a model or model admin raises either an
 `AttributeError`, the interface currently captures the error, and renders
 the field as `EMPTY_CHANGELIST_VALUE`.

 This behavior is surprising and confusing when the `AttributeError`
 originates in unrelated user code called by the display field: errors like
 third-party app bugs or missing settings get silenced, and the field's
 content simply becomes "(None)". There's no hint to a novice about what
 went wrong, or where to look next.

 The code responsible for this is in
 
[https://github.com/django/django/blob/1.4/django/contrib/admin/templatetags/admin_list.py#L167
 templatetags/admin_list.py]'s `items_for_result()`, around
 `lookup_field()`. As far as i can tell, all the valid empty fields cases
 are covered by results of `ObjectDoesNotExist` or `None`, and not
 `AttributeError`: a missing attribute specified in `list_display` normally
 result in `ImproperlyConfigured` instead.

 If there's no compelling reason to capture `AttributeError` like this, can
 it simply be removed from the exception list, and allowed to propagate?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.