Re: [Django] #18614: https://docs.djangoproject.com/en/1.4/topics/forms/ missing some sample code

[Django]

#18614: https://docs.djangoproject.com/en/1.4/topics/forms/ missing some sample
code
-+-
 Reporter:  xarses@… |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:  1.4
Component:  Documentation|   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:  from csrf missing|  checkin
  imports|  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  1|
-+-

Comment (by Kevin London ):

 In [c6d06a9453859c5520312454b6353498332ff838]:
 {{{
 #!CommitTicketReference repository=""
 revision="c6d06a9453859c5520312454b6353498332ff838"
 [1.4.x] Fixed #18614 -- Added imports and changed render_to_response to
 render.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18614: https://docs.djangoproject.com/en/1.4/topics/forms/ missing some sample code

[Django]

#18614: https://docs.djangoproject.com/en/1.4/topics/forms/ missing some sample
code
-+-
 Reporter:  xarses@… |Owner:  nobody
 Type:   |   Status:  closed
  Cleanup/optimization   |  Version:  1.4
Component:  Documentation|   Resolution:  fixed
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:  from csrf missing|  checkin
  imports|  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  1|
-+-
Changes (by Florian Apolloner ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [7d06f975fe445f0393455b3eb9ec17dbe04f2ec3]:
 {{{
 #!CommitTicketReference repository=""
 revision="7d06f975fe445f0393455b3eb9ec17dbe04f2ec3"
 Fixed #18614 -- Added missing imports in code samples.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18614: https://docs.djangoproject.com/en/1.4/topics/forms/ missing some sample code

[Django]

#18614: https://docs.djangoproject.com/en/1.4/topics/forms/ missing some sample
code
-+-
 Reporter:  xarses@… |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  1.4
Component:  Documentation|   Resolution:
 Severity:  Normal   | Triage Stage:  Ready for
 Keywords:  from csrf missing|  checkin
  imports|  Needs documentation:  0
Has patch:  1|  Patch needs improvement:  0
  Needs tests:  0|UI/UX:  0
Easy pickings:  1|
-+-
Changes (by jezdez):

 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18614: https://docs.djangoproject.com/en/1.4/topics/forms/ missing some sample code

[Django]

#18614: https://docs.djangoproject.com/en/1.4/topics/forms/ missing some sample
code
-+-
 Reporter:  xarses@… |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  1.4
Component:  Documentation|   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  from csrf missing|  Needs documentation:  0
  imports|  Patch needs improvement:  0
Has patch:  1|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-
Changes (by kevinlondon):

 * has_patch:  0 => 1


Comment:

 Fork: https://github.com/kevinlondon/django/tree/ticket_18614_1_4

 Pull Request: https://github.com/django/django/pull/212

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #18614: https://docs.djangoproject.com/en/1.4/topics/forms/ missing some sample code

[Django]

#18614: https://docs.djangoproject.com/en/1.4/topics/forms/ missing some sample
code
-+-
 Reporter:  xarses@… |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  1.4
Component:  Documentation|   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  from csrf missing|  Needs documentation:  0
  imports|  Patch needs improvement:  0
Has patch:  0|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-

Comment (by xarses):

 Replying to [comment:1 aaugustin]:
 > Replying to [ticket:18614 xarses@…]:
 > > The first two examples should include example file names that the code
 might be inside, since we might be new to the whole model / view concept.
 >
 > We don't generally include file names in code samples, maybe because
 Django leaves a lot of flexibility on code layout. You're supposed to have
 gone through the tutorial first and be familiar with models, views and
 templates.

 Alright, doesn't matter that much, been reading some of the other db
 examples and they have been saying stuff along the lines of "your model
 ... {code block}.

 Yes I've read the tutorial but still like to get a better idea of what
 this blob is supposed to represent.

 >
 > 
 >
 > > in https://docs.djangoproject.com/en/1.4/topics/forms/#using-a-form-
 in-a-view
 > > example is missing import statements for HttpResponseRedirect and
 render_to_response
 > > example's final return is missing
 context_instance=RequestContext(request) after the dictionary, or a note
 needs to be made about this when explaining {% csrf_token %}. import path
 should also be referenced.
 >
 > Yes, we should include import paths, and switch to `render` while we're
 there.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

Re: [Django] #18614: https://docs.djangoproject.com/en/1.4/topics/forms/ missing some sample code

[Django]

#18614: https://docs.djangoproject.com/en/1.4/topics/forms/ missing some sample
code
-+-
 Reporter:  xarses@… |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  1.4
Component:  Documentation|   Resolution:
 Severity:  Normal   | Triage Stage:  Accepted
 Keywords:  from csrf missing|  Needs documentation:  0
  imports|  Patch needs improvement:  0
Has patch:  0|UI/UX:  0
  Needs tests:  0|
Easy pickings:  1|
-+-
Changes (by aaugustin):

 * needs_docs:   => 0
 * needs_better_patch:   => 0
 * type:  Bug => Cleanup/optimization
 * needs_tests:   => 0
 * stage:  Unreviewed => Accepted


Comment:

 Replying to [ticket:18614 xarses@…]:
 > The first two examples should include example file names that the code
 might be inside, since we might be new to the whole model / view concept.

 We don't generally include file names in code samples, maybe because
 Django leaves a lot of flexibility on code layout. You're supposed to have
 gone through the tutorial first and be familiar with models, views and
 templates.

 

 > in https://docs.djangoproject.com/en/1.4/topics/forms/#using-a-form-
 in-a-view
 > example is missing import statements for HttpResponseRedirect and
 render_to_response
 > example's final return is missing
 context_instance=RequestContext(request) after the dictionary, or a note
 needs to be made about this when explaining {% csrf_token %}. import path
 should also be referenced.

 Yes, we should include import paths, and switch to `render` while we're
 there.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.

[Django] #18614: https://docs.djangoproject.com/en/1.4/topics/forms/ missing some sample code

[Django]

#18614: https://docs.djangoproject.com/en/1.4/topics/forms/ missing some sample
code
---+---
 Reporter:  xarses@…   |  Owner:  nobody
 Type:  Bug| Status:  new
Component:  Documentation  |Version:  1.4
 Severity:  Normal |   Keywords:  from csrf missing imports
 Triage Stage:  Unreviewed |  Has patch:  0
Easy pickings:  1  |  UI/UX:  0
---+---
 The first two examples should include example file names that the code
 might be inside, since we might be new to the whole model / view concept.

 in https://docs.djangoproject.com/en/1.4/topics/forms/#using-a-form-
 in-a-view
 example is missing import statements for HttpResponseRedirect and
 render_to_response
 example's final return is missing context_instance=RequestContext(request)
 after the dictionary, or a note needs to be made about this when
 explaining {% csrf_token %}. import path should also be referenced.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit this group at 
http://groups.google.com/group/django-updates?hl=en.