Re: [Django] #18625: Docs contain examples that use old-style {% url %} syntax
#18625: Docs contain examples that use old-style {% url %} syntax
-+
Reporter: russellm |Owner: nobody
Type: Bug | Status: closed
Component: Documentation| Version: master
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0| Needs documentation: 1
Needs tests: 0| Patch needs improvement: 0
Easy pickings: 1|UI/UX: 0
-+
Comment (by russellm):
No, this should *not* be ported back to 1.4. In 1.4, the old style syntax
was still the correct default; the new style syntax was an opt-in. If we
were to use the new style syntax in the 1.4 docs, we'd have to explain the
change every time the url tag was used.
--
Ticket URL:
Django
Re: [Django] #18625: Docs contain examples that use old-style {% url %} syntax
#18625: Docs contain examples that use old-style {% url %} syntax
-+
Reporter: russellm |Owner: nobody
Type: Bug | Status: closed
Component: Documentation| Version: master
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0| Needs documentation: 1
Needs tests: 0| Patch needs improvement: 0
Easy pickings: 1|UI/UX: 0
-+
Comment (by aastrand):
I think this should be backported to 1.4.
--
Ticket URL:
Django
Re: [Django] #18625: Docs contain examples that use old-style {% url %} syntax
#18625: Docs contain examples that use old-style {% url %} syntax
-+
Reporter: russellm |Owner: nobody
Type: Bug | Status: closed
Component: Documentation| Version: master
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0| Needs documentation: 1
Needs tests: 0| Patch needs improvement: 0
Easy pickings: 1|UI/UX: 0
-+
Comment (by aaugustin):
The audit was performed with a search for `\{% url [^'"]` in the docs
source tree.
--
Ticket URL:
Django
Re: [Django] #18625: Docs contain examples that use old-style {% url %} syntax
#18625: Docs contain examples that use old-style {% url %} syntax
-+
Reporter: russellm |Owner: nobody
Type: Bug | Status: closed
Component: Documentation| Version: master
Severity: Release blocker | Resolution: fixed
Keywords: | Triage Stage: Accepted
Has patch: 0| Needs documentation: 1
Needs tests: 0| Patch needs improvement: 0
Easy pickings: 1|UI/UX: 0
-+
Changes (by Aymeric Augustin ):
* status: new => closed
* resolution: => fixed
Comment:
In [fb46f243b4c48ab42ed2f33a2636f7c33f5861a9]:
{{{
#!CommitTicketReference repository=""
revision="fb46f243b4c48ab42ed2f33a2636f7c33f5861a9"
Fixed #18625 -- Removed old-style use of url tag
from the documentation.
}}}
--
Ticket URL:
Django
[Django] #18625: Docs contain examples that use old-style {% url %} syntax
#18625: Docs contain examples that use old-style {% url %} syntax
---+
Reporter: russellm | Owner: nobody
Type: Bug | Status: new
Component: Documentation|Version: master
Severity: Release blocker | Keywords:
Triage Stage: Accepted | Has patch: 0
Needs documentation: 1|Needs tests: 0
Patch needs improvement: 0| Easy pickings: 1
UI/UX: 0|
---+
Via Per-Olof Åstrand on django-users:
The Django docs on named URLs contains an example that uses the old-style
URL tag syntax. From
https://docs.djangoproject.com/en/dev/topics/http/urls/#naming-url-
patterns :
{{{
{% url arch-summary 1945 %}
{% url full-archive 2007 %}
}}}
Should read:
{{{
{% url "arch-summary" 1945 %}
{% url "full-archive" 2007 %}
}}}
(i.e., the URL tag arguments should be quoted).
I doubt this is the only example in the docs where this slip occurs; 1.5
is the first Django version where the new-style syntax is mandatory, so we
should audit the docs and look for any other old-style examples that need
to be updated.
--
Ticket URL:
Django
