Re: [Django] #18747: Django admin list_display eats AttributeError by mistake
#18747: Django admin list_display eats AttributeError by mistake +-- Reporter: liu.dongyuan@… |Owner: tswicegood Type: Bug | Status: closed Component: contrib.admin | Version: 1.4 Severity: Normal | Resolution: duplicate Keywords: | Triage Stage: Accepted Has patch: 1 | Needs documentation: 0 Needs tests: 1 | Patch needs improvement: 1 Easy pickings: 0 |UI/UX: 0 +-- Comment (by aaugustin): Fixed in [617d077f]. -- Ticket URL: <https://code.djangoproject.com/ticket/18747#comment:4> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To post to this group, send email to django-updates@googlegroups.com. To unsubscribe from this group, send email to django-updates+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [Django] #18747: Django admin list_display eats AttributeError by mistake
#18747: Django admin list_display eats AttributeError by mistake +-- Reporter: liu.dongyuan@… |Owner: tswicegood Type: Bug | Status: closed Component: contrib.admin | Version: 1.4 Severity: Normal | Resolution: duplicate Keywords: | Triage Stage: Accepted Has patch: 1 | Needs documentation: 0 Needs tests: 1 | Patch needs improvement: 1 Easy pickings: 0 |UI/UX: 0 +-- Changes (by tswicegood): * status: new => closed * resolution: => duplicate Comment: There are actually a few older versions of this: * #18593 * #16655 Going to close as a duplicate. -- Ticket URL: <https://code.djangoproject.com/ticket/18747#comment:3> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To post to this group, send email to django-updates@googlegroups.com. To unsubscribe from this group, send email to django-updates+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [Django] #18747: Django admin list_display eats AttributeError by mistake
#18747: Django admin list_display eats AttributeError by mistake +-- Reporter: liu.dongyuan@… |Owner: tswicegood Type: Bug | Status: new Component: contrib.admin | Version: 1.4 Severity: Normal | Resolution: Keywords: | Triage Stage: Accepted Has patch: 1 | Needs documentation: 0 Needs tests: 1 | Patch needs improvement: 1 Easy pickings: 0 |UI/UX: 0 +-- Changes (by tswicegood): * owner: thikonom => tswicegood * needs_better_patch: 0 => 1 * status: assigned => new * needs_tests: 0 => 1 * stage: Unreviewed => Accepted Comment: Definitely something we should probably handle, though I think there's a better way to figure out where the exception came from. Taking a stab at the patch. -- Ticket URL: <https://code.djangoproject.com/ticket/18747#comment:2> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To post to this group, send email to django-updates@googlegroups.com. To unsubscribe from this group, send email to django-updates+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: [Django] #18747: Django admin list_display eats AttributeError by mistake
#18747: Django admin list_display eats AttributeError by mistake +-- Reporter: liu.dongyuan@… |Owner: thikonom Type: Bug | Status: assigned Component: contrib.admin | Version: 1.4 Severity: Normal | Resolution: Keywords: | Triage Stage: Unreviewed Has patch: 1 | Needs documentation: 0 Needs tests: 0 | Patch needs improvement: 0 Easy pickings: 0 |UI/UX: 0 +-- Changes (by thikonom): * status: new => assigned * needs_better_patch: => 0 * needs_tests: => 0 * owner: nobody => thikonom * needs_docs: => 0 * has_patch: 0 => 1 Comment: Since i suppose the AttributeError is catched this way by design, i amended the code to distinguish between the Exception raise by the model itself or by any other object -- Ticket URL: <https://code.djangoproject.com/ticket/18747#comment:1> Django <https://code.djangoproject.com/> The Web framework for perfectionists with deadlines. -- You received this message because you are subscribed to the Google Groups "Django updates" group. To post to this group, send email to django-updates@googlegroups.com. To unsubscribe from this group, send email to django-updates+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
[Django] #18747: Django admin list_display eats AttributeError by mistake
#18747: Django admin list_display eats AttributeError by mistake
+
Reporter: liu.dongyuan@… | Owner: nobody
Type: Bug | Status: new
Component: contrib.admin |Version: 1.4
Severity: Normal | Keywords:
Triage Stage: Unreviewed | Has patch: 0
Easy pickings: 0 | UI/UX: 0
+
When Django admin list_display calling custom method, the exception
AttributeError can't be seen.
See the sample snippets below.
{{{
class ExampleAdmin(admin.ModelAdmin):
def example(self, field):
raise AttributeError
list_display = ('example',)
}}}
{{{
class ExampleAdmin(admin.ModelAdmin):
def example(self, field):
a = 1
a.encode("utf8")
list_display = ('example',)
}}}
--
Ticket URL: <https://code.djangoproject.com/ticket/18747>
Django <https://code.djangoproject.com/>
The Web framework for perfectionists with deadlines.
--
You received this message because you are subscribed to the Google Groups
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
