Re: [Django] #18803: Django FormWizard.as_view condition_dict callable called multiple times?

[Django]

#18803: Django FormWizard.as_view condition_dict callable called multiple times?
-+-
 Reporter:  mikewatsup@… |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  contrib.formtools|  Version:  1.4
 Severity:  Release blocker  |   Resolution:  fixed
 Keywords:  form wizard, | Triage Stage:
  as_view, condition_dict argument   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by JasonL.Thompson ):

 * resolution:  invalid => fixed


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18803: Django FormWizard.as_view condition_dict callable called multiple times?

[Django]

#18803: Django FormWizard.as_view condition_dict callable called multiple times?
-+-
 Reporter:  mikewatsup@… |Owner:  nobody
 Type:  Bug  |   Status:  closed
Component:  contrib.formtools|  Version:  1.4
 Severity:  Release blocker  |   Resolution:  invalid
 Keywords:  form wizard, | Triage Stage:
  as_view, condition_dict argument   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by lrekucki):

 * status:  new => closed
 * resolution:   => invalid


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18803: Django FormWizard.as_view condition_dict callable called multiple times?

[Django]

#18803: Django FormWizard.as_view condition_dict callable called multiple times?
-+-
 Reporter:  mikewatsup@… |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  contrib.formtools|  Version:  1.4
 Severity:  Release blocker  |   Resolution:
 Keywords:  form wizard, | Triage Stage:
  as_view, condition_dict argument   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by lrekucki):

 * needs_better_patch:   => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


Comment:

 This isn't a bug. The wizard doesn't make any guarantees about calling the
 conditions only once. On the contrary, the whole point of having a
 callable is being able to dynamically adjust the list of forms based on
 validation results (so the form_list will differ between validation and
 rendering).

 PS. The {{{as_view()}}} method is intended to be called only once per life
 of application (usually in {{{urls.py}}}), not on every request. While
 it's not an error to do so, it's a bit inefficient.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #18803: Django FormWizard.as_view condition_dict callable called multiple times?

[Django]

#18803: Django FormWizard.as_view condition_dict callable called multiple times?
-+-
 Reporter:   |  Owner:  nobody
  mikewatsup@…   | Status:  new
 Type:  Bug  |Version:  1.4
Component:   |   Keywords:  form wizard, as_view,
  contrib.formtools  |  condition_dict argument
 Severity:  Release  |  Has patch:  0
  blocker|  UI/UX:  0
 Triage Stage:   |
  Unreviewed |
Easy pickings:  0|
-+-
 The following is a snippet of how I have setup my FormWizard. When I hit
 this view function, 'bar' gets printed once and 'foo' gets printed 7
 times:

 {{{
 #!python
 # views.py
 def _show_repair_item_form_condition(wizard):
 print 'foo'
 return True

 @login_required
 def workshop(request):
 print 'bar'
 cw = WorkshopWizard.as_view([WorkshopRepairItemFormSet, EmptyForm],
 condition_dict={'0': _show_repair_item_form_condition})
 return cw(request)
 }}}

 I have looked at the implmentation of the as_view function and can't find
 any trace of a bug causing this to happen. There is no documentation on
 the web about this issue either.

 Any ideas?

 Thanks, Mike

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.