Re: [Django] #18853: get_template_names() does not consider the queryset-only case

[Django]

#18853: get_template_names() does not consider the queryset-only case
---+-
 Reporter:  msopacua   |Owner:  apollo13
 Type:  Bug|   Status:  closed
Component:  Generic views  |  Version:  master
 Severity:  Normal |   Resolution:  duplicate
 Keywords:  CBV| Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  0
---+-
Changes (by jambonrose):

 * status:  assigned => closed
 * resolution:   => duplicate


Comment:

 This is a duplicate of #16502. Please see that issue for resolution of
 this problem.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.7ab30826e2886ed875cfe88d0590b9a6%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18853: get_template_names() does not consider the queryset-only case

[Django]

#18853: get_template_names() does not consider the queryset-only case
---+
 Reporter:  msopacua   |Owner:  apollo13
 Type:  Bug|   Status:  assigned
Component:  Generic views  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  CBV| Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  0
---+
Changes (by timo):

 * needs_better_patch:  0 => 1
 * stage:  Ready for checkin => Accepted


Comment:

 Patch no longer applies cleanly.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/066.d8384415fe0181ce9d5348b004948e0c%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18853: get_template_names() does not consider the queryset-only case

[Django]

#18853: get_template_names() does not consider the queryset-only case
-+-
 Reporter:  msopacua |Owner:  apollo13
 Type:  Bug  |   Status:  assigned
Component:  Generic views|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  CBV  | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  1|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by apollo13):

 * owner:  nobody => apollo13
 * status:  new => assigned


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18853: get_template_names() does not consider the queryset-only case

[Django]

#18853: get_template_names() does not consider the queryset-only case
-+-
 Reporter:  msopacua |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Generic views|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  CBV  | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  1|  Patch needs improvement:  0
 |UI/UX:  0
-+-

Comment (by bhuztez):

 #16502 is a similar problem. I guess patch there may also fix this
 problem.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18853: get_template_names() does not consider the queryset-only case

[Django]

#18853: get_template_names() does not consider the queryset-only case
-+-
 Reporter:  msopacua |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Generic views|  Version:  master
 Severity:  Normal   |   Resolution:
 Keywords:  CBV  | Triage Stage:  Ready for
Has patch:  1|  checkin
  Needs tests:  0|  Needs documentation:  0
Easy pickings:  1|  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by jwmayfield):

 * status:  assigned => new
 * owner:  jwmayfield => nobody


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18853: get_template_names() does not consider the queryset-only case

[Django]

#18853: get_template_names() does not consider the queryset-only case
-+-
 Reporter:  msopacua |Owner:
 Type:  Bug  |  jwmayfield
Component:  Generic views|   Status:  assigned
 Severity:  Normal   |  Version:  master
 Keywords:  CBV  |   Resolution:
Has patch:  1| Triage Stage:  Ready for
  Needs tests:  0|  checkin
Easy pickings:  1|  Needs documentation:  0
 |  Patch needs improvement:  0
 |UI/UX:  0
-+-
Changes (by jwmayfield):

 * status:  new => assigned
 * owner:  nobody => jwmayfield
 * stage:  Accepted => Ready for checkin


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18853: get_template_names() does not consider the queryset-only case

[Django]

#18853: get_template_names() does not consider the queryset-only case
---+
 Reporter:  msopacua   |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Generic views  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  CBV| Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Changes (by jwmayfield):

 * cc: jason@… (added)
 * type:  Uncategorized => Bug
 * stage:  Unreviewed => Accepted


Comment:

 Patch applies cleanly.  Test fails before applying fix.  Test passes after
 applying fix.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18853: get_template_names() does not consider the queryset-only case

[Django]

#18853: get_template_names() does not consider the queryset-only case
---+--
 Reporter:  msopacua   |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Generic views  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  CBV| Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--

Comment (by msopacua):

 Replying to [comment:1 charettes]:
 > IMHO replacing the `hasattr(self, 'queryset') and self.queryset is not
 None` part by `getattr(self, 'queryset', None) is not None` would increase
 readability.

 Agreed, but it's inline with the coding style of the file, see line 150
 right above. Style fixes are the committers' realm. ;)

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18853: get_template_names() does not consider the queryset-only case

[Django]

#18853: get_template_names() does not consider the queryset-only case
---+--
 Reporter:  msopacua   |Owner:  nobody
 Type:  Uncategorized  |   Status:  new
Component:  Generic views  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords:  CBV| Triage Stage:  Unreviewed
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--
Changes (by charettes):

 * needs_docs:   => 0
 * needs_tests:   => 0
 * needs_better_patch:   => 0


Comment:

 IMHO replacing the `hasattr(self, 'queryset') and self.queryset is not
 None` part by `getattr(self, 'queryset', None) is not None` would increase
 readability.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #18853: get_template_names() does not consider the queryset-only case

[Django]

#18853: get_template_names() does not consider the queryset-only case
---+
 Reporter:  msopacua   |  Owner:  nobody
 Type:  Uncategorized  | Status:  new
Component:  Generic views  |Version:  master
 Severity:  Normal |   Keywords:  CBV
 Triage Stage:  Unreviewed |  Has patch:  1
Easy pickings:  1  |  UI/UX:  0
---+
 In SingleObjectTemplateResponseMixin candidate names are generated using
 the model name. This model name is derived either from self.object or
 self.model but does not consider self.queryset. In the case of "create
 forms", self.object is unset and if self.model is not provided either, an
 exception is thrown much later by the template loader in select_template.
 This exception does not point to this method as it successfully returns an
 (empty) list.
 The test suite kind of contains a test for this
 (generic_views/edit.py:test_create_without_redirect), but the problem is
 that the test posts data to the form and does not actually request the
 form. In the practical case this form could never have been submitted as
 it wouldn't be rendered.
 Patch attached fixes the issue and creates a test.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.