Re: [Django] #18862: FlatPages get_absolute_url should pay attention to script prefix

[Django]

#18862: FlatPages get_absolute_url should pay attention to script prefix
--+
 Reporter:  GunnarScherf  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  closed
Component:  contrib.flatpages |  Version:  1.4
 Severity:  Normal|   Resolution:  fixed
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by Aymeric Augustin ):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 In [changeset:"a44531ae1592cf266e6c24387f49d665c639b480"]:
 {{{
 #!CommitTicketReference repository=""
 revision="a44531ae1592cf266e6c24387f49d665c639b480"
 Fixed #18862 -- Honored script prefix in FlatPage.get_absolute_url.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18862: FlatPages get_absolute_url should pay attention to script prefix

[Django]

#18862: FlatPages get_absolute_url should pay attention to script prefix
--+
 Reporter:  GunnarScherf  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.flatpages |  Version:  1.4
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+

Comment (by aaugustin):

 Yes, this is necessary because flatpages bypass the URL resolver (and
 specifically the `reverse` function) entirely.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18862: FlatPages get_absolute_url should pay attention to script prefix

[Django]

#18862: FlatPages get_absolute_url should pay attention to script prefix
--+
 Reporter:  GunnarScherf  |Owner:  nobody
 Type:  Cleanup/optimization  |   Status:  new
Component:  contrib.flatpages |  Version:  1.4
 Severity:  Normal|   Resolution:
 Keywords:| Triage Stage:  Accepted
Has patch:  0 |  Needs documentation:  0
  Needs tests:  0 |  Patch needs improvement:  0
Easy pickings:  0 |UI/UX:  0
--+
Changes (by claudep):

 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #18862: FlatPages get_absolute_url should pay attention to script prefix

[Django]

#18862: FlatPages get_absolute_url should pay attention to script prefix
-+-
 Reporter:  GunnarScherf |Owner:  nobody
 Type:   |   Status:  new
  Cleanup/optimization   |  Version:  1.4
Component:  contrib.flatpages|   Resolution:
 Severity:  Normal   | Triage Stage:
 Keywords:   |  Unreviewed
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  0|UI/UX:  0
-+-
Changes (by thejaswi_puthraya):

 * needs_docs:   => 0
 * component:  Uncategorized => contrib.flatpages
 * needs_tests:   => 0
 * needs_better_patch:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #18862: FlatPages get_absolute_url should pay attention to script prefix

[Django]

#18862: FlatPages get_absolute_url should pay attention to script prefix
--+
 Reporter:  GunnarScherf  |  Owner:  nobody
 Type:  Cleanup/optimization  | Status:  new
Component:  Uncategorized |Version:  1.4
 Severity:  Normal|   Keywords:
 Triage Stage:  Unreviewed|  Has patch:  0
Easy pickings:  0 |  UI/UX:  0
--+
 When hosting a django app under a subpath of a domain, then
 get_absolute_url returns the url without the subpath.

 {{{
 def get_absolute_url(self):
 return self.url

 }}}
 Better would be if the subpath is recognized
 {{{
 def get_absolute_url(self):
 absolute_url = "%s%s" % (get_script_prefix().rstrip('/'),
 self.url)
 return absolute_url

 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.