Re: [Django] #19031: Add a warning that @override_settings may not work with DATABASES

[Django]

#19031: Add a warning that @override_settings may not work with DATABASES
---+
 Reporter:  jonash |Owner:  joeri
 Type:  New feature|   Status:  closed
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+

Comment (by Aymeric Augustin ):

 In [changeset:"eabc3b6c8dd67e9ff49da9f2f41cc653898cd0a1"]:
 {{{
 #!CommitTicketReference repository=""
 revision="eabc3b6c8dd67e9ff49da9f2f41cc653898cd0a1"
 Set stacklevel for the override_settings warning.

 Refs #19031.
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.e0199c8922edb2469a752bbd9c06c4e4%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19031: Add a warning that @override_settings may not work with DATABASES

[Django]

#19031: Add a warning that @override_settings may not work with DATABASES
---+
 Reporter:  jonash |Owner:  joeri
 Type:  New feature|   Status:  closed
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:  fixed
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Changes (by Tim Graham ):

 * status:  assigned => closed
 * resolution:   => fixed


Comment:

 In [changeset:"66f3d57b79eee0381c29ee4c76582d6b182bfad9"]:
 {{{
 #!CommitTicketReference repository=""
 revision="66f3d57b79eee0381c29ee4c76582d6b182bfad9"
 Fixed #19031 -- Added a warning when using override_settings with
 'DATABASES'
 }}}

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.941fbae88bec80457c3a4baa28c56162%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19031: Add a warning that @override_settings may not work with DATABASES (was: Add a warning that @override_settings may not work with DATABASES and CACHES)

[Django]

#19031: Add a warning that @override_settings may not work with DATABASES
---+
 Reporter:  jonash |Owner:  joeri
 Type:  New feature|   Status:  assigned
Component:  Testing framework  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Changes (by timo):

 * needs_better_patch:  1 => 0
 * version:  1.4 => master


Comment:

 On further investigating of #20075, `CACHES` can be overridden but there
 are some caveats. I've updated the proposed documentation change with
 these details and removed `CACHES` from generating a warning.  New
 [https://github.com/django/django/pull/1348 PR].

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.0f20bf9b87bcb1f8f1f8b7f678ace8a9%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19031: Add a warning that @override_settings may not work with DATABASES and CACHES

[Django]

#19031: Add a warning that @override_settings may not work with DATABASES and
CACHES
---+
 Reporter:  jonash |Owner:  joeri
 Type:  New feature|   Status:  assigned
Component:  Testing framework  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  0
---+

Comment (by timo):

 Was looking into editing the pull request with my comments and noticed
 this causes the Django test suite to throw a warning because
 `django/contrib/sessions/tests.py` calls `@override_settings` with
 `CACHES`. Not sure how we should handle this, since it appears `CACHES`
 can apparently be overridden successfully, at least in some cases?

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.937d85accfc2feb5d2c53b191366c869%40djangoproject.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19031: Add a warning that @override_settings may not work with DATABASES and CACHES (was: Using @override_settings doesn't override DATABASES in threads +SQLite)

[Django]

#19031: Add a warning that @override_settings may not work with DATABASES and
CACHES
---+
 Reporter:  jonash |Owner:  joeri
 Type:  New feature|   Status:  assigned
Component:  Testing framework  |  Version:  1.4
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  1  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  1
Easy pickings:  1  |UI/UX:  0
---+
Changes (by timo):

 * cc: timograham@… (added)
 * needs_better_patch:  0 => 1
 * type:  Bug => New feature


Comment:

 Left some comments on the pull request.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to django-updates+unsubscr...@googlegroups.com.
To post to this group, send email to django-updates@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/django-updates/064.52cc3d405f4642bc93c5d8bf282d0f37%40djangoproject.com?hl=en.
For more options, visit https://groups.google.com/groups/opt_out.