Re: [Django] #19161: Line missing on Dev documentation

[Django]

#19161: Line missing on Dev documentation
-+
 Reporter:  DavidW   |Owner:  nobody
 Type:  Bug  |   Status:  new
Component:  Documentation|  Version:  master
 Severity:  Release blocker  |   Resolution:
 Keywords:   | Triage Stage:  Accepted
Has patch:  0|  Needs documentation:  0
  Needs tests:  0|  Patch needs improvement:  0
Easy pickings:  1|UI/UX:  0
-+
Changes (by russellm):

 * severity:  Normal => Release blocker


Comment:

 Actually, this should be a release blocker, since it's a fundamentally
 misleading piece of documentation in a new feature.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19161: Line missing on Dev documentation

[Django]

#19161: Line missing on Dev documentation
---+
 Reporter:  DavidW |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Documentation  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Accepted
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+
Changes (by russellm):

 * stage:  Unreviewed => Accepted


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19161: Line missing on Dev documentation

[Django]

#19161: Line missing on Dev documentation
---+--
 Reporter:  DavidW |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Documentation  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--

Old description:

> https://docs.djangoproject.com/en/dev/topics/auth/#auth-custom-user
>
> class UserChangeForm(forms.ModelForm):
> """A form for updateing users. Includes all the fields on
> the user, but replaces the password field with admin's
> pasword hash display field.
> """
> password = ReadOnlyPasswordHashField()
>
> class Meta:
> model = MyUser
>
> Needs the following added:
>
> def clean_password(self):
> # Regardless of what the user provides, return the initial value.
> # This is done here, rather than on the field, because the
> # field does not have access to the initial value
> return self.initial["password"]
>
> Or you get a not-null constraint violation on form submit.

New description:

 https://docs.djangoproject.com/en/dev/topics/auth/#auth-custom-user

 {{{
 class UserChangeForm(forms.ModelForm):
 """A form for updateing users. Includes all the fields on
 the user, but replaces the password field with admin's
 pasword hash display field.
 """
 password = ReadOnlyPasswordHashField()

 class Meta:
 model = MyUser
 }}}

 Needs the following added:

 {{{
 def clean_password(self):
 # Regardless of what the user provides, return the initial value.
 # This is done here, rather than on the field, because the
 # field does not have access to the initial value
 return self.initial["password"]
 }}}

 Or you get a not-null constraint violation on form submit.

--

Comment (by aaugustin):

 Fixed formatting (please use preview).

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: [Django] #19161: Line missing on Dev documentation

[Django]

#19161: Line missing on Dev documentation
---+--
 Reporter:  DavidW |Owner:  nobody
 Type:  Bug|   Status:  new
Component:  Documentation  |  Version:  master
 Severity:  Normal |   Resolution:
 Keywords: | Triage Stage:  Unreviewed
Has patch:  0  |  Needs documentation:  0
  Needs tests:  0  |  Patch needs improvement:  0
Easy pickings:  1  |UI/UX:  0
---+--
Changes (by lrekucki):

 * needs_better_patch:   => 0
 * has_patch:  1 => 0
 * needs_tests:   => 0
 * needs_docs:   => 0


-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

[Django] #19161: Line missing on Dev documentation

[Django]

#19161: Line missing on Dev documentation
---+
 Reporter:  DavidW |  Owner:  nobody
 Type:  Bug| Status:  new
Component:  Documentation  |Version:  master
 Severity:  Normal |   Keywords:
 Triage Stage:  Unreviewed |  Has patch:  1
Easy pickings:  1  |  UI/UX:  0
---+
 https://docs.djangoproject.com/en/dev/topics/auth/#auth-custom-user

 class UserChangeForm(forms.ModelForm):
 """A form for updateing users. Includes all the fields on
 the user, but replaces the password field with admin's
 pasword hash display field.
 """
 password = ReadOnlyPasswordHashField()

 class Meta:
 model = MyUser

 Needs the following added:

 def clean_password(self):
 # Regardless of what the user provides, return the initial value.
 # This is done here, rather than on the field, because the
 # field does not have access to the initial value
 return self.initial["password"]

 Or you get a not-null constraint violation on form submit.

-- 
Ticket URL: 
Django 
The Web framework for perfectionists with deadlines.

-- 
You received this message because you are subscribed to the Google Groups 
"Django updates" group.
To post to this group, send email to django-updates@googlegroups.com.
To unsubscribe from this group, send email to 
django-updates+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.